unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Consensus: Make backports easier with reflowed list of file names, tests, and locales.
@ 2020-12-14 16:51 Carlos O'Donell via Libc-alpha
  2020-12-14 17:57 ` DJ Delorie via Libc-alpha
  2020-12-15  1:12 ` Joseph Myers
  0 siblings, 2 replies; 5+ messages in thread
From: Carlos O'Donell via Libc-alpha @ 2020-12-14 16:51 UTC (permalink / raw
  To: libc-alpha

I would like to request we consider the following for consensus:

* All Makefile lists of:
  - File names
  - Tests
  - Locales

* Should be broken out into one item per line and sorted in
  alphabetical order.

Note: ABI lists have automation for sorting and are considered distinct.

The goal would be to:

* Improve accuracy of automatic conflict resolution.

* Improve accuracy of manual conflict resolution.

* Avoid conflicts.

Examples:

"[PATCH] nptl: Split libpthread-routines into one routine per line"
https://sourceware.org/pipermail/libc-alpha/2020-December/120667.html
- Make libpthread-routines one file per line, sorted alphabetically.

"Adapt collation in several locales to the new iso14651_t1_common file"
commit 159738548130d5ac4fe6178977e940ed5f8cfdc4
- Make test-input one locale per file, sorted alphabetically.

Thoughts?

-- 
Cheers,
Carlos.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Consensus: Make backports easier with reflowed list of file names,  tests, and locales.
  2020-12-14 16:51 Consensus: Make backports easier with reflowed list of file names, tests, and locales Carlos O'Donell via Libc-alpha
@ 2020-12-14 17:57 ` DJ Delorie via Libc-alpha
  2020-12-15  1:12 ` Joseph Myers
  1 sibling, 0 replies; 5+ messages in thread
From: DJ Delorie via Libc-alpha @ 2020-12-14 17:57 UTC (permalink / raw
  To: Carlos O'Donell; +Cc: libc-alpha

"Carlos O'Donell via Libc-alpha" <libc-alpha@sourceware.org> writes:
> * Should be broken out into one item per line and sorted in
>   alphabetical order.

I'm rather surprised we aren't already doing this...


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Consensus: Make backports easier with reflowed list of file names, tests, and locales.
  2020-12-14 16:51 Consensus: Make backports easier with reflowed list of file names, tests, and locales Carlos O'Donell via Libc-alpha
  2020-12-14 17:57 ` DJ Delorie via Libc-alpha
@ 2020-12-15  1:12 ` Joseph Myers
  2020-12-15  2:25   ` Siddhesh Poyarekar
  2020-12-15 22:43   ` Carlos O'Donell via Libc-alpha
  1 sibling, 2 replies; 5+ messages in thread
From: Joseph Myers @ 2020-12-15  1:12 UTC (permalink / raw
  To: Carlos O'Donell; +Cc: libc-alpha

On Mon, 14 Dec 2020, Carlos O'Donell via Libc-alpha wrote:

> * Should be broken out into one item per line and sorted in
>   alphabetical order.

Meaning LC_COLLATE=C order?  So test-2 comes before test1, not after as it 
does in some locales, for example.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Consensus: Make backports easier with reflowed list of file names, tests, and locales.
  2020-12-15  1:12 ` Joseph Myers
@ 2020-12-15  2:25   ` Siddhesh Poyarekar
  2020-12-15 22:43   ` Carlos O'Donell via Libc-alpha
  1 sibling, 0 replies; 5+ messages in thread
From: Siddhesh Poyarekar @ 2020-12-15  2:25 UTC (permalink / raw
  To: Joseph Myers, Carlos O'Donell; +Cc: libc-alpha

On 12/15/20 6:42 AM, Joseph Myers wrote:
> On Mon, 14 Dec 2020, Carlos O'Donell via Libc-alpha wrote:
> 
>> * Should be broken out into one item per line and sorted in
>>    alphabetical order.
> 
> Meaning LC_COLLATE=C order?  So test-2 comes before test1, not after as it
> does in some locales, for example.
> 

Maybe we should rename test1 to test-1, or test-2 to test2.  Or even 
better, have descriptive names but that would be busy work that will 
need inspecting each test.

Siddhesh

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Consensus: Make backports easier with reflowed list of file names, tests, and locales.
  2020-12-15  1:12 ` Joseph Myers
  2020-12-15  2:25   ` Siddhesh Poyarekar
@ 2020-12-15 22:43   ` Carlos O'Donell via Libc-alpha
  1 sibling, 0 replies; 5+ messages in thread
From: Carlos O'Donell via Libc-alpha @ 2020-12-15 22:43 UTC (permalink / raw
  To: Joseph Myers; +Cc: libc-alpha

On 12/14/20 8:12 PM, Joseph Myers wrote:
> On Mon, 14 Dec 2020, Carlos O'Donell via Libc-alpha wrote:
> 
>> * Should be broken out into one item per line and sorted in
>>   alphabetical order.
> 
> Meaning LC_COLLATE=C order?  So test-2 comes before test1, not after as it 
> does in some locales, for example.

Yes, LC_COLLATE=C order.

I would rename test-2.

-- 
Cheers,
Carlos.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-15 22:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-14 16:51 Consensus: Make backports easier with reflowed list of file names, tests, and locales Carlos O'Donell via Libc-alpha
2020-12-14 17:57 ` DJ Delorie via Libc-alpha
2020-12-15  1:12 ` Joseph Myers
2020-12-15  2:25   ` Siddhesh Poyarekar
2020-12-15 22:43   ` Carlos O'Donell via Libc-alpha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).