From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3DDEC1F454 for ; Sat, 9 Nov 2019 13:25:04 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=n41rSyDjwcGrZXcn 057uRy7eTd6YC+OyiHXS3iU54DNg3Q/kQZhxtTOCAs3BTXoOAX3Y9KW2qX5i28in OxlVEBz+Zln/9rW0yxTsYHlQaIa1HssF+AlR0i9eb0NdwMUxo4Vx2Govf/7QxCs3 Q6QZC+zmnqp6A2Pu+y+JSYuc4AQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=O60cCbPPdTIP0FBNBvUKEm 6xrB4=; b=hutCLf4nS5s5TxGWEq0+gh+skwgFKfmE2NodGwEkfD8nK1c/1qK3CX APFu0ElG5d53T9zCi7GfLGXVphJdIvTU5PW8LYPmex9ppIgT2fRtxfGCuSnWJbP5 CvsJL+rIQOHR5deO5Y16LwiIB+biTMytRK7dl8XYDJEiOBiP2wjXs= Received: (qmail 84891 invoked by alias); 9 Nov 2019 13:25:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 84881 invoked by uid 89); 9 Nov 2019 13:25:02 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com Subject: Re: RFC: test-in-container vs ld.so To: DJ Delorie , Florian Weimer Cc: libc-alpha@sourceware.org References: From: Carlos O'Donell Message-ID: <5017d712-3a64-2f4c-a092-484fe5c2d0e2@redhat.com> Date: Sat, 9 Nov 2019 08:24:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/8/19 6:54 PM, DJ Delorie wrote: > > This patch seems to work, but we don't have a lot of containerized > tests, and my setup is "normal" (esp compared to Joseph's ;) > > diff --git a/Rules b/Rules > index 8dbac56ce6..9ca5e14092 100644 > --- a/Rules > +++ b/Rules > @@ -275,8 +275,8 @@ $(objpfx)%.out: /dev/null $(objpfx)% # Make it 2nd arg for canned sequence. > # tests-container. > $(tests-container:%=$(objpfx)%.out): $(objpfx)%.out : $(if $(wildcard $(objpfx)%.files),$(objpfx)%.files,/dev/null) $(objpfx)% > $(test-wrapper-env) $(run-program-env) $(run-via-rtld-prefix) \ > - $(common-objpfx)support/test-container env $(run-program-env) $($*-ENV) \ > - $(host-test-program-cmd) $($*-ARGS) > $@; \ > + $(common-objpfx)support/test-container env $($*-ENV) \ > + $(built-program-file) $($*-ARGS) > $@; \ > $(evaluate-test) > > > FWIW, that looks good to me. You could just propose this as a patch and we could try to run with it and see what happens. We don't have a multi-target tester, except for the build bots but they are not well maintained at this point (we'd like to fix this, but that will take time). -- Cheers, Carlos.