From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 312B61F8C6 for ; Mon, 9 Aug 2021 12:27:44 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 864E438930F9 for ; Mon, 9 Aug 2021 12:27:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 864E438930F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628512062; bh=lT62Qd90uiz/oHJkwC48cQB7ICsNQiWf9ybdjXOcrSw=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=l7E1OJZipxUecqvRHYhslme5rRwMCFD3LzVxof2hqSUTN66C/8imxcBxyzi/oGXMt RIHlcaLFvs2s3PMhC8NxDfn7S8GzmBOIagq8xVnLRJKKU0p2KFZ/9b/0qI+LvP+OkO Q+SgDaKOyOZKhwbo8BKJQkQOLlXOcNqRP+fxCbas= Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 27036385482F for ; Mon, 9 Aug 2021 12:27:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27036385482F Received: by mail-pl1-x635.google.com with SMTP id k2so16093526plk.13 for ; Mon, 09 Aug 2021 05:27:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lT62Qd90uiz/oHJkwC48cQB7ICsNQiWf9ybdjXOcrSw=; b=fEYpzCJ1w0rSETh3lNKFHhrOV+LMVxWWCfUK/mfbwdQ9/wTRwgOH3CKz4thWmSYaiN 0lnRZ0fwANcJpy4xM5JPFKMUIUmAuH0dJmVBWpMoLLiE4lizZ+eKS2zuToeoOatlclMU hV5H7yiEAmHi0Bgs458WhTcZyGOQhsI8YOmkLZ8Iaj6p/gGgWy2jYH+VDPtm8OJYnPz+ P7eyCVOl6XqbOVx+NClJ95H/xEvAODnMXZq4gvyEVWVtzntjdbzc70K5X+I5USKOQh3f XetVL+qhYXmNHrz6iAR4Kw1uIfCB9syVbb4nNKOvK16+Jo3eT+LjX720ai9y2BKoiWHE lfwQ== X-Gm-Message-State: AOAM532WsO9MGB55d3McwPBOkG1F86NGWjEJ4M1MH+0Rot5wuPtpTSEt ZL+Xbp8tNpuLJSsV4/KtyM8sJw== X-Google-Smtp-Source: ABdhPJxC5wt0x+gH3Heh1UuHnILs7m9KsnDJIoecJG0zlvrVcER8FAyfeHzIH+DMr/gEtoNC3fbjJw== X-Received: by 2002:a17:902:da8d:b029:12c:5241:c24e with SMTP id j13-20020a170902da8db029012c5241c24emr19996463plx.35.1628512042177; Mon, 09 Aug 2021 05:27:22 -0700 (PDT) Received: from ?IPv6:2804:431:c7cb:9dce:a96c:8a7f:2ffc:f373? ([2804:431:c7cb:9dce:a96c:8a7f:2ffc:f373]) by smtp.gmail.com with ESMTPSA id q21sm10181681pjg.55.2021.08.09.05.27.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 05:27:21 -0700 (PDT) Subject: Re: [RFC][PATCH v12 1/8] Define a new dynamic section tag - DT_GNU_FLAGS_1 (bug 22745) To: libc-alpha@sourceware.org, Vivek Das Mohapatra References: <20210708163255.812-1-vivek@collabora.com> <20210708163255.812-2-vivek@collabora.com> Message-ID: <4a4948cb-266b-6daf-ab74-a47780359a07@linaro.org> Date: Mon, 9 Aug 2021 09:27:19 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708163255.812-2-vivek@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 08/07/2021 13:32, Vivek Das Mohapatra via Libc-alpha wrote: > Define a new flags section DT_GNU_FLAGS_1 (no more bits are available > in DT_GNU_FLAGS). > > One flag is currently defined: DF_GNU_1_UNIQUE. > > libc and its companion DSOs (libpthread et al) should have this > section and flag set. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > elf/elf.h | 7 ++++++- > elf/get-dynamic-info.h | 12 ++++++++++++ > include/elf.h | 2 ++ > include/link.h | 1 + > 4 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/elf/elf.h b/elf/elf.h > index 2a62b98d4a..448c275d10 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -896,6 +896,7 @@ typedef struct > Dyn.d_un.d_val field of the Elf*_Dyn structure. This follows Sun's > approach. */ > #define DT_VALRNGLO 0x6ffffd00 > +#define DT_GNU_FLAGS_1 0x6ffffdf4 /* GNU extension flags */ > #define DT_GNU_PRELINKED 0x6ffffdf5 /* Prelinking timestamp */ > #define DT_GNU_CONFLICTSZ 0x6ffffdf6 /* Size of conflict section */ > #define DT_GNU_LIBLISTSZ 0x6ffffdf7 /* Size of library list */ > @@ -910,7 +911,7 @@ typedef structselectable > #define DT_SYMINENT 0x6ffffdff /* Entry size of syminfo */ > #define DT_VALRNGHI 0x6ffffdff > #define DT_VALTAGIDX(tag) (DT_VALRNGHI - (tag)) /* Reverse order! */ > -#define DT_VALNUM 12 > +#define DT_VALNUM 13 > > /* DT_* entries which fall between DT_ADDRRNGHI & DT_ADDRRNGLO use the > Dyn.d_un.d_ptr field of the Elf*_Dyn structure. Ok. > @@ -999,6 +1000,10 @@ typedef struct > #define DF_1_WEAKFILTER 0x20000000 > #define DF_1_NOCOMMON 0x40000000 > > +/* State flags selectable in the `d_un.d_val' element of the DT_GNU_FLAGS_1 > + entry in the dynamic section. */ > +#define DF_GNU_1_UNIQUE 0x00000001 /* Load max 1 copy of this DSO. */ > + > /* Flags for the feature selection in DT_FEATURE_1. */ > #define DTF_1_PARINIT 0x00000001 > #define DTF_1_CONFEXP 0x00000002 Ok. > diff --git a/elf/get-dynamic-info.h b/elf/get-dynamic-info.h > index d8ec32377d..8082d84ba1 100644 > --- a/elf/get-dynamic-info.h > +++ b/elf/get-dynamic-info.h > @@ -175,6 +175,18 @@ elf_get_dynamic_info (struct link_map *l, ElfW(Dyn) *temp) > if (l->l_flags_1 & DF_1_NOW) > info[DT_BIND_NOW] = info[VERSYMIDX (DT_FLAGS_1)]; > } > + if (info[DT_VALTAGIDX (DT_GNU_FLAGS_1) > + + DT_NUM + DT_THISPROCNUM + DT_VERSIONTAGNUM + DT_EXTRANUM] != NULL) > + { > + l->l_gnu_flags_1 = info[DT_VALTAGIDX (DT_GNU_FLAGS_1) > + + DT_NUM + DT_THISPROCNUM > + + DT_VERSIONTAGNUM + DT_EXTRANUM]->d_un.d_val; > + > + if (__glibc_unlikely (GLRO(dl_debug_mask) & DL_DEBUG_FILES) > + && l->l_gnu_flags_1 & ~DT_GNU_1_SUPPORTED_MASK) > + _dl_debug_printf ("\nWARNING: Unsupported flag value(s) of 0x%x in DT_GNU_FLAGS_1.\n", > + l->l_gnu_flags_1 & ~DT_GNU_1_SUPPORTED_MASK); > + } > if (info[DT_RUNPATH] != NULL) > /* If both RUNPATH and RPATH are given, the latter is ignored. */ > info[DT_RPATH] = NULL; Ok. > diff --git a/include/elf.h b/include/elf.h > index 14ed67ff67..5eee37c294 100644 > --- a/include/elf.h > +++ b/include/elf.h > @@ -25,5 +25,7 @@ > (DF_1_NOW | DF_1_NODELETE | DF_1_INITFIRST | DF_1_NOOPEN \ > | DF_1_ORIGIN | DF_1_NODEFLIB | DF_1_PIE) > > +#define DT_GNU_1_SUPPORTED_MASK DF_GNU_1_UNIQUE > + > #endif /* !_ISOMAC */ > #endif /* elf.h */ Ok. > diff --git a/include/link.h b/include/link.h > index 4af16cb596..6ed35eb808 100644 > --- a/include/link.h > +++ b/include/link.h > @@ -283,6 +283,7 @@ struct link_map > unsigned int l_used; > > /* Various flag words. */ > + ElfW(Word) l_gnu_flags_1; > ElfW(Word) l_feature_1; > ElfW(Word) l_flags_1; > ElfW(Word) l_flags; > OK.