From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions
Date: Mon, 1 Jun 2020 15:32:57 -0300 [thread overview]
Message-ID: <48e1cf71-fb16-da08-d94f-6a2281c84039@linaro.org> (raw)
In-Reply-To: <6dc09d6c-e957-eeb5-34e7-089d3d608cd8@synopsys.com>
On 01/06/2020 15:12, Vineet Gupta wrote:
> On 6/1/20 7:42 AM, Adhemerval Zanella via Libc-alpha wrote:
>> You will need to move this definitions inside the !USE_SQRTF_BUILTIN
>> to avoid defined by not used warnings. Current practice is to just
>> open code the constants and let compiler optimize the constant pool:
>
> Won't it be better to keep the const variable and trust the compiler to subsume it
> instead of open coding in multiple places. Makes it more readable ?
I don't have a strong preference, it is just the recent math optimizations
use the constant directly in the hex format instead of trying to factoring
them out.
next prev parent reply other threads:[~2020-06-01 18:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 2:00 [PATCH 0/5] use gcc builtins for sqrt and fma functions Vineet Gupta via Libc-alpha
2020-05-30 2:00 ` [PATCH 1/5] ARC/dl-runtime helper macros Vineet Gupta via Libc-alpha
2020-05-30 2:17 ` Vineet Gupta via Libc-alpha
2020-05-30 2:00 ` [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions Vineet Gupta via Libc-alpha
2020-06-01 14:13 ` Adhemerval Zanella via Libc-alpha
2020-06-01 14:42 ` Adhemerval Zanella via Libc-alpha
2020-06-01 18:12 ` Vineet Gupta via Libc-alpha
2020-06-01 18:32 ` Adhemerval Zanella via Libc-alpha [this message]
2020-06-01 14:18 ` Florian Weimer
2020-06-01 18:12 ` Vineet Gupta via Libc-alpha
2020-05-30 2:00 ` [PATCH 3/5] iee754: prvoide gcc builtins based generic fma functions Vineet Gupta via Libc-alpha
2020-06-01 14:20 ` Adhemerval Zanella via Libc-alpha
2020-06-01 16:13 ` Florian Weimer
2020-05-30 2:00 ` [PATCH 4/5] aarch/fpu: use generic sqrt, " Vineet Gupta via Libc-alpha
2020-06-01 16:38 ` Adhemerval Zanella via Libc-alpha
2020-06-01 21:44 ` Vineet Gupta via Libc-alpha
2020-06-01 22:08 ` Ramana Radhakrishnan via Libc-alpha
2020-06-02 18:12 ` Joseph Myers
2020-05-30 2:00 ` [PATCH 5/5] powerpc/fpu: use generic " Vineet Gupta via Libc-alpha
2020-06-01 17:10 ` Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e1cf71-fb16-da08-d94f-6a2281c84039@linaro.org \
--to=libc-alpha@sourceware.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=adhemerval.zanella@linaro.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).