From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0B1231F454 for ; Fri, 8 Nov 2019 13:50:01 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=j350mb2RCNxIVBzc NdPUuaOqAl5HkILmqVU009TKkoHr4RUU+vX4TheiqNnKWbsTz93GnSvb47ou64lY Ak+KPG5jd3FBoXpYYqvikTOec1d3yb7F/ho/2Okv/7c3ev3T581vyyGp2+YpOCxi IWoq3WjB51Upu68Pp3tz361+gFw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=yQXSdGyy8b8zNddNWK88JW BfH7k=; b=W+3t+EQx4vVcdIJdAlDuff3bcT0nCKMLqCXJTaldGoGGe/B9bMPjCp YosJFgrdm13X72ceqgSp8NfnORokwael2GkpPVEFk2NHS0ocJLpYOi0qMRe+4YAG McX+xJNKyzQyHd07oPl11LIP3KEIcRBcjVvFHYUGXA90rpQ3cnuvo= Received: (qmail 59979 invoked by alias); 8 Nov 2019 13:49:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 59970 invoked by uid 89); 8 Nov 2019 13:49:58 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f195.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:cc:references:from:openpgp:autocrypt:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4JvSAlfySQW38qv3UBtGojFAf3JdcWnS8E00pzljYiA=; b=PWvhrI+rvk6PMROhvT7n0v5uVh6XRUwcf5rkS/M8XeS7HEcJmoGRra6zAtXr0iKaOt CwBF6zVyxYkEt5srXo+B5neMRpCxQaQvM6vedkUJ+9uEc2FAUwZvLEjBk+vTWhApstdm pz/ZokgYKvN8tDIWXeDzvA1Lg1jOimjEUDyn2a/HC0yCsIhweKeQm4J+swWEDqr+O6xF eAoRmUdNPLrxo8XN/uvIU8n88OABYMx1wvTslFUrQPNcM6KuczfwDSAke0tSkEXE13tG d31y2iQiffys4h6sZtaUKv7SBp8kgDGM48k0/wFWy9GbxB866FS9a2ckQXqPFLUiq/dM S1+w== To: Alistair Francis Cc: GNU C Library References: <20191107181142.1048-1-alistair.francis@wdc.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Subject: Re: [PATCH v5] sysdeps/clock_nanosleep: Use clock_nanosleep_time64 if avaliable Message-ID: <474360dc-f275-ba83-70fe-7f55181c6096@linaro.org> Date: Fri, 8 Nov 2019 10:49:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 07/11/2019 16:23, Alistair Francis wrote: > On Thu, Nov 7, 2019 at 11:15 AM Adhemerval Zanella > wrote: >> >> >> >> On 07/11/2019 15:11, Alistair Francis wrote: >>> +# endif /* __NR_clock_nanosleep_time64 */ >>> + struct timespec ts32, tr32; >>> + >>> + if (! in_time_t_range (req->tv_sec)) >>> + { >>> + __set_errno (EOVERFLOW); >>> + return -1; >>> + } >>> + >>> + ts32 = valid_timespec64_to_timespec (*req); >>> + r = INTERNAL_SYSCALL_CANCEL (clock_nanosleep, err, clock_id, flags, >>> + &ts32, &tr32); >>> + >>> + if ((r == 0 || errno != ENOSYS) && rem) >>> + *rem = valid_timespec_to_timespec64 (tr32); >> >> I think we can assume __NR_nanosleep here. > > I'm not sure what you mean I mean that it does not require to check for ENOSYS. > >> >>> +#endif /* __ASSUME_TIME64_SYSCALLS */ >>> + >>> return (INTERNAL_SYSCALL_ERROR_P (r, err) >>> - ? INTERNAL_SYSCALL_ERRNO (r, err) : 0); >>> + ? INTERNAL_SYSCALL_ERRNO (r, err) : 0); >>> } >> >> This is just replacing a tab with spaces, I don't think it is really required. > > It's the only tab in the file. I was cleaning up the indentation while > touching everything else. I can drop it though. Afaik glibc code conventions uses tabs for C file indentation (except for some imported files).