From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B8B221F5AE for ; Sat, 17 Jul 2021 22:00:05 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 097B8383803D for ; Sat, 17 Jul 2021 22:00:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 097B8383803D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626559202; bh=LSAorspendA/xTftb4Q8QRuUnXwJzletwOAiDJhvs6E=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SVOK5Iho2dqDgqevTmxeLz2yvrtSlelDzKQx4Ma7XXg/mufUDlMO8TNcOF+9wLOyy BiS+3Nb6zKXckfktiGxKGGbcOzbPHF4fIj+iuOBDuHJudqn3ORx2dfSGzh9eAxglUb q+1/bZGfPSzdbFM7THRZCyYKdVRlgKw0bd85em/c= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 041403855026 for ; Sat, 17 Jul 2021 21:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 041403855026 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-YXF-d4n-PMSkcv1hU4l0Ng-1; Sat, 17 Jul 2021 17:59:38 -0400 X-MC-Unique: YXF-d4n-PMSkcv1hU4l0Ng-1 Received: by mail-qk1-f199.google.com with SMTP id a6-20020a37b1060000b02903b488f9d348so9971813qkf.20 for ; Sat, 17 Jul 2021 14:59:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LSAorspendA/xTftb4Q8QRuUnXwJzletwOAiDJhvs6E=; b=S3QEXFCOkGyj6A9X581XPhiggTSU5fib2orQG14XhkZo5nBcpgzIvhExCcLj8UYXUV eYtFxd+njPHURfLmOqRrYQE9JU/lCF4MIduz4qE83VBWHQHABiKeLoTh65xGXGkS10Lc P24IhF/83tRU+eHghqOatOdESZB+Rf1Ng0xkpwdMMLuvhJQ3tDq3fMpF756OyCS/KyGF NMBXumdigT5+2AiuYlfQPHW4EQG9SYmuy3S4dEBFL89cUAjDfB9cgqO8b8eU39+C4HxP Xh+uXZ3m8JNkzZPZSZA10Rj6gfjhtn0bUUaVMsXHag5qqwXVz15B2Tu3wonlHL31KbGL ngsA== X-Gm-Message-State: AOAM5325r0JhUD5M2ebUGok9Tb0olLG7zpDFh87Bg+Lc+W2+0EPIgptK 2PfRKdrtpx09F81SwRePk9sWwByMxVpUQKbnvrONizEvDjkiBiy07HXeO0nJ3A3bODMlMt6gAkv nmW+zW3m2X3pxCR+XnelB X-Received: by 2002:ae9:ddc4:: with SMTP id r187mr17665694qkf.198.1626559178468; Sat, 17 Jul 2021 14:59:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXhMDpj2QQRDgzOJqe8k1bFxk3OUU+KTZEh43EJvLYR8vQIaXxIwNVNTGoa1KrIlkAxDGtig== X-Received: by 2002:ae9:ddc4:: with SMTP id r187mr17665684qkf.198.1626559178240; Sat, 17 Jul 2021 14:59:38 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id k186sm5880551qkb.29.2021.07.17.14.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jul 2021 14:59:37 -0700 (PDT) Subject: Re: [PATCH v5] Define PTHREAD_STACK_MIN to sysconf(_SC_THREAD_STACK_MIN) To: Khem Raj , Florian Weimer References: <20210709210918.4246-1-hjl.tools@gmail.com> <58AE31E3-6592-4E3F-8554-72836C599605@linaro.org> <87zgur71mk.fsf@oldenburg.str.redhat.com> Organization: Red Hat Message-ID: <44575068-77d9-2a36-ac9d-f039aa59964b@redhat.com> Date: Sat, 17 Jul 2021 17:59:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: Maxim Kuvyrkov via Libc-alpha , Maxim Kuvyrkov Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/16/21 6:17 PM, Khem Raj via Libc-alpha wrote: > On Mon, Jul 12, 2021 at 12:51 PM Florian Weimer via Libc-alpha > wrote: >> >> * Maxim Kuvyrkov via Libc-alpha: >> >>> Hi H.J., >>> >>> This breaks GCC’s libgomp build on at least aarch64-linux-gnu: >>> >>> /builds/destdir/x86_64-pc-linux-gnu/aarch64-linux-gnu/bin/ld: .libs/env.o: in function `initialize_env': >>> /snapshots/gcc.git~master/libgomp/env.c:1536: undefined reference to `sysconf' >>> /snapshots/gcc.git~master/libgomp/env.c:1538: undefined reference to `sysconf' >>> /snapshots/gcc.git~master/libgomp/env.c:1539: undefined reference to `sysconf' >>> /builds/destdir/x86_64-pc-linux-gnu/aarch64-linux-gnu/bin/ld: .libs/proc.o: in function `gomp_init_num_threads': >>> /snapshots/gcc.git~master/libgomp/config/linux/proc.c:85: undefined reference to `sysconf' >>> /snapshots/gcc.git~master/libgomp/config/linux/proc.c:143: undefined reference to `sysconf' >>> /snapshots/gcc.git~master/libgomp/config/linux/proc.c:174: more undefined references to `sysconf' follow >>> collect2: error: ld returned 1 exit status >>> make[4]: *** [Makefile:728: libgomp.la] Error 1 >>> >>> Both GCC and Glibc are tip of trunk. >>> >>> Would you please take a look? Please let me know if it doesn’t easily >>> reproduce and I’ll take a look. >> >> I pushed a patch today that should fix this on the glibc side: >> >> Reduce pollution due to dynamic PTHREAD_STACK_MIN >> >> >> It contains some magic that happens to fix GCC for now. Jakub is >> working on a patch that fixes the libgomp issue as well (the standard >> header #include within the hidden-visibility area is invalid): >> >> >> > > I am seeing few packages failing since they use PTHREAD_STACK_MIN as constant > see https://errors.yoctoproject.org/Errors/Build/124520/ Thanks for those reports, we'll need to keep an eye on these, but they will all need to be fixed for non-constant pthread stack size. Finding and fixing these issues will allow Intel and Arm to move forward with dynamic stack sizes for new hardware features. -- Cheers, Carlos.