From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AA1631F453 for ; Wed, 23 Jan 2019 21:47:11 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=Qm/KNj0z9ymQEOjY fjT900641anscXdw/5QkSuBPkkSeE3soCGRhUrmYZA0ey+Tlf3UuZI+fRFQY7Mnv nn9ji5xl/Q68w5s06SyxdbAtbfEJu3Rw9WlqUk7xQpc5Y7GOCGT8Io/4FGjt2BGA 4Cv0eivj3AIGXUnaFWY9IEZYYXw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-type :content-transfer-encoding; s=default; bh=Ci6/hWTR6K7/09js+DfYyL NXDus=; b=eSvh73ndDUqhCWnoJvfxSBh/enR8MebKDCnhjHlhc4oISaGpXW8UA1 3u2LCtuZtWs1btQN2XGysTseKS0Iin70M7Td/2rU4Rb6wPvHGx/c3Z1LmK3HwPR+ ijHfjfYVZHNY7VbyNrNyZIfP2z39f+3G+Wj/ExQF52svNEkbFyEkQ= Received: (qmail 128577 invoked by alias); 23 Jan 2019 21:47:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128566 invoked by uid 89); 23 Jan 2019 21:47:08 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: shared-ano163.rev.nazwa.pl Date: Wed, 23 Jan 2019 22:42:54 +0100 (CET) From: Rafal Luzynski To: TAMUKI Shoichi , libc-alpha@sourceware.org Cc: Zack Weinberg Message-ID: <438843480.258447.1548279775101@poczta.nazwa.pl> In-Reply-To: <201901220153.AA04208@tamuki.linet.gr.jp> References: <201901220144.AA04206@tamuki.linet.gr.jp> <201901220153.AA04208@tamuki.linet.gr.jp> Subject: Re: [PATCH v9 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096] MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit 22.01.2019 02:53 TAMUKI Shoichi wrote: > > The full representation of the alternative calendar year (%EY) > typically includes an internal use of "%Ey". As a GNU extension, > apply any flags on "%EY" (e.g. "%_EY", "%-EY") to the internal "%Ey", > allowing users of "%EY" to control how the year is padded. > > ChangeLog: > > [BZ #24096] > * manual/time.texi (strftime): Document "%EC" and "%EY". > * time/Makefile (tests): Add tst-strftime2. > (LOCALES): Add ja_JP.UTF-8, lo_LA.UTF-8, and th_TH.UTF-8. > * time/strftime_l.c (__strftime_internal): Add argument yr_spec to > override padding for "%Ey". > If an optional flag ('_' or '-') is specified to "%EY", interpret the > "%Ey" in the subformat as if decorated with that flag. > * time/tst-strftime2.c: New file. > --- > NEWS | 4 ++ > manual/time.texi | 11 +++++ > time/Makefile | 5 +- > time/strftime_l.c | 18 ++++--- > time/tst-strftime2.c | 132 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 161 insertions(+), 9 deletions(-) > create mode 100644 time/tst-strftime2.c The code in this patch is OK for me. Reviewed-by: Rafal Luzynski Zack, can you please verify for the last time that the patch [1] is correct and give your final OK and "Reviewed-by"? Thank you. Regards, Rafal [1] https://sourceware.org/ml/libc-alpha/2019-01/msg00553.html