unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] New configure option --disable-crypt.
Date: Thu, 28 Jun 2018 20:23:18 +0200	[thread overview]
Message-ID: <4374f7e7-107b-f359-0517-a13480a0da98@redhat.com> (raw)
In-Reply-To: <20180628173335.GA16038@altlinux.org>

On 06/28/2018 07:33 PM, Dmitry V. Levin wrote:
> On Mon, Jun 25, 2018 at 03:44:03PM +0200, Florian Weimer wrote:
> [...]
>> +@item --disable-crypt
>> +Do not install the passphrase-hashing library @file{libcrypt} or the
>> +header file @file{crypt.h}.  @file{unistd.h} will still declare the
>> +function @code{crypt}, as required by POSIX@.  Using this option does
>> +not change the set of programs that may need to be linked with
>> +@option{-lcrypt}; it only means that @theglibc{} will not provide that
>> +library.
> 
> Given that the first commit of the series moves the declaration of crypt()
> from __USE_XOPEN to __USE_MISC, this reference to POSIX becomes less obvious.

Well spotted.  What about this?

@item --disable-crypt
Do not install the passphrase-hashing library @file{libcrypt} or the
header file @file{crypt.h}.  @file{unistd.h} will still declare the
function @code{crypt}.  Using this option does not change the set of
programs that may need to be linked with @option{-lcrypt}; it only
means that @theglibc{} will not provide that library.

What do you think about the other patches in the series?

https://sourceware.org/ml/libc-alpha/2018-06/msg00723.html
https://sourceware.org/ml/libc-alpha/2018-06/msg00724.html
https://sourceware.org/ml/libc-alpha/2018-06/msg00725.html

Do you consider them ready to commit?

Thanks,
Florian

  reply	other threads:[~2018-06-28 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 13:44 [PATCH] New configure option --disable-crypt Florian Weimer
2018-06-25 13:47 ` Florian Weimer
2018-06-25 14:20 ` Dmitry V. Levin
2018-06-25 14:28   ` Florian Weimer
2018-06-28 17:33 ` Dmitry V. Levin
2018-06-28 18:23   ` Florian Weimer [this message]
2018-06-28 21:20     ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4374f7e7-107b-f359-0517-a13480a0da98@redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).