From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 25F881F8C6 for ; Fri, 9 Jul 2021 01:46:38 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F96F3AAA0E0 for ; Fri, 9 Jul 2021 01:46:37 +0000 (GMT) Received: from fossa.birch.relay.mailchannels.net (fossa.birch.relay.mailchannels.net [23.83.209.62]) by sourceware.org (Postfix) with ESMTPS id 2E8273982C83 for ; Fri, 9 Jul 2021 01:46:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E8273982C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CDE38341F24; Fri, 9 Jul 2021 01:46:23 +0000 (UTC) Received: from pdx1-sub0-mail-a73.g.dreamhost.com (100-96-133-125.trex.outbound.svc.cluster.local [100.96.133.125]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5959F341E5C; Fri, 9 Jul 2021 01:46:23 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a73.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.133.125 (trex/6.3.3); Fri, 09 Jul 2021 01:46:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Dime-Industry: 291ddc813b25e00f_1625795183613_2281587617 X-MC-Loop-Signature: 1625795183613:1051572695 X-MC-Ingress-Time: 1625795183613 Received: from pdx1-sub0-mail-a73.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a73.g.dreamhost.com (Postfix) with ESMTP id 1DEA38A6AB; Thu, 8 Jul 2021 18:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=avC3zD qG7Y5Ys5pTguvV9fvxR+8=; b=Kp3rKp1EjJAN7aBlhSZ/p9enGTvCTJe2NTeWYe DPcocZB/W62jmslVaNG9ZEMeY1gf1RXk2rat5LgY/ThMUtQ4aRn7WCtd+Us9KAKW CIldFRoiesZxHMPA/XuckiAMpAcb8Jx2Olw/JVRbFoh7HzcG0yU68WahHtl5fCHp 2eeCE= Received: from [192.168.1.137] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a73.g.dreamhost.com (Postfix) with ESMTPSA id 905678A6AA; Thu, 8 Jul 2021 18:46:20 -0700 (PDT) Subject: Re: [PATCH v3 02/10] Add mcheck tests to malloc To: "H.J. Lu" References: <20210702023546.3081774-1-siddhesh@sourceware.org> <20210702023546.3081774-3-siddhesh@sourceware.org> <0270d99b-3a15-09d2-7fa9-c9ecf2591d8f@gotplt.org> X-DH-BACKEND: pdx1-sub0-mail-a73 From: Siddhesh Poyarekar Message-ID: <433e43a7-e06a-cd08-ee80-7cb84d9ed7e8@gotplt.org> Date: Fri, 9 Jul 2021 07:16:16 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Liebler , GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/9/21 5:36 AM, H.J. Lu wrote: >> It also caused: >> >> https://sourceware.org/bugzilla/show_bug.cgi?id=28068 >> >> on x32. > > mcheck.c doesn't take MALLOC_ALIGNMENT into account. Will it be removed > or fixed? Very interesting, I think it's best to exclude the test for mcheck on x32 for now. I'll fix mcheck once the malloc hooks patchset[1] is in. On a separate note, this test probably deserves to be run on all architectures for MALLOC_ALIGNMENT. Siddhesh