From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B623B1F8C6 for ; Sun, 8 Aug 2021 08:26:59 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B33DC3857C5E for ; Sun, 8 Aug 2021 08:26:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B33DC3857C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628411218; bh=UY3UnF8swrE9a2YQJ/iktfOEYttWRMxMnEZWZ6UOTvU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=n4hmvOL6Aq/KQruTQnBrzpimvX7p3Uz9aHkEfbvzChiNRLePCAPT5UJsjUJy+9f9h 21gjcOZXgJhLaMLxXPgLcEpsBXif3mQYUwtiNiDmTdC5dSLg7Eo32D9ayttZojrT+M /IE8scJtPnFw+l26zsGOvBu7X0Bkfo978u4nVhqQ= Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 112FC3857C5E for ; Sun, 8 Aug 2021 08:26:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 112FC3857C5E Received: by mail-wm1-x336.google.com with SMTP id i10-20020a05600c354ab029025a0f317abfso12122331wmq.3 for ; Sun, 08 Aug 2021 01:26:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UY3UnF8swrE9a2YQJ/iktfOEYttWRMxMnEZWZ6UOTvU=; b=s3c8LdeovZ1ril/6COv9de5OrbTB+FnPC9NqA2srWNlzwRrXF/w/2w1HTP9+kUzJeD BFG/7khWCVvUqjFheMWhVYLzu8s/rT0y/uLf7vf1sfpXGNmYMVN9GWNDWqU7iS10nYTS AHPfRNHM8C5Lt684plid+on48dFF0YQWKg7+j4wsuY0+YnVjZ/q/ttsqB6zf1q8+IhR5 sE1Rivlu/K5OSbqxQW0ixRlBTbINF0r3a+RsOYOebACygMxdO6tKSLcQUZOszouu/ihN eF0Fh4gW9Z8lnS5Ij3ktlfH5YKLbuPLzlojXKpnIWbBgxN+sWQWuoB6JEff7l2so5Ryv Lrmw== X-Gm-Message-State: AOAM5307+6YuU/F+s/Cne2J/VbDYNgupCxFKdYuNVSiDQS9aeFdBD8Vn pq0Y9rVx/Qmc1iL7GT0tsU4= X-Google-Smtp-Source: ABdhPJySqNK9ruVEcqAwSALjZBb80nFzAtjavMcJiJqqbbtnkb37KZiuIHP/0lu5a/hEO3VQtQn9ug== X-Received: by 2002:a05:600c:2298:: with SMTP id 24mr10909721wmf.62.1628411195994; Sun, 08 Aug 2021 01:26:35 -0700 (PDT) Received: from [10.8.0.10] ([195.53.121.100]) by smtp.gmail.com with ESMTPSA id o2sm13892518wmq.30.2021.08.08.01.26.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Aug 2021 01:26:35 -0700 (PDT) Subject: Re: [PATCH v2] ioctl_tty.2: Fix information about header include file To: =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20210730105353.10424-1-pali@kernel.org> <20210730130537.18863-1-pali@kernel.org> Message-ID: <3d927d3c-67a1-bb48-b597-44c87b8f715a@gmail.com> Date: Sun, 8 Aug 2021 10:26:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210730130537.18863-1-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Alejandro Colomar \(man-pages\) via Libc-alpha" Reply-To: "Alejandro Colomar \(man-pages\)" Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , "G. Branden Robinson" , libc-alpha@sourceware.org, Michael Kerrisk , linux-man@vger.kernel.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Pali, On 7/30/21 3:05 PM, Pali Rohár wrote: > Header file termios.h contains incompatible definitions for linux ioctl > calls. Correct definitions are exported by header file linux/termios.h but > this file conflicts with sys/ioctl.h header file (required for ioctl() > call). Therefore include direct asm header file asm/termbits.h which > contains compatible definitions and structures for ioctl calls. No one screamed so far, so I was going to apply this one, but I just noticed a minor formatting issue; see below. Thanks, Alex > > Signed-off-by: Pali Rohár > > --- > Changes in v2: > * Reformat SYNOPSIS for 80 chars per line > --- > man2/ioctl_tty.2 | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2 > index 771a9a470bf0..ecbae4f887c4 100644 > --- a/man2/ioctl_tty.2 > +++ b/man2/ioctl_tty.2 > @@ -11,8 +11,10 @@ ioctl_tty \- ioctls for terminals and serial lines > .SH SYNOPSIS > .nf > .B #include > -.BR "#include " " /* Definition of " CLOCAL ", and" > -.BR " TC*" { FLUSH , ON , OFF "} constants */" > +.BR "#include " " /* Definition of " "struct termios" , > +.BR " struct termios2" ", and" > +.BR " Bnn" ", " BOTHER ", " CBAUD ", " CLOCAL , > +.BR " TC*" { FLUSH , ON , OFF "} and other constants */" > .PP > .BI "int ioctl(int " fd ", int " cmd ", ...);" > .fi > @@ -31,6 +33,19 @@ makes for nonportable programs. > Use the POSIX interface described in > .BR termios (3) > whenever possible. > +.PP > +Please note that > +.B struct termios > +from > +.B #include Instead, just (with no "#include"): .I See man-pages(7): Formatting conventions (general) [...] Filenames (whether pathnames, or references to header files) are always in italics (e.g., ), except in the SYNOPSIS section, where included files are in bold (e.g., #include ). When referring to a standard header file include, specify the header file surrounded by angle brackets, in the usual C way (e.g., ). > +is different and incompatible with > +.B struct termios > +from > +.BR "#include " . ditto > +These ioctl calls require > +.B struct termios > +from > +.BR "#include " . ditto > .SS Get and set terminal attributes > .TP > .B TCGETS > -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/