From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2222A1F463 for ; Thu, 2 Jan 2020 12:08:28 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=D90TnI0ChntBCMw0 FU0ArZXU/kcTYK0zEEIhdhfKo8Xb8DnC25U5f2jCNOUVrVshk8zQGYXH6zNUL4QC okfAHRmdBYXgzkN0Hv9f8n0tjaS49gcIOrQriK0i8G50kKYPeIfHaS4NSUc6IgsP RI5/mAiXQ7o8BZMSemBnrUWOabc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=XAm1J4ts43KBxtfwhcLd0h Fk8E8=; b=xolE30prjevG1oh3ph1FhPiWov8B+5V2qV3A1i8yAFU8UF4uBN0mBb zdG5jzB8VKxCAll0rUrpWeB8iBln97vpPYyNoNwz61LJPhHXW/9lJgIH0P6yhFun 0Q0qUbRPseB+wdIBwjQiCZOe5goCmasXZekKsZMicQQyl7OA4ZCd8= Received: (qmail 22338 invoked by alias); 2 Jan 2020 12:08:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 22241 invoked by uid 89); 2 Jan 2020 12:08:04 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: bonobo.elm.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Robust-Harbor: 63a147f226cfd8a4_1577966880650_208730658 X-MC-Loop-Signature: 1577966880650:3701194956 X-MC-Ingress-Time: 1577966880650 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=XAm1J4 ts43KBxtfwhcLd0hFk8E8=; b=iY/+kauXcFByqT0IQWSeD4XSGr1xP3EjAMnSeB o3frt7451piX659oHaGQ7/T+w8Gl92/ounyJCxjrjxY+cUIvtt8wBGLY/yRfF/op ibv8uWVUQbooA5CNiD86CCUK+ComI4ibNO3p8UQsCBWTaE8YqQYFb82nRnsW50a0 1oVfs= Subject: Re: [PATCH 06/16] linux: Consolidate Linux gettimeofday To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> <20191217214728.2886-6-adhemerval.zanella@linaro.org> X-DH-BACKEND: pdx1-sub0-mail-a59 From: Siddhesh Poyarekar Message-ID: <38187c94-57e7-3184-bbfe-83f5b18e4a29@gotplt.org> Date: Thu, 2 Jan 2020 17:37:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20191217214728.2886-6-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdeguddgfeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufhiugguhhgvshhhucfrohihrghrvghkrghruceoshhiugguhhgvshhhsehgohhtphhlthdrohhrgheqnecukfhppeduvdefrddvhedvrddvtddvrddujedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegludelvddrudeikedruddrleejngdpihhnvghtpeduvdefrddvhedvrddvtddvrddujedvpdhrvghtuhhrnhdqphgrthhhpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqedpmhgrihhlfhhrohhmpehsihguughhvghshhesghhothhplhhtrdhorhhgpdhnrhgtphhtthhopegrughhvghmvghrvhgrlhdriigrnhgvlhhlrgeslhhinhgrrhhordhorhhgnecuvehluhhsthgvrhfuihiivgepfe On 18/12/19 3:17 am, Adhemerval Zanella wrote: > The IFUNC bypass to vDSO is used when USE_IFUNC_GETTIMEOFDAY is set. > Currently aarch64, powerpc*, and x86 defines it. Otherwise the > generic implementation is used, which calls clock_gettime. > > Checked on aarch64-linux-gnu, powerpc64le-linux-gnu, > powerpc64-linux-gnu, powerpc-linux-gnu-power4, x86_64-linux-gnu, > and i686-linux-gnu. > --- > .../unix/sysv/linux/aarch64/gettimeofday.c | 38 +------------ > sysdeps/unix/sysv/linux/gettimeofday.c | 57 +++++++++++++++++++ > .../unix/sysv/linux/powerpc/gettimeofday.c | 35 +----------- > sysdeps/unix/sysv/linux/x86/gettimeofday.c | 33 +---------- > 4 files changed, 63 insertions(+), 100 deletions(-) > create mode 100644 sysdeps/unix/sysv/linux/gettimeofday.c > OK assuming you've fixed Andreas' review comment. Reviewed-by: Siddhesh Poyarekar