From: Stefan Liebler <stli@linux.ibm.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] test-container: Install with $(sorted-subdirs) [BZ #24794]
Date: Thu, 25 Jul 2019 15:23:11 +0200 [thread overview]
Message-ID: <38158ce5-5f79-7f1b-8bd2-0447ffc4c676@linux.ibm.com> (raw)
In-Reply-To: <20190725000323.15612-1-tuliom@linux.ibm.com>
Hi Tulio,
with this patch, testroot.pristine contains the missing getent / makedb
executables and libnss_* libraries.
Now nss/tst-nss-files-hosts-long and all other container tests are passing.
Thanks,
Stefan
On 7/25/19 2:03 AM, Tulio Magno Quites Machado Filho wrote:
> Commit 35e038c1d2ccb3a75395662f9c4f28d85a61444f started to use an
> incomplete list of subdirs based on $(all-subdirs) causing
> testroot.pristine to miss files from nss.
>
> Tested if the list of files in testroot.pristine remains the same.
>
> 2019-07-24 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> [BZ #24794]
> * Makeconfig (all-subdirs): Improved source comments.
> * Makefile (testroot.pristine/install.stamp): Pass
> subdirs='$(sorted-subdirs)' to make install.
> ---
> Makeconfig | 6 +++---
> Makefile | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makeconfig b/Makeconfig
> index 0e386fbc19..fd36c58c04 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -1267,9 +1267,9 @@ else
> libsupport = $(common-objpfx)support/libsupport.a
> endif
>
> -# These are the subdirectories containing the library source. The order
> -# is more or less arbitrary. The sorting step will take care of the
> -# dependencies.
> +# This is a partial list of subdirectories containing the library source.
> +# The order is more or less arbitrary. The sorting step will take care of the
> +# dependencies and generate sorted-subdirs dynamically.
> all-subdirs = csu assert ctype locale intl catgets math setjmp signal \
> stdlib stdio-common libio malloc string wcsmbs time dirent \
> grp pwd posix io termios resource misc socket sysvipc gmon \
> diff --git a/Makefile b/Makefile
> index 9fbf705200..ac1125853b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -402,7 +402,7 @@ ifeq ($(run-built-tests),yes)
> done
> endif
> $(MAKE) install DESTDIR=$(objpfx)testroot.pristine \
> - subdirs='$(all-subdirs)'
> + subdirs='$(sorted-subdirs)'
> touch $(objpfx)testroot.pristine/install.stamp
>
> tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))
>
next prev parent reply other threads:[~2019-07-25 13:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:32 [PATCH] test-in-container: Install locales into the test container Florian Weimer
2019-07-09 18:07 ` DJ Delorie
2019-07-09 20:52 ` Florian Weimer
2019-07-09 20:58 ` DJ Delorie
2019-07-09 21:02 ` Florian Weimer
2019-07-09 21:11 ` Partial test suite run builds corrupt test-in-container testroot Carlos O'Donell
2019-07-10 0:36 ` DJ Delorie
2019-07-10 5:50 ` Florian Weimer
2019-07-10 16:33 ` DJ Delorie
2019-07-10 16:35 ` Florian Weimer
2019-07-10 16:38 ` DJ Delorie
2019-07-19 11:52 ` Florian Weimer
2019-07-22 20:45 ` [PATCH] test-container: Install with $(all-subdirs) [BZ #24794] Tulio Magno Quites Machado Filho
2019-07-22 20:56 ` DJ Delorie
2019-07-23 16:29 ` Tulio Magno Quites Machado Filho
2019-07-24 14:48 ` Stefan Liebler
2019-07-24 15:32 ` Tulio Magno Quites Machado Filho
2019-07-24 20:40 ` Carlos O'Donell
2019-07-24 23:50 ` DJ Delorie
2019-07-25 0:03 ` [PATCH] test-container: Install with $(sorted-subdirs) " Tulio Magno Quites Machado Filho
2019-07-25 1:32 ` DJ Delorie
2019-07-25 12:46 ` Szabolcs Nagy
2019-07-25 12:56 ` Carlos O'Donell
2019-07-29 13:36 ` Tulio Magno Quites Machado Filho
2022-01-27 15:25 ` H.J. Lu via Libc-alpha
2019-07-25 13:23 ` Stefan Liebler [this message]
2019-07-09 21:08 ` [PATCH] test-in-container: Install locales into the test container Carlos O'Donell
2019-07-09 23:54 ` DJ Delorie
2019-07-12 4:02 ` Carlos O'Donell
2019-07-12 5:48 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38158ce5-5f79-7f1b-8bd2-0447ffc4c676@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).