From: Stefan Liebler via Libc-alpha <libc-alpha@sourceware.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix namespace violation in stdio.h and sys/stat.h if build with optimization. [BZ #26376]
Date: Thu, 20 Aug 2020 10:56:57 +0200 [thread overview]
Message-ID: <378dd036-262d-20e4-75a1-5c3109c06666@linux.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2008192357140.32578@digraph.polyomino.org.uk>
On 8/20/20 1:57 AM, Joseph Myers wrote:
> On Wed, 12 Aug 2020, Stefan Liebler via Libc-alpha wrote:
>
>> For getc_unlocked, getchar_unlocked, putc_unlocked, putchar_unlocked in stdio.h,
>> those are defined "# ifdef __USE_POSIX" instead of "#ifdef __USE_POSIX199506"
>> for the non-inlining declaration. See also
>> "Bug 20014 - stdio.h namespace for pre-threads POSIX"
>> (https://sourceware.org/bugzilla/show_bug.cgi?id=20014).
>>
>> For mknodat in sys/stat.h, those are defined "# ifdef __USE_ATFILE" instead of
>> the additional guard "# if defined __USE_MISC || defined __USE_XOPEN_EXTENDED".
>
> This patch is OK.
>
Committed the patch and resolved the bugzilla.
Thanks.
Stefan
prev parent reply other threads:[~2020-08-20 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:03 [PATCH] Fix namespace violation in stdio.h and sys/stat.h if build with optimization. [BZ #26376] Stefan Liebler via Libc-alpha
2020-08-19 23:57 ` Joseph Myers
2020-08-20 8:56 ` Stefan Liebler via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=378dd036-262d-20e4-75a1-5c3109c06666@linux.ibm.com \
--to=libc-alpha@sourceware.org \
--cc=joseph@codesourcery.com \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).