From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 00D7C1F880 for ; Thu, 9 Jan 2020 21:14:36 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=g/fg/1vvhzLiOo7m 1MQX6hf1D/uhtzk7qRBPDVEa/EDTF8KmvlOT3hLB9o3cX6N/vm+5S3yNj5po0S0F DUuQ6GfxlgEK2f42bj7MhLJp6+0oGz/ZxpKCab+GryCAP6kxTm22itWAfWTAkInL 5jWzeDcBg7HTelEzL/Y2yTeZBY4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=QIMu5K62xHnKyaAtXiXlrE WcKUE=; b=S6phB48ksosI0yq2zDNAGK3tD9u1AJYhCNsa0F4CTbKU4Gvb7MxT+q omCrYsjGVcSQ0KeP5HYNE0QMMWePkm8oja2JZMIzahIkoK2yqXaMFFSmFB+z2IE3 b9mSjIAwNKqiMqhLGmLEA2qainanQDA7bkpL7eN8jl0CCo2oWw8kc= Received: (qmail 129572 invoked by alias); 9 Jan 2020 21:14:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 129551 invoked by uid 89); 9 Jan 2020 21:14:33 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pkZxNF/DGtYMQW7NFVDXEoC9UINYq8omW+9Gr5Bg1Yw=; b=w4EuzXxPYa0ZaFAbvdtZXqC5m/sJrUDfwhGG5WmwccPVhgV7YanvoUkcCyDro5ijOd xJGBg0THwN9kV7uLaqvaeDRKh8BFTS9Tq8Dff7VhsNfv3Q84ZV+hHrPEZEhiQpwQ2zaw laoZSGEEmuiaSf8piTFQqPpWULvuXxabkNgIwJUdwn0uMCdB2VDccZM1V27bxE2ZZzkF umiEsgC2gbNWa7YQp8fUqmxDMOR2G52q3JZHfqurtYYcgTfBquvLyhEjnS8P5o3b11+k D2xdRkoiIyXhwHrj8EcTTvnnzKQpQTezUpW+tmO90Le3XO5Dmuc6yFeuIuNmzPnBUyBH 15uA== Subject: Re: V2 [PATCH 4/5] i386: Remove _exit.S To: libc-alpha@sourceware.org References: <20200108161535.6141-1-hjl.tools@gmail.com> <20200108161535.6141-5-hjl.tools@gmail.com> From: Adhemerval Zanella Message-ID: <36c957c9-eb02-66bd-fa99-0c5a3e51967e@linaro.org> Date: Thu, 9 Jan 2020 18:14:28 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200108161535.6141-5-hjl.tools@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit LGTM thanks. Reviewed-by: Adhemerval Zanella On 08/01/2020 13:15, H.J. Lu wrote: > The generic implementation is suffice since __NR_exit_group is always > support and i386 does define ABORT_INSTRUCTION. > --- > sysdeps/unix/sysv/linux/i386/_exit.S | 44 ---------------------------- > 1 file changed, 44 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/i386/_exit.S > > diff --git a/sysdeps/unix/sysv/linux/i386/_exit.S b/sysdeps/unix/sysv/linux/i386/_exit.S > deleted file mode 100644 > index 1f7bfeb7e7..0000000000 > --- a/sysdeps/unix/sysv/linux/i386/_exit.S > +++ /dev/null > @@ -1,44 +0,0 @@ > -/* Copyright (C) 2002-2020 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -#include > - > - .text > - .type _exit,@function > - .global _exit > -_exit: > - movl 4(%esp), %ebx > - > - /* Try the new syscall first. */ > -#ifdef __NR_exit_group > - movl $__NR_exit_group, %eax > - ENTER_KERNEL > -#endif > - > - /* Not available. Now the old one. */ > - movl $__NR_exit, %eax > - /* Don't bother using ENTER_KERNEL here. If the exit_group > - syscall is not available AT_SYSINFO isn't either. */ > - int $0x80 > - > - /* This must not fail. Be sure we don't return. */ > - hlt > - .size _exit,.-_exit > - > -libc_hidden_def (_exit) > -rtld_hidden_def (_exit) > -weak_alias (_exit, _Exit) >