From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos O'Donell Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: [PATCH 0/2] nptl: Update struct pthread_unwind_buf Date: Thu, 8 Mar 2018 16:47:08 -0800 Message-ID: <304b73fa-bda0-f0a9-e252-e5a062d1182f@redhat.com> References: <20180201205757.51911-1-hjl.tools@gmail.com> <877er1b4zp.fsf@mid.deneb.enyo.de> <87371pb3ga.fsf@mid.deneb.enyo.de> <87tvu59o21.fsf@mid.deneb.enyo.de> <87po4t9mxt.fsf@mid.deneb.enyo.de> <3764b0a1-9f26-6f5f-1bc5-d374f2672f3a@redhat.com> <86d5d5ba-2b53-1904-dada-3efe2b3ad501@redhat.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1520556320 12119 195.159.176.226 (9 Mar 2018 00:45:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Mar 2018 00:45:20 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: Florian Weimer , GNU C Library To: "H.J. Lu" , "Tsimbalist, Igor V" Original-X-From: libc-alpha-return-90914-glibc-alpha=m.gmane.org@sourceware.org Fri Mar 09 01:45:15 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=Ih+9WDvKT3+wgTME 3RWFLul4xvuGCy3su5xuUTIehdcccfAfgg09dJUyjDAtweRPnnpzWlFUxcUCRUJF 6k+z1HpexsJkk8i/ED7iohmcOGjBLxOtPi91yzeW1cpQTCofu/kzG/Nw9ZPwypdC 3oIjD78RZewSfm4ZFCQyoN2MnGk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=11vDfiiA8oZ0XNlW4095lZ FPiSU=; b=MkjHX08aJPGw4ckRpo/EelIjpJ1WPHa3zwpNvcXCbXdw1+vupN4i/Y 4v47Z1etj/sc792ocTJex7gPVJCfE/U5FyV2iGA/bfWnLDoHGuQ84QCkwGtv02D6 PyylIExtutAE7xvudwi9k8yp6sGYQOFdU6vamuhGdzqfSNRwtLEFU= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mail-qt0-f182.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8vLWuobJv5qKjbBmBj4fzEYgGowzX9gLtcSFHSaHfFQ=; b=IXQB5JMPO3JfKOlUf/ROs4krxSbcHfIDgQ91IS0oEbHpcF0lRjM0BbSo8Ca5KIvrbk CNMdbVQ1j+X+KF994cRTZh0crv/zrjYagATBF+DoQ7ISKC3QHGpAfB5rW9/jxARjf90J EZp/wkqUu2JsIIsJxn8fRuyhieauEH+TNq9jivvCIEHnG8HeCTvizErzn8KZ5ecsk+Xe VjB5SYcScCnjGe04CiCWlYLYdHQ5hAAuGpytVpCrvR3bMx9pw5hnwmtcqR2//Jr8YQEY t4gJcPZylHL3Q9fsLufJQOntQtVhC6NDrAUWm84wSo3OeH61TVXaQyENOHSaMQIqEOhw jhhA== X-Gm-Message-State: AElRT7FoFllprvS1XicY833JGxfES9FSxWz4sHGGnkayVmnPCUZQRzqk vT7Otsu4tnda83x+piF2YmSEPcO8p7M= X-Google-Smtp-Source: AG47ELu8m5M6H9aIuv6Hwoiw/SD3iXi73nusokwEukFtupmM9Ll337JBidcu/84j8zbkg1JgUEnnJg== X-Received: by 10.200.37.74 with SMTP id 10mr43452597qtn.270.1520556432090; Thu, 08 Mar 2018 16:47:12 -0800 (PST) In-Reply-To: Xref: news.gmane.org gmane.comp.lib.glibc.alpha:83257 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu69q-0002zz-1c for glibc-alpha@blaine.gmane.org; Fri, 09 Mar 2018 01:45:14 +0100 Received: (qmail 92436 invoked by alias); 9 Mar 2018 00:47:16 -0000 Received: (qmail 92359 invoked by uid 89); 9 Mar 2018 00:47:15 -0000 On 03/08/2018 04:48 AM, H.J. Lu wrote: > True. This is the patch I have tested: > > https://github.com/hjl-tools/gcc/commit/e98087865405f051e93d5f35588789ef9686db4a I assume NOTRACK prefix is what Intel calls 'NO_TRACK_EN' in the CET documentation since binutils uses the 0x3E prefix for it and that matches the Intel CET docs. Please correct me if I'm wrong. In which case I agree, using NOTRACK is going to prevent a useful use of CET against writes to the cancellation jump buffer. This patch looks good to me, but is not a *correctness* issue, it is simply that we want to extend coverage to the private cancellation setjmp/longjmp buffers. Is there any way we can do this with source markup instead of via a fragile list in the compiler? Presumably users may want to markup their own code like this also if they have custom implementations of functions that behave like setjmp/longjmp? -- Cheers, Carlos.