From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EA69720248 for ; Tue, 12 Mar 2019 00:12:53 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=wCQcFMYt1OJmmO48 zxiFvqoYwkdY9iJaMELptbIS+1Mwzy+vqNw88H0eMULdeo9W6ewnVZwL0vdUr5+Z PXvNfb1jgUldRC3L46BYiH62ivFoTD948QV9Moo6yChllttHHJScDU22fMzQ1m94 SXYHdGcBjF4TbxRlalbyi4BuaAs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=S6LTcewXaN9nKhn2T7pip2 qAh88=; b=FdOMkNGVSOZh+cY7BgWg62iueKgcLt3qjLCmYEkTAST4Q2D3cjXDDy x2kUD55xkCoG8G2Nh16wIdWiVm/r97mIin++4D6OiqKzPj5OUMv16A+JRjYfCL1n LALo/lqhDMddhmGrlBi3ilA9c7/3WZYCyfKKyEqf96P/zTgyB1buo= Received: (qmail 76859 invoked by alias); 12 Mar 2019 00:12:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 76844 invoked by uid 89); 12 Mar 2019 00:12:51 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: zimbra.cs.ucla.edu Subject: Re: [PATCH v2 2/2] Fix time/mktime.c and time/gmtime.c for gnulib compatibility To: Lukasz Majewski , libc-alpha@sourceware.org Cc: Joseph Myers References: <20190227112042.1794-1-lukma@denx.de> <20190227112042.1794-2-lukma@denx.de> From: Paul Eggert Openpgp: preference=signencrypt Message-ID: <2e686ac1-eac6-e221-4b0a-476d661a96cf@cs.ucla.edu> Date: Mon, 11 Mar 2019 17:12:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190227112042.1794-2-lukma@denx.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2/27/19 3:20 AM, Lukasz Majewski wrote: > -#ifdef weak_alias > weak_alias (__mktime64, __timelocal64) > -#endif This part of the patch won't be needed if my suggestion about removing timelocal64 (from the previous patch) is taken. Otherwise this patch looks OK to me once the earlier patch is settled on.