From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-5.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E01371F8C6 for ; Tue, 14 Sep 2021 01:19:03 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A7B283858424 for ; Tue, 14 Sep 2021 01:19:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7B283858424 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631582342; bh=t+bqzLkOeymWdq+0ZEwcvI2ClV1GrpCexjNaRImK0qo=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VHnroLO3DccQe5l2utSwBPS4UYOREKlPcxxUG032N30LbmxqonQcshvvo+2+SxSl5 us10kAtjQo2NAvy5v3fY2AC9J9KPmtkvWItL8PRufHXqpdOM2XaWsCodQnf/yYMQiB /QYNbvtFhQDaslkvrZJIFdK9SwjW2Hbm6kPOn13Q= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A517B3858402 for ; Tue, 14 Sep 2021 01:18:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A517B3858402 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333-tfd-dwayMMOsCq-A_eY_Fg-1; Mon, 13 Sep 2021 21:18:40 -0400 X-MC-Unique: tfd-dwayMMOsCq-A_eY_Fg-1 Received: by mail-qk1-f199.google.com with SMTP id t18-20020a05620a0b1200b003f8729fdd04so44227770qkg.5 for ; Mon, 13 Sep 2021 18:18:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=t+bqzLkOeymWdq+0ZEwcvI2ClV1GrpCexjNaRImK0qo=; b=aC2z0vKcTQAMUrUlgeaDPIFBD2Bnl7nI8N6rueRFRRN3QZkqrfNmCU/KsHTs6laxWJ qhUZbcToiTjYnoy73un+N+ECAUOOlf0wwjelc75t/V0T9MlJMufTtRmYYVp/CNcq7hM/ TEDzpDoasTjkJMO/+CiR8boOFKz7ZRsqIyQLyDpHyjpwop7xck47QWp23W+fLuaQ2ORp OhJjuLvn70Yvr/16o992HaxVKuHx0L+WHYVvD0BKSqmnlfh9m50GJJNVC6shiwrxISa7 R/GC9/INorOrhzrMfgPSxbQGMvmfNhvDAb1VakLp4xVHeNo68w3TlcYhQES8KjkwiOi+ P4JQ== X-Gm-Message-State: AOAM532kWb07dQEQEs2Ty+P/z8xaHpYpo5GNeVJ737pabq+m3RVZMvbj a979Q9MPIJEN+igrO9XRdoj9L5k0lkp7nEUx/5BcjeXfTFciT8LicTvh99TqHPrdogbOQmDIVR/ CzsXcHEt1TT9u7ppSrQPcvrBxt3GeF4ifuFAallZOmAGcPmVzkUEzhsMG8siV4nxr5Cy3oQ== X-Received: by 2002:a37:aa97:: with SMTP id t145mr2450574qke.145.1631582319327; Mon, 13 Sep 2021 18:18:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0J9UHLplV741wM02QYSKzuLoHmVhXdTBtzG/0COpRwTX7E+AZUjAp0vI4mjTTFakV5poM2Q== X-Received: by 2002:a37:aa97:: with SMTP id t145mr2450551qke.145.1631582318955; Mon, 13 Sep 2021 18:18:38 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id d129sm6534588qkf.136.2021.09.13.18.18.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 18:18:38 -0700 (PDT) Subject: Re: [PATCH 5/5] x86_64: Add evex optimized bcmp implementation in bcmp-evex.S To: Noah Goldstein , libc-alpha@sourceware.org References: <20210913230506.546749-1-goldstein.w.n@gmail.com> <20210913230506.546749-5-goldstein.w.n@gmail.com> Organization: Red Hat Message-ID: <2ca0771e-2d1d-c0dd-ac98-8f6946d7b469@redhat.com> Date: Mon, 13 Sep 2021 21:18:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210913230506.546749-5-goldstein.w.n@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 9/13/21 7:05 PM, Noah Goldstein via Libc-alpha wrote: > No bug. This commit adds new optimized bcmp implementation for evex. > > The primary optimizations are 1) skipping the logic to find the > difference of the first mismatched byte and 2) not updating src/dst > addresses as the non-equals logic does not need to be reused by > different areas. > > The entry alignment has been fixed at 64. In throughput sensitive > functions which bcmp can potentially be frontend loop performance is > important to opimized for. This is impossible/difficult to do/maintain > with only 16 byte fixed alignment. > > test-memcmp, test-bcmp, and test-wmemcmp are all passing. This series fails in the containerized 32-bit x86 CI/CD regression tester. https://patchwork.sourceware.org/project/glibc/patch/20210913230506.546749-5-goldstein.w.n@gmail.com/ -- Cheers, Carlos.