From: Stefan Liebler <stli@linux.ibm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix build warnings in locale/programs/ld-ctype.c
Date: Wed, 26 Jun 2019 12:32:34 +0200 [thread overview]
Message-ID: <2c30f0eb-c377-1b14-bd55-d9b3ae92fbbe@linux.ibm.com> (raw)
In-Reply-To: <87y31pzs78.fsf@oldenburg2.str.redhat.com>
On 6/25/19 3:54 PM, Florian Weimer wrote:
> * Stefan Liebler:
>
>>> To be honest, I'm more concerned about the other calls to get_character
>>> without error checking.
>
>> Where do you see other ones?
>> With my patch applied, I just see the following occurrences of
>> get_character which are now all checking the return value:
>> 1257:get_character (struct token *now, const struct charmap_t *charmap,
>> 1399:if (get_character (now, charmap, repertoire, &seq, &wch))
>> 2291:if (get_character (now, charmap, repertoire, &seq, &wch))
>> 2574:if (get_character (now, charmap, repertoire, &from_seq,
>> 2585:if (get_character (now, charmap, repertoire, &to_seq,
>
> Ah, my bad, you are right. Please commit the original patch.
>
> Thanks,
> Florian
>
Committed.
Thanks
prev parent reply other threads:[~2019-06-26 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 13:17 [PATCH] Fix build warnings in locale/programs/ld-ctype.c Stefan Liebler
2019-06-25 13:23 ` Florian Weimer
2019-06-25 13:33 ` Stefan Liebler
2019-06-25 13:39 ` Florian Weimer
2019-06-25 13:49 ` Stefan Liebler
2019-06-25 13:54 ` Florian Weimer
2019-06-26 10:32 ` Stefan Liebler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c30f0eb-c377-1b14-bd55-d9b3ae92fbbe@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).