From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 389871F454 for ; Sat, 9 Nov 2019 13:22:56 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=KSrEnvdVcaILypiF C5BLh0lN8XclUQBXHxIlnPbMlC13uikALUBGuEJR0/VnQmxNnFAGiySwkSJ4waY1 4NqT497BdX6Jhnu2/uckmdVAeEGIXYX6g6FqgU47QUtLzx+UQaVdKINbZ9hQiK4c N/Flh9g/FA7AaLkaEq85EMVYAKk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=pac/WU97/I5IKB5vA1kZEc aIiwk=; b=opti3dO4Ph2HX6A96Xgp6YXqh1LW9IgcVVux/AUN85tJiHlZXFcpYW l2SnkeJbWq6z1Vulq1GryHHeAOHacVl3GUB5N9sLmjaip7He60YdFum6mox9SNr7 Kj/t9vRr48kPz+lraDPVJKSJYw2Y+JxXfpeSey3GUj5OTJSQ+qQYQ= Received: (qmail 80721 invoked by alias); 9 Nov 2019 13:22:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 80612 invoked by uid 89); 9 Nov 2019 13:22:48 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573305765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SPMiSSEHxoRmdLQqCqZpXJT8enVVgUbdfVekagASq5g=; b=J/pFIAgZWW4zXYHpjgrWWi0gLBYbz/0lBnYvuXCZJRX3UiwVNAuRcDmiIF0dGfc3maZihn wYDQ+6Zn4oesgGdFSGbtFwpUr9am5yrp0cUn0Umvb6+d/aPbezj7KT4bbYw4p4i+cYwr00 opMwMpFG508ggE882f8z4RDz5PaI7xg= Subject: Re: Gerrit update - diff in comment notification emails To: Simon Marchi , libc-alpha , "gdb-patches@sourceware.org" References: <326a619f-852b-5356-1e32-4dc4c6f833c1@polymtl.ca> <1ff70cda-7c39-cc3b-8244-8f9aab0bac26@polymtl.ca> From: Carlos O'Donell Message-ID: <2ab5f2c6-31c8-502b-32ee-41d9d30030e4@redhat.com> Date: Sat, 9 Nov 2019 08:22:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1ff70cda-7c39-cc3b-8244-8f9aab0bac26@polymtl.ca> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/8/19 7:03 PM, Simon Marchi wrote: > On 2019-11-08 12:16 p.m., Simon Marchi wrote: >> Note that while this shows the comments in the context of the diffs, it >> doesn't show the comment you are replying to, if you were commenting in >> reply to another comment. So if we just reply "Done" in the web UI, we >> will only see "Done" in the notification email, which is not very >> enlightening. So please try to use "Quote" instead of "Reply" and quote >> the relevant portion of what you are replying to (just like you would by >> email), so that it appears in the notification email. Great work Simon! Clearly if you're just responding with "Done" without any quote it's like hitting reply to an email without quoting it and saying "Done." There are habits we will all have to learn about Gerrit, like not just hitting "+2" in the top right. Just hit reply and give your +2 so you don't immediately send out email. This kind of quirk is interesting. I thought it was bad and then I realized that the +2 not being staged is a "quick" way to just review dozens of typo patches and get them approved without hitting reply, and +2, and send. So I think there *is* method in what appears to be arbitrary UI elements, but are actually, like vim or emaacs, well tuned interfaces to their partic= ular uses. Thank you again for working through the email formatting issues! I hope we get these accepted upstream :-) >> Simon >> >> [1] https://gnutoolchain-gerrit.osci.io/r/gitweb?p=3Dgerrit.git;a=3Dblob= ;f=3Dresources/com/google/gerrit/pgm/init/generate-comment-diff.py;hb=3Dref= s/heads/stable-3.0-gnu >=20 > I was told that this link was not accessible. It was a permission proble= m > with Gitweb, it should be fixed now. >=20 > Sorry for the trouble. >=20 > Simon >=20 --=20 Cheers, Carlos.