From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Adhemerval Zanella Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: Remove tilegx port Date: Fri, 27 Apr 2018 13:19:37 -0300 Message-ID: <28cbd64b-5008-6f82-7424-e1e579611bd6@linaro.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1524845865 2923 195.159.176.226 (27 Apr 2018 16:17:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Apr 2018 16:17:45 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 To: libc-alpha@sourceware.org Original-X-From: libc-alpha-return-91884-glibc-alpha=m.gmane.org@sourceware.org Fri Apr 27 18:17:40 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=kvkpB8u0mO8PtR8d ClZmbRqdI+NEU4FxVG0Ua/qjB53e/Mr/zch/vkP3YMhvat3rPVccPE0QKDknkCAT IgMzsW8JFkWCpZxYdVVfp7fcFmVBACXh+LU9XeUhvUn1wCguqCqsKg8NAXRhwzAt 8GoSIJYbjzQTGl0T6Yh48CKSt5c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=kZt1zwS+9Q2Wyry72Jw+Fi ED/3o=; b=a5gRelgfdyt6LEBzV5Z2AB9flvvkkCuiU71TogKFllSpw4E1TXcy0n uzZAOIEPVj1tSYyzQnxmYFw6Kz0boEn0uLpda0zj/wlZwCFwhHkkm74ad1KTLSdJ r2u5PfEKvPTgzT3fUqAIx+/vrDArI/AT6cGMKkkhHIwujMbWqlPdY= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dCBOZrwGTY62zNQWY2fYqLr6RsqmJSdZQgWBKlr61rY=; b=UwrI7GJC0/0Cnz90sDEdpNBeO36KvgPpTvHmoqcWZ1gkyN6j4dqP5AupG6cSIs/zvT g529s26VJDIpFUCSk+XJi2+6ovFdSYSFGa940/vq38cV/fZRKUpHTVWiSrW0NUbVd1q4 gqRIZ4/8XM8PjffuxVGE6Bwzvl5sDe9MaLTkX+KfhYTt+R4YruqvZtlC0R6ojEe78c93 NlveEAR6l9MwoQOtBDs6Sdbxy9t6D8jUdB+rjKMJW+0bTB1mDeoimnPnmWDc+nT6LHzJ 0RrDEpefTjkpDTK43kg6RANZnQl3Nzfj2zV6OjLbL1APgyJKqy21uoowViCWL5HgFh2o /y4g== X-Gm-Message-State: ALQs6tAikOIujY5PeM9QudMNUqhGAy8wuwrMcDgbSqOTCrG72LygDpGl xehtk8SZDZGpFq7EpQLRCtlnPyHaJvA= X-Google-Smtp-Source: AB8JxZo7NLWxCawwVkYrHOWX/aW/XUodLCzWobB8VROIv5F7St7q5vt5i8X+I7UxmjV8rcF0MQikKw== X-Received: by 2002:ac8:2403:: with SMTP id c3-v6mr2773329qtc.329.1524845982099; Fri, 27 Apr 2018 09:19:42 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby In-Reply-To: Xref: news.gmane.org gmane.comp.lib.glibc.alpha:84228 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fC644-0000f3-50 for glibc-alpha@blaine.gmane.org; Fri, 27 Apr 2018 18:17:40 +0200 Received: (qmail 23276 invoked by alias); 27 Apr 2018 16:19:47 -0000 Received: (qmail 23266 invoked by uid 89); 27 Apr 2018 16:19:46 -0000 On 27/04/2018 12:36, Joseph Myers wrote: > Since tile support has been removed from the Linux kernel for 4.17, > this patch removes the (unmaintained) port to tilegx from glibc (the > tilepro support having been previously removed). This reflects the > general principle that a glibc port needs upstream support for the > architecture in all the components it build-depends on (so binutils, > GCC and the Linux kernel, for the normal case of a port supporting the > Linux kernel but no other OS), in order to be maintainable. > > Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile > (omitted from the diffs below), there are updates to various comments > referencing tile for which removal of those references seemed > appropriate. The configuration is removed from README and from > build-many-glibcs.py. contrib.texi keeps mention of removed > contributions, but I updated Chris Metcalf's entry to reflect that he > also contributed the non-removed support for the generic Linux kernel > syscall interface. __ASSUME_FADVISE64_64_NO_ALIGN support is removed, > as it was only used by tile. > > 2018-04-27 Joseph Myers > > * sysdeps/tile: Remove. > * sysdeps/unix/sysv/linux/tile: Likewise. > * README (tilegx-*-linux-gnu): Remove from list of supported > configurations. > * manual/contrib.texi (Contributors): Mention Chris Metcalf's > contribution of support for generic Linux kernel syscall > interface. > * scripts/build-many-glibcs.py (Context.add_all_configs): Remove > tilegx configurations. > (Config.install_linux_headers): Do not handle tile. > * sysdeps/unix/sysv/linux/aarch64/ldsodefs.h: Do not mention Tile > in comment. > * sysdeps/unix/sysv/linux/nios2/Makefile: Likewise. > * sysdeps/unix/sysv/linux/posix_fadvise.c: Likewise. > [__ASSUME_FADVISE64_64_NO_ALIGN] (__ALIGNMENT_ARG): Remove > conditional undefine and redefine. > * sysdeps/unix/sysv/linux/posix_fadvise64.c: Do not mention Tile > in comment. > [__ASSUME_FADVISE64_64_NO_ALIGN] (__ALIGNMENT_ARG): Remove > conditional undefine and redefine. LGTM. > > diff --git a/NEWS b/NEWS > index 3d6b2c8..363e918 100644 > --- a/NEWS > +++ b/NEWS > @@ -57,6 +57,8 @@ Deprecated and removed features, and other changes affecting compatibility: > these macros should first include , and then include > if __GNU_LIBRARY__ is defined. > > +* The tilegx*-*-linux-gnu configurations are no longer supported. > + > Changes to build and runtime requirements: > > [Add changes to build and runtime requirements here] Ok. > diff --git a/README b/README > index 2874505..27a9fd4 100644 > --- a/README > +++ b/README > @@ -41,7 +41,6 @@ The GNU C Library supports these configurations for using Linux kernels: > sh[34]-*-linux-gnu > sparc*-*-linux-gnu > sparc64*-*-linux-gnu > - tilegx-*-linux-gnu > > If you are interested in doing a port, please contact the glibc > maintainers; see http://www.gnu.org/software/libc/ for more Ok. > diff --git a/manual/contrib.texi b/manual/contrib.texi > index 0da6dcb..dd28e92 100644 > --- a/manual/contrib.texi > +++ b/manual/contrib.texi > @@ -265,7 +265,8 @@ version 3 (@code{i386-sequent-bsd}). > @item > Chris Metcalf for the port to Linux/Tile > (@code{tilegx-@var{anything}-linux} and > -@code{tilepro-@var{anything}-linux}). > +@code{tilepro-@var{anything}-linux}) and support for the generic Linux > +kernel syscall interface used by several newer ports. > > @item > David Miller for contributing the port to Linux/Sparc > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index f911b20..19411c1 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -376,14 +376,6 @@ class Context(object): > 'arch': 'sparcv9', > 'ccopts': '-m32 -mlong-double-128', > 'cfg': ['--disable-multi-arch']}]) > - self.add_config(arch='tilegx', > - os_name='linux-gnu', > - glibcs=[{}, > - {'variant': '32', 'ccopts': '-m32'}]) > - self.add_config(arch='tilegxbe', > - os_name='linux-gnu', > - glibcs=[{}, > - {'variant': '32', 'ccopts': '-m32'}]) > self.add_config(arch='x86_64', > os_name='linux-gnu', > gcc_cfg=['--with-multilib-list=m64,m32,mx32'], > @@ -1271,7 +1263,6 @@ class Config(object): > 'riscv64': 'riscv', > 'sh': 'sh', > 'sparc': 'sparc', > - 'tile': 'tile', > 'x86_64': 'x86'} > linux_arch = None > for k in arch_map: Ok. > diff --git a/sysdeps/unix/sysv/linux/aarch64/ldsodefs.h b/sysdeps/unix/sysv/linux/aarch64/ldsodefs.h > index 2f2f973..ff88292 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/ldsodefs.h > +++ b/sysdeps/unix/sysv/linux/aarch64/ldsodefs.h > @@ -1,4 +1,5 @@ > -/* Run-time dynamic linker data structures for loaded ELF shared objects. Tile. > +/* Run-time dynamic linker data structures for loaded ELF shared objects. > + AArch64 version. > Copyright (C) 2001-2018 Free Software Foundation, Inc. > This file is part of the GNU C Library. > Ok. > diff --git a/sysdeps/unix/sysv/linux/nios2/Makefile b/sysdeps/unix/sysv/linux/nios2/Makefile > index d0af9ec..20910fa 100644 > --- a/sysdeps/unix/sysv/linux/nios2/Makefile > +++ b/sysdeps/unix/sysv/linux/nios2/Makefile > @@ -3,7 +3,7 @@ gen-as-const-headers += ucontext_i.sym > endif > > ifeq ($(subdir),misc) > -# MIPS/Tile-style cacheflush routine > +# MIPS-style cacheflush routine > sysdep_headers += sys/cachectl.h > sysdep_routines += cacheflush > endif Ok. > diff --git a/sysdeps/unix/sysv/linux/posix_fadvise.c b/sysdeps/unix/sysv/linux/posix_fadvise.c > index 08ccc22..d676a68 100644 > --- a/sysdeps/unix/sysv/linux/posix_fadvise.c > +++ b/sysdeps/unix/sysv/linux/posix_fadvise.c > @@ -31,9 +31,8 @@ > (redefined to __NR_fadvise64_64 in kernel-features.h) that behaves as > __NR_fadvise64_64 (without the aligment argument required for the ABI). > > - Third option will be used by both tile 32-bits and mips o32. Tile > - will set __ASSUME_FADVISE64_64_NO_ALIGN to issue a 6 argument syscall, > - while mips will use a 7 argument one with __NR_fadvise64. > + Third option will be used by mips o32. Mips will use a 7 argument > + syscall with __NR_fadvise64. > > s390 implements fadvice64_64 using a specific struct with arguments > packed inside. This is the only implementation handled in arch-specific > @@ -53,11 +52,6 @@ posix_fadvise (int fd, off_t offset, off_t len, int advise) > SYSCALL_LL (offset), SYSCALL_LL (len)); > # else > > -# ifdef __ASSUME_FADVISE64_64_NO_ALIGN > -# undef __ALIGNMENT_ARG > -# define __ALIGNMENT_ARG > -# endif > - > # ifndef __NR_fadvise64_64 > # define __NR_fadvise64_64 __NR_fadvise64 > # endif Ok. > diff --git a/sysdeps/unix/sysv/linux/posix_fadvise64.c b/sysdeps/unix/sysv/linux/posix_fadvise64.c > index eebf10c..61dfe89 100644 > --- a/sysdeps/unix/sysv/linux/posix_fadvise64.c > +++ b/sysdeps/unix/sysv/linux/posix_fadvise64.c > @@ -26,18 +26,10 @@ libc_hidden_proto (__posix_fadvise64_l64) > just after 'fd' to avoid the requirement of implementing 7-arg syscalls. > ARM also defines __NR_fadvise64_64 as __NR_arm_fadvise64_64. > > - tile requires __ASSUME_ALIGNED_REGISTER_PAIRS but implements the 32-bit > - fadvise64_64 without the padding 0 after fd. > - > s390 implements fadvice64_64 using a specific struct with arguments > packed inside. This is the only implementation handled in arch-specific > code. */ > > -#ifdef __ASSUME_FADVISE64_64_NO_ALIGN > -# undef __ALIGNMENT_ARG > -# define __ALIGNMENT_ARG > -#endif > - > #ifndef __NR_fadvise64_64 > # define __NR_fadvise64_64 __NR_fadvise64 > #endif > Ok.