From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B04DB1F461 for ; Thu, 16 May 2019 18:57:58 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=jUBACCNntYZZtWQB bOz/eXjUiz0n8Y0gayPfckqf4H0nRvTE9DFJLFKXKVgUQtg+S6RsLEsFZAUtGXHF H+8xbuO8JgYAbX3Twb2E6oDhAZSNJoef9/sQ0Q+rRNN9plxG6XvcAYS3fJNrkKo+ gdZiGbQqCMbv5Vi7Rigidrv3xAE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=kZ9ptzorP5dtAwWVfikG50 09qqM=; b=dDkQZlpBXMpjcpVEqxUZl/xb3ivZMDwxRCmbSZdUIeTfPX0o1taY03 onr4tFNI5eo//TNxWtgvz4Cu5/8t+q/mF55QDVqC1pjMcXYlE2JHPI29SOAMXBUv yBXMiqTKupWE9Y6MEreI+VlBNuZ6ZKeportuKq1FXglxySdujFQJc= Received: (qmail 34007 invoked by alias); 16 May 2019 18:57:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 33998 invoked by uid 89); 16 May 2019 18:57:56 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-vs1-f66.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CkmuRAUJfWHzdKFjCz2hS12U88g513ZAc5S28UYTqwQ=; b=FkSFsBEJKKNNvcLYNGNrClUzC0aAvuOzjmc0IT9WWptoK/odpnG5ieGDj2MAjDY7ud 4daGRhYcTqJgQtt1fBXhdXKCuUH1rQ57gTWlwm/hUfgAuVFoVpjoiwfNNe/fZaK6CUFC fRUmmHL11C6djNhjXrrGT4B2n61oM8wmFACA4qgXojK65ECk78SXLonelPaiFjQllgls 7ugfaR3B/jzcnvx3vCUd8jSptQQi2RldMVe3PXZs5i4sIbgrcg+YWTwx789YR3ANOsu/ UTTSeC7hIpOTRsCzLD1LbJ6CpBMwdVorVTPyNIvD2mvXRyQqNL41/Xz8o7YndgKknjAT 0nGg== Subject: Re: [PATCH 2/5] sysvipc: Move __IPC_64 to kernel-features.h To: Andreas Schwab Cc: libc-alpha@sourceware.org References: <20190516151249.19029-1-adhemerval.zanella@linaro.org> <20190516151249.19029-2-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <280924de-4fc5-d917-9bf5-4d159b99d181@linaro.org> Date: Thu, 16 May 2019 15:57:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 16/05/2019 12:38, Andreas Schwab wrote: > On Mai 16 2019, Adhemerval Zanella wrote: > >> diff --git a/sysdeps/unix/sysv/linux/arm/kernel-features.h b/sysdeps/unix/sysv/linux/arm/kernel-features.h >> index 2d2d355844..4f5c621f82 100644 >> --- a/sysdeps/unix/sysv/linux/arm/kernel-features.h >> +++ b/sysdeps/unix/sysv/linux/arm/kernel-features.h >> @@ -17,6 +17,9 @@ >> License along with the GNU C Library. If not, see >> . */ >> >> +#ifndef _KERNEL_FEATURES_H >> +#define _KERNEL_FEATURES_H 1 > > Why do you need to add the guards (and only for some of them)? > > Andreas. > I added as I tried to build against the ABI and saw failures. The main different is different than other __ASSUME flags, __IPC_64 is redefined. And this make compiler throw a lot of redefine error. For ARM specifically: In file included from ../sysdeps/unix/sysv/linux/arm/kernel-features.h:23, from ../sysdeps/unix/sysv/linux/lowlevellock-futex.h:25, from ../sysdeps/nptl/lowlevellock.h:23, from ../nptl/descr.h:29, from ../sysdeps/arm/nptl/tls.h:42, from ../sysdeps/unix/sysv/linux/arm/tls.h:23, from ../sysdeps/unix/sysv/linux/arm/sysdep.h:33, from :2: ../sysdeps/unix/sysv/linux/kernel-features.h:83: error: "__IPC_64" redefined [-Werror] #define __IPC_64 0x0 In file included from ../sysdeps/unix/sysv/linux/sysdep.h:19, from ../sysdeps/unix/sysv/linux/arm/sysdep.h:27, from :2: ../sysdeps/unix/sysv/linux/arm/kernel-features.h:58: note: this is the location of the previous definition #define __IPC_64 0x100 In general I think unguarded headers file are error-prone.