Re: [PATCH 1/3] login/tst-grantpt: Convert to support framework, more error checking

[Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>]

On 13/08/2020 15:31, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
> 
>>> +  xclose (fd);
>>>    ret = grantpt (fd);
>>>    err = errno;
>>>    if (ret != -1 || err != EBADF)
>>>      {
>>> +      support_record_failure ();
>>>        printf ("grantpt(): expected: return = %d, errno = %d\n", -1, EBADF);
>>>        printf ("           got: return = %d, errno = %d\n", ret, err);
>>> -      return 1;
>>>      }
>>> -  return 0;
>>>  }
>>
>> Ok (although maybe use CHECK_VERIFY?).
> 
> Do you mean TEST_VERIFY?  That can't produce a log message.  We
> probably should have something that logs a failure unconditionally.
> 

Yeap, TEST_VERIFY.  The test failure output will have all the required
information anyway (either if return code or errno does not match
expectations).

>>> -  unlink (file);
>>> +  fd = create_temp_file ("tst-grantpt-", NULL);
>>> +  TEST_VERIFY_EXIT (fd >= 0);
>>>  
>>
>> Ok.  As a side note, maybe we should add a xcreate_temp_file.
> 
> I think we should change the semantics of the existing function
> instead.
> 

The posix/tst-spawn3.c uses create_temp_file to fill all possible file-descriptor
to check if posix_spawn file actions does not use extra descriptors.  Afaik it
is a exception, all other tests expect that create_temp_file does not fail.