From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CC3901F4B4 for ; Mon, 12 Oct 2020 07:08:44 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0A2B1386F019; Mon, 12 Oct 2020 07:08:44 +0000 (GMT) Received: from mx1.emlix.com (mx1.emlix.com [136.243.223.33]) by sourceware.org (Postfix) with ESMTPS id 41770386EC25 for ; Mon, 12 Oct 2020 07:08:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 41770386EC25 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=emlix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eb@emlix.com Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id CA6175F9D3 for ; Mon, 12 Oct 2020 09:08:40 +0200 (CEST) From: Rolf Eike Beer To: GNU C Library Subject: Re: [PATCH 1/2] rtld: fix typo in comment Date: Mon, 12 Oct 2020 09:08:36 +0200 Message-ID: <26714339.cpny5S42I3@devpool47> Organization: emlix GmbH In-Reply-To: References: <20200922121300.3503-1-eb@emlix.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2238106.CDxMaFksvO"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --nextPart2238106.CDxMaFksvO Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Rolf Eike Beer To: GNU C Library Subject: Re: [PATCH 1/2] rtld: fix typo in comment Date: Mon, 12 Oct 2020 09:08:36 +0200 Message-ID: <26714339.cpny5S42I3@devpool47> Organization: emlix GmbH In-Reply-To: References: <20200922121300.3503-1-eb@emlix.com> Am Dienstag, 22. September 2020, 14:23:40 CEST schrieb H.J. Lu: > On Tue, Sep 22, 2020 at 5:13 AM Rolf Eike Beer wrote: > > --- > >=20 > > elf/rtld.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/elf/rtld.c b/elf/rtld.c > > index 5b882163fa..99d130cd1c 100644 > > --- a/elf/rtld.c > > +++ b/elf/rtld.c > > @@ -352,7 +352,7 @@ struct rtld_global _rtld_global =3D > >=20 > > }; > > =20 > > /* If we would use strong_alias here the compiler would see a > > =20 > > non-hidden definition. This would undo the effect of the previous > >=20 > > - declaration. So spell out was strong_alias does plus add the > > + declaration. So spell out what strong_alias does plus add the > >=20 > > visibility attribute. */ > > =20 > > extern struct rtld_global _rtld_local > > =20 > > __attribute__ ((alias ("_rtld_global"), visibility ("hidden"))); > >=20 > > -- > > 2.28.0 >=20 > LGTM. Is anyone going to pick it up? Eike =2D-=20 Rolf Eike Beer, emlix GmbH, http://www.emlix.com =46on +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR B 3160 Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Ust-IdNr= =2E: DE 205 198 055 emlix - smart embedded open source --nextPart2238106.CDxMaFksvO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iLMEAAEIAB0WIQQ/Uctzh31xzAxFCLur5FH7Xu2t/AUCX4QA9AAKCRCr5FH7Xu2t /DP/A/44uj/YswVIC4SuJ5/Yz/J6HpKx0dgV6CgCwSCgrZcB3wpltGJnsykP5gPv qNQ+iyp2iVCXB0nbuDqjk+6PK8pXOo/dWELKH5ywLSlKWvyslzCbozQe4I0/58kn tijJ/YOz1ck78ClEUOzGWz2KywHQ2diSW6sm0SQ/ER7w2Aju2A== =Uxlx -----END PGP SIGNATURE----- --nextPart2238106.CDxMaFksvO--