From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id ECA561F4B4 for ; Tue, 13 Oct 2020 14:18:40 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA6763894425; Tue, 13 Oct 2020 14:18:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA6763894425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602598719; bh=zLk7jJuejItHNJxuIiUw8FNQJiV/EPjSvNgFH/rfSf8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gDqM1bNruAuuj8eY56rOr1jivzBWmvHlQ5sjz2Y0oz3OcFhuIc+872jGQ69LCFQxh eUqLfvquXmpYgPLoX5IERl9MCnv9BPEyHrpA737h0MapLmKicdbWGfqJfsvOz489YK wSDwtLx0q7OIBezK2IC8x+rrwj7R2VmJsQFeyHG8= Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by sourceware.org (Postfix) with ESMTPS id 730B83861012 for ; Tue, 13 Oct 2020 14:18:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 730B83861012 Received: by mail-qk1-x743.google.com with SMTP id s7so20921823qkh.11 for ; Tue, 13 Oct 2020 07:18:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to; bh=zLk7jJuejItHNJxuIiUw8FNQJiV/EPjSvNgFH/rfSf8=; b=sYKPeNydynddTpWLNMkyLesHJLgVu4Lj+p6y9lFucLYqZqst/mdjC/mZZw22ECkIKW Ilivcv9TLrChudAR4HF5HTdq3EzEHpd1WnesIA5oYK6TN/xmQq/4TBx4d1WT5Vhigkip okI9Qti7E5ioeu8/m07ZCUvLjHcy+83vUWGnKOvy0ZwREZIsuBstlQK3EELdM9xIWy4x N4+xVFEcprRRS2iQ4xZoLTcyoU0+BPwiqbFt45JXYOCPNjXZ/hvC8ihdWPoALX9cRpLw 3rA5DykJACwdBalN13YaWUXq6M0Sst8nJ8sMyvqCmJJaVpt7let6E/3+y9K1NmEWftKC LrVw== X-Gm-Message-State: AOAM532vtjB//ZDvjB/pwgx+YgBjf94ElkTUBZPySFDjTGXKErq67mm7 rQHMNcGVE5PE4/xoF0L+vRPqsg== X-Google-Smtp-Source: ABdhPJxkHiP601t+kCaPxLhMCWRiTtmAPM/HtYLYRvwqsMB3KIfoqdnOTx87CX0o9U5TJP04i1RklQ== X-Received: by 2002:a37:9581:: with SMTP id x123mr169227qkd.414.1602598716843; Tue, 13 Oct 2020 07:18:36 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id q65sm6269803qkd.18.2020.10.13.07.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2020 07:18:35 -0700 (PDT) Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support To: Lukasz Majewski References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> <20201013155838.0e61252b@jawa> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <250a2b16-f06a-7215-bb8a-445511a4976f@linaro.org> Date: Tue, 13 Oct 2020 11:18:32 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201013155838.0e61252b@jawa> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PEyNg4s7PJygWu5aKUXJvZ3HopHt2yrTK" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PEyNg4s7PJygWu5aKUXJvZ3HopHt2yrTK Content-Type: multipart/mixed; boundary="q56GCHyz7iwbhavA5KRILlLZIjNmKiPdS"; protected-headers="v1" From: Adhemerval Zanella To: Lukasz Majewski Cc: libc-alpha@sourceware.org, Alistair Francis Message-ID: <250a2b16-f06a-7215-bb8a-445511a4976f@linaro.org> Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> <20201013155838.0e61252b@jawa> In-Reply-To: <20201013155838.0e61252b@jawa> --q56GCHyz7iwbhavA5KRILlLZIjNmKiPdS Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 13/10/2020 10:58, Lukasz Majewski wrote: > Hi Adhemerval, >=20 >> On 07/10/2020 09:52, Adhemerval Zanella wrote: >>> >>> >>> On 06/10/2020 06:48, Lukasz Majewski wrote: =20 >>>> Hi Adhemerval, >>>> =20 >>>>> A new struct __stat{64}_t64 type is added with the required >>>>> __timespec64 time definition. Both non-LFS and LFS support were >>>>> done with an extra __NR_statx call plus a conversion to the new >>>>> __stat{64}_t64 type. The statx call is done only for >>>>> architectures with support for 32-bit time_t ABI. >>>>> >>>>> Internally some extra routines to copy from/to struct stat{64} >>>>> to struct __stat{64} used on multiple implementations (stat, >>>>> fstat, lstat, and fstatat) are added on a extra file >>>>> (stat_t64_cp.c). Aslo some extra routines to copy from statx to >>>>> __stat{64} is added on statx_cp.c. >>>>> >>>>> Checked with a build for all affected ABIs. I also checked on >>>>> x86_64, i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and >>>>> s390x. =20 >>>> >>>> When do you plan to pull this patch set to -master? >>>> Those patches have been available for review on the mailing list >>>> for more than two months now. =20 >>> >>> Hi Lukasz, thanks to remind me. I will rebase against master and run >>> some regressions tests against some platforms and push it. >>> =20 >> >> One required change with the rebase is adapt the riscv32 ABI to >> exclude the __{f,l}xstat{at} symbol and replace with proper {f,l}stat >> ones. It is possible because the new ABI was added on current >> development branch, however one minor inconvenient is the toolchain >> need to be rebuild with a updated glibc branch to avoid linking >> failures with libstd++ (which uses __{f,l}xstat{at}). >> >=20 > I'm not sure if this is related, but on my ARMv7 (32 bit) sandbox there= > is an issue with fstat accesses to files. >=20 > When I try to run a program build against newest glibc (installed in > /opt/lib) I do see issues with {f}stat on other libraries (e.g. > /opt/lib/librt.so). To be more specific I do experience the EOVERFLOW > error: >=20 > error while loading shared libraries: librt.so.1: cannot stat shared > object: Error 75 >=20 > The "base" glibc is 2.28 (installed in /lib). The glibc under test is > the newest master installed in /opt/lib. >=20 > I'm now investigating this issue. I am not sure what it might be based on these information, could you provide a strace so we can pinpoint what might the issue? =20 The arm-linux-gnueabihf testing I did was on a aarch64 kernel (4.12.13). Besides the make check without regression, I could run system binaries=20 with ./testrun.sh. I will check on a different kernel/system with a 32-bit kernel. --q56GCHyz7iwbhavA5KRILlLZIjNmKiPdS-- --PEyNg4s7PJygWu5aKUXJvZ3HopHt2yrTK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEUMEGt8/rO2QSpplaqrHsFKeUiO8FAl+FtzgACgkQqrHsFKeU iO8+jBAAtII2BuuEMTl+1GOmSXIeI8QeabO1HuS7jgvGt9MwR6L+bUNldT+v9/VU gXMcblsQowmImMqVFTZ9qRVN0IJDXzRkBYXZNfWwyZ9LkHx6yLWgGU4iAIrhWGLb 78pVjwU9WsNF2azmTjy7vFk+IhkSxXDXILRHRYM/7z4zklP/tde7OQzqKlRXqslp 7CWN5+9SgM9EsKFCYP/rgzLv7oNRU4LUVTaomWxO4TKqjqR7HR6/CIYn1kfNI5xt GTeG+AQ/LsgjyUFYHP5isukU2xtqOl3Q9zc0BDHoo52Bs6r+5/CYTCTxM8Wr+Yg5 SW13IJnECw2PKvRyl8JJOQs3JpeWz20E0lAlSoNFJasT95kp9dJqOrq4zyCjMkxl EzQkvzeXIve9HAw0EB5gbNdVBcnsX/824XIrFpvQh/XK4aM7UqE2E6WGuj62Gyw9 T9hH4o422OFFE73ayCowgnSrcTWTnpU0N80QEH+YYU7Gy3CtisamVl7RLi9v9T86 bya/NQGz0IR+tzJ4WHHnNRXiqACPpfWL0ratka0ljqDNaKBuS3Wzqh2ftebMricC u2Pd+Nuhk5qctWwKH7Xj88iqG87SkhwjulxUyh8eanc859t3EkRx0zwSDpSCYVGd UXmLc8ZyUuHtakcU1MZQCqFBc0UbYDYioKqP4AZQ2e51XKVueaI= =9+0M -----END PGP SIGNATURE----- --PEyNg4s7PJygWu5aKUXJvZ3HopHt2yrTK--