From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C413B1F85E for ; Fri, 13 Jul 2018 13:11:58 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=fP6aGNESkYz5ATfK vhL/c2PErlX6WCU8sMB+E+fvvwWnHDw9nsdDnJzK4KgFV5mNTbMxJzO4SxdEMuHF NQEPREsk1mi898ARzvaS62UE1Lvb8gf886b0JBV8onwrPXJ09SGAPoGCeZoPNTCc PpwBJT2r8H15Ex0/XBxJJcoIhsg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=/TFmpQ912fbUCqs+NG/0iX 6Boh8=; b=f4T/a79RsI8B3LLaE0HUJwJXJ3CYTB4blWd+7mciR/GW0i7sYZFd3X bRoMBn2ASmn2xScpBn6v+Lv6fSCwOf/1oS7L/MqKG/UsGVDs7qJ/I6kzY3tx9/ll jvGjeskIKMklOIoc6pO2oJcNUSR35bY2Gph8y5IVkFVfX7QQovYRM= Received: (qmail 28468 invoked by alias); 13 Jul 2018 13:11:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 28456 invoked by uid 89); 13 Jul 2018 13:11:55 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com Subject: Re: [PATCH v8 7/8] nptl: Add test cases for ISO C11 threads To: Adhemerval Zanella , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-8-git-send-email-adhemerval.zanella@linaro.org> <4a152fab-0950-bc8a-a0a7-85e0e2472da8@redhat.com> <5c33245e-c052-f4c9-716c-ded49f14924d@linaro.org> From: Florian Weimer Message-ID: <24e20d45-8f1a-edca-6b4c-d905a4554cd4@redhat.com> Date: Fri, 13 Jul 2018 15:11:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <5c33245e-c052-f4c9-716c-ded49f14924d@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 07/13/2018 03:10 PM, Adhemerval Zanella wrote: > > > On 13/07/2018 06:31, Florian Weimer wrote: >> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >>> This patch adds to testsuite new test cases to test all new introduced >>> C11 threads functions, types and macros are tested. >> >> Somewhere, there should be a test that the types (thrd_t, once_flag, mtx_t, cnd_t) have identicial size and alignment as the POSIX types, and that TSS_DTOR_ITERATIONS equals PTHREAD_DESTRUCTOR_ITERATIONS. >> >> It should probably be a separate test, to avoid including in the tests. > > Right, I will work on a extra test for this. I've since realized that these asserts are in the implementation, which is a bit questionable, but better than nothing. I guess you can add the assert for TSS_DTOR_ITERATIONS into the implementation itself. Thanks, Florian