From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E2C8A1F8C6 for ; Fri, 9 Jul 2021 13:00:59 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10E74398A498 for ; Fri, 9 Jul 2021 13:00:59 +0000 (GMT) Received: from firebrick.apple.relay.mailchannels.net (firebrick.apple.relay.mailchannels.net [23.83.208.59]) by sourceware.org (Postfix) with ESMTPS id B9C4D384BC11 for ; Fri, 9 Jul 2021 13:00:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B9C4D384BC11 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4119B841247; Fri, 9 Jul 2021 13:00:43 +0000 (UTC) Received: from pdx1-sub0-mail-a31.g.dreamhost.com (100-96-13-112.trex-nlb.outbound.svc.cluster.local [100.96.13.112]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9D64F840AB1; Fri, 9 Jul 2021 13:00:42 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a31.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.13.112 (trex/6.3.3); Fri, 09 Jul 2021 13:00:43 +0000 X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Power-Cellar: 4af42be879d236ed_1625835642929_3607718755 X-MC-Loop-Signature: 1625835642929:631530496 X-MC-Ingress-Time: 1625835642929 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id 5E3F6852E0; Fri, 9 Jul 2021 06:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=JOowFj ykKhjQIrGU26SAE3zo1Sg=; b=hrKr8Wof+ZhlI6WAplO02TfUrYyWA2gFAUJ5Yy TLBjzQ2nS/oGN+e98vL3dw/Tr6VbyNTXpeRIF2ia69py/h6x7Qyrxc7F+1Z7AQ+y 8us6BHoPmraGL2DazOC6E6g3lX1//zIHUUPxVkviJyTFdPvBxsyz5whUKcw1KmpH ytPR4= Received: from [192.168.1.137] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id BAD297E09C; Fri, 9 Jul 2021 06:00:40 -0700 (PDT) Subject: Re: [PATCH v2] Add a generic malloc test for MALLOC_ALIGNMENT To: "H.J. Lu" References: <20210702023546.3081774-1-siddhesh@sourceware.org> <20210702023546.3081774-3-siddhesh@sourceware.org> <0270d99b-3a15-09d2-7fa9-c9ecf2591d8f@gotplt.org> <433e43a7-e06a-cd08-ee80-7cb84d9ed7e8@gotplt.org> <6c506984-acbf-706d-1266-5182de7811e1@gotplt.org> X-DH-BACKEND: pdx1-sub0-mail-a31 From: Siddhesh Poyarekar Message-ID: <24dbe46e-73f2-d35a-065c-e530d5a7d409@gotplt.org> Date: Fri, 9 Jul 2021 18:30:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Liebler , GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/9/21 5:54 PM, H.J. Lu wrote: > On Thu, Jul 8, 2021 at 9:07 PM Siddhesh Poyarekar wrote: >> >>> diff --git a/malloc/Makefile b/malloc/Makefile >>> index 37a9a4efab..b685ed6d61 100644 >>> --- a/malloc/Makefile >>> +++ b/malloc/Makefile >>> @@ -42,6 +42,7 @@ tests := mallocbug tst-malloc tst-valloc tst-calloc tst-obstack \ >>> tst-malloc-stats-cancellation \ >>> tst-tcfree1 tst-tcfree2 tst-tcfree3 \ >>> tst-safe-linking \ >>> + tst-mallocalign1 \ >>> >> >> Please remove the trailing '\'. OK otherwise. >> > > Changes in the v2 patch > > 1. Add a comment in malloc/tst-mallocalign1.c to indicate that it is > used to verify that MALLOC_ALIGNMENT is honored by malloc. > 2. Include in malloc-size.h after SIZE_SZ is > defined since may use SIZE_SZ. > > BTW, I kept the trailing '\' since it is used in all other places in > malloc/Makefile. > > OK for master? I forgot to ask, does it run successfully on i686 and arm? IIRC it too requires 16 byte alignment and hence both i686 and x32 will fail. If they don't succeed then it may make sense to add tests-exclude-mcheck += tst-mallocalign1 for x32 and i686. Siddhesh