From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 35C961F463 for ; Tue, 10 Sep 2019 17:32:30 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=f+cC3Jd36RhkK1nx koEyhwX/AQ99PUIZ13kgktHv4w/YlzqJTEHXybxq8mab6gksU9VimCeEkHXF0G5A tm4lCivNCWBWrTWnssmuCGoHRglVVb9LmStNdItP5juEKOmSKNR+47yWJKKwfM49 iwbvveRTYAZqwBwxiL5mzJJVeso= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=+dsq+mOhkLzLQivDvJxLeJ KA250=; b=EzX2cr/lL0bchrpZH07iGc8z0HNTbcwhr5IsDvfaYsrHBwYQT7EFcL BiHEDnm8cOW/HYNqyP3cKzbNnQd+dQ2FK8Ww61mcBvI+nW6W/h1Fof8UwPjzByRu OxyqmpYQMTZGopk+DgYVZxjruEPPJNn7I75hdAv7ftTbslKuiQA2o= Received: (qmail 78965 invoked by alias); 10 Sep 2019 17:32:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 78953 invoked by uid 89); 10 Sep 2019 17:32:27 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:cc:references:from:openpgp:autocrypt:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z5XeBUXnPzgVpNK3+pgCeHE4yRcZdH/cUtXaI2vUUe8=; b=K7/zTLtzcmorkW8t5ksC3Lmwuwqjq/iZLWIYl+ZUTbFU4NauMF+NzsAsxB1NolT3fz Ir3Gs2UoIukr6S06h3cxlO4PoQ0iMiUUe18misxjYEehIYiTEHz43zbqM0t3D79tSyGD YgXkJR2AVx16Dz+g4fJmE+FcGSaLTWhNou+io/kBh4hpxOarerikROyf/5R+veWtVDXx fkMb++bPbMQphvHE3IlNtDdMCKqe5fW2Gz5HuRbR517A9TZTYG1dinR7u8NPiC1OzTaH 5sQ5dGvnCSh4dEk/ZY7lfn9mfcx54yDXOmfUogG63aiFntQ2othH4Tk9AylHRviG7ZPe Xtww== To: Zack Weinberg , Joseph Myers Cc: GNU C Library , Florian Weimer , Lukasz Majewski , Alistair Francis , Stepan Golosunov , Arnd Bergmann , Samuel Thibault References: <20190828153236.18229-1-zackw@panix.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Subject: Re: [PATCH v2 00/10] Y2038 preparation: use clock_[gs]ettime to implement the other time-getting and -setting functions. Message-ID: <24be5eab-ea18-f840-df92-6752a8dc0d4e@linaro.org> Date: Tue, 10 Sep 2019 14:32:19 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 03/09/2019 11:43, Zack Weinberg wrote: > On Wed, Aug 28, 2019 at 1:15 PM Joseph Myers wrote: >> >> On Wed, 28 Aug 2019, Zack Weinberg wrote: >> >>> - The obsolete functions ftime and stime are no longer available to >>> new binaries. The header is no longer installed. >> >> It might be advisable to see if this affects the build of libsanitizer, >> and alert sanitizer maintainers if so. (There appear to be sanitizer >> interceptors for ftime and stime, and an include of .) > > I may not have time to do anything about this for at least a couple > weeks, but I can confirm that the absence of sys/timeb.h does break > the build of libsanitizer. Adhemerval's suggestion of keeping ftime > and around for at least another release, but issuing > warnings if ftime is actually used (attribute((deprecated)) maybe?) > seems reasonable to me. > > zw > Hi Zack, I just pushed a personal branch [1] based on your y2038-preliminaries with the changes I have proposed in the review: * Change most internal uses of __gettimeofday to __clock_gettime. - Some tab/whitespace issues. - Hurd time_value_t to timespec strict issues. * Use clock_settime to implement settimeofday. - Simplify sysdeps/unix/sysv/linux/settimezone.c * Use clock_gettime to implement time. - Do not remove arch-specific time implementations. - Adjust powerpc time to use the new generic implementation. * Use clock_gettime to implement ftime; withdraw ftime. - Keep the sys/timeb.h header and deprecate ftime. * Use clock_gettime to implement gettimeofday. - Do not remove arch-specific gettimeofday implementations. * Warn when gettimeofday is called with non-null tzp argument. - Remove the __warndecl hack. - Change to "Make second argument of gettimeofday as 'void *'" and adjust the required implementations. I don't like to clash with you proposal, since some changes remove some suggestion from your first patchset. [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/y2038-preliminaries