From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9BA991F62D for ; Fri, 6 Jul 2018 12:46:36 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=aV3anMv8eaeT96RB Fi1uZyLR1M+UJCKicHZhSJ46WHYCQ/4F84TPjvmG4jBO0G8/14dHOGNTYxmS7xVq pTnR8LLdFMye7STtPwKAU/zXd5sADXEV7e9eJD52iSletSUsNgu9RgLb5H7Lc5nC oZb5FqBL6GCTgeM+eOEM/ooMRf4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=nH86zV2wOQgNXEzOaKr0ES 2XlqE=; b=BwYJFHlDbV0NYN1JtqwxPmCjydMZJQYUiNSE3YLgVExld8lxkkdezH qBhlrTLJzaQx/8OFfrBMQDnn6EuTLTCxckEMr0zh3itA3X4P0Bbe9NqGmNQgj9pg uO3Ia3GCq3ru7fLOmob8PSk3kwZm6rjrNWzdc9XgqUjsfnj7Khw0E= Received: (qmail 40436 invoked by alias); 6 Jul 2018 12:46:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 23051 invoked by uid 89); 6 Jul 2018 12:46:17 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Adhemerval Zanella , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> From: Florian Weimer Message-ID: <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> Date: Fri, 6 Jul 2018 14:46:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: > @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \ > pthread_mutex_getprioceiling \ > pthread_mutex_setprioceiling \ > pthread_setname pthread_getname \ > - pthread_setattr_default_np pthread_getattr_default_np > + pthread_setattr_default_np pthread_getattr_default_np \ > + thrd_create thrd_current thrd_detach thrd_equal \ thrd_current should live in libc, not in libpthread. Same for thrd_equal, I suppose. You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet. Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well. Thanks, Florian