From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-5.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4FB691F8C6 for ; Fri, 10 Sep 2021 19:48:14 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B25D3858020 for ; Fri, 10 Sep 2021 19:48:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B25D3858020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631303293; bh=Tl65+9xeIGujDmWxolpjKkG2ZHjJEZdnM7XWMcXvi30=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wKb4LID56u9paOmKItqCZaGz6PpctJ+Gix6ShqsOus/bOigCwF6RMni4vU6vPcdgh 6DOlWkpjlmeJlKZFNJvvxADSI5+7lnYLpZHDizmzsAErXYYuTM4RjnxzlDnnb41aDX yUrV/PVPga9fSfkHg7EH1iY2tu3OX1lG3GA7lx1c= Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id EF4663857420 for ; Fri, 10 Sep 2021 19:47:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF4663857420 Received: by mail-wr1-x436.google.com with SMTP id d6so4155836wrc.11 for ; Fri, 10 Sep 2021 12:47:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Tl65+9xeIGujDmWxolpjKkG2ZHjJEZdnM7XWMcXvi30=; b=iHwKMg1Ml8Gzaui20TiB/f13IxfAjQrhLtZt9PKYjz1+2dzuDBUzN6ztjHwWNa/pxf AmF+OA5LG+6g1sfxSqygn0PN3BxTlMqEObbNLAfTfv0CzQeNdnN18T88Ck+ZTGd+XFYS yLEPI945mntUArQo+BvNDmw5grIv7f/Zcyba/W9O9qiJdScLOa28jQuCB4Yj6GvzzElh T73j5cphRqTMmZrqE6FHE+/YT8YSQoQMJSsZfHA2lDThEWuFb9rXPfr4eSlShwVDSq5/ TAZbW9OXxycSJn9ChUc9A8+diDaXxbF1PwCSh8dLEoeuWX+4P3q3nE9hum5H2LOoJds4 /5Bw== X-Gm-Message-State: AOAM532/S8vJTi+1S4uWHLFhmHaRir0WjQNHO9U3sNLL+h38rT7TkBci xdGQFSXDnV4X3im9duAaV8k= X-Google-Smtp-Source: ABdhPJxIKbz3TczX24XqyOc9Lw7uyn025Cl4c8Bnv1YDUdLYzqaHMTMmOXS14vFfooVFj9lOtmSbnw== X-Received: by 2002:a5d:6dd0:: with SMTP id d16mr11319886wrz.177.1631303263100; Fri, 10 Sep 2021 12:47:43 -0700 (PDT) Received: from [10.168.10.11] ([170.253.36.171]) by smtp.gmail.com with ESMTPSA id l15sm4788934wms.38.2021.09.10.12.47.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Sep 2021 12:47:42 -0700 (PDT) Subject: Re: [PATCH v3] ioctl_tty.2: Fix information about header include file To: =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <3d927d3c-67a1-bb48-b597-44c87b8f715a@gmail.com> <20210831202809.29819-1-pali@kernel.org> <20210910173949.bkyunodbtau2gg6j@pali> Message-ID: <22f92414-8aa2-9102-793b-e9038607d5dc@gmail.com> Date: Fri, 10 Sep 2021 21:47:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910173949.bkyunodbtau2gg6j@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Alejandro Colomar \(man-pages\) via Libc-alpha" Reply-To: "Alejandro Colomar \(man-pages\)" Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , "G. Branden Robinson" , libc-alpha@sourceware.org, Michael Kerrisk , linux-man@vger.kernel.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Pali, On 9/10/21 7:39 PM, Pali Rohár wrote: > On Tuesday 31 August 2021 22:28:09 Pali Rohár wrote: >> Header file termios.h contains incompatible definitions for linux ioctl >> calls. Correct definitions are exported by header file linux/termios.h but >> this file conflicts with sys/ioctl.h header file (required for ioctl() >> call). Therefore include direct asm header file asm/termbits.h which >> contains compatible definitions and structures for ioctl calls. >> >> Signed-off-by: Pali Rohár > > Hello Alejandro! Could you check also this patch? Sure, patch applied! BTW, if at some point you feel like adding entries for termios and termios2 into system_data_types(7), I'll be happy to merge those!! Thank you! Alex > >> --- >> Changes in v3: >> * Use .I instead of .B #include >> * Use Bnnn instead of Bnn >> >> Changes in v2: >> * Reformat SYNOPSIS for 80 chars per line >> --- >> man2/ioctl_tty.2 | 19 +++++++++++++++++-- >> 1 file changed, 17 insertions(+), 2 deletions(-) >> >> diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2 >> index 186011ee7c33..7d866867c6bd 100644 >> --- a/man2/ioctl_tty.2 >> +++ b/man2/ioctl_tty.2 >> @@ -11,8 +11,10 @@ ioctl_tty \- ioctls for terminals and serial lines >> .SH SYNOPSIS >> .nf >> .B #include >> -.BR "#include " " /* Definition of " CLOCAL ", and" >> -.BR " TC*" { FLUSH , ON , OFF "} constants */" >> +.BR "#include " " /* Definition of " "struct termios" , >> +.BR " struct termios2" ", and" >> +.BR " Bnnn" ", " BOTHER ", " CBAUD ", " CLOCAL , >> +.BR " TC*" { FLUSH , ON , OFF "} and other constants */" >> .PP >> .BI "int ioctl(int " fd ", int " cmd ", ...);" >> .fi >> @@ -31,6 +33,19 @@ makes for nonportable programs. >> Use the POSIX interface described in >> .BR termios (3) >> whenever possible. >> +.PP >> +Please note that >> +.B struct termios >> +from >> +.I >> +is different and incompatible with >> +.B struct termios >> +from >> +.IR . >> +These ioctl calls require >> +.B struct termios >> +from >> +.IR . >> .SS Get and set terminal attributes >> .TP >> .B TCGETS >> -- >> 2.20.1 >> -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/