From: Peter Bergner <bergner@linux.ibm.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 02/12] powerpc: Add missing arch flags on rounding ifunc variants
Date: Mon, 1 Apr 2024 11:50:20 -0500 [thread overview]
Message-ID: <22d79923-aa3a-4d75-be5a-9797e6d6bcd8@linux.ibm.com> (raw)
In-Reply-To: <CAMe9rOrX=eL5t+cFoJqMTMb_w6rAsPpyFd_kd9GHg4O_v9hzbg@mail.gmail.com>
On 4/1/24 8:59 AM, H.J. Lu wrote:
> On Thu, Dec 28, 2023 at 9:21 AM Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>>
>> The ifunc variants now uses the powerpc implementation which in turn
>> uses the compiler builtin. Without the proper -mcpu switch the builtin
>> does not generate the expected optimization.
>>
>> Checked on powerpc-linux-gnu.
>> ---
>> sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile
>> index 64317506c6..2f5c0eded6 100644
>> --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile
>> +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile
>> @@ -34,6 +34,12 @@ CFLAGS-s_modff-power5+.c = -mcpu=power5+
>> CFLAGS-s_logbl-power7.c = -mcpu=power7
>> CFLAGS-s_logb-power7.c = -mcpu=power7
>> CFLAGS-s_logbf-power7.c = -mcpu=power7
>> +CFLAGS-s_round-power5+.c += -mcpu=power5+
>> +CFLAGS-s_roundf-power5+.c += -mcpu=power5+
>> +CFLAGS-s_floor-power5+.c += -mcpu=power5+
>> +CFLAGS-s_floorf-power5+.c += -mcpu=power5+
>> +CFLAGS-s_trunc-power5+.c += -mcpu=power5+
>> +CFLAGS-s_truncf-power5+.c += -mcpu=power5+
>>
>> # These files quiet sNaNs in a way that is optimized away without
>> # -fsignaling-nans.
>> --
>> 2.34.1
>>
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
This predated me taking over the Power port, but...
LGTM too.
Reviewed-by: Peter Bergner <bergner@linux.ibm.com>
Peter
next prev parent reply other threads:[~2024-04-01 16:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 17:20 [PATCH 00/12] Improve rounding to interger function for C23 Adhemerval Zanella
2023-12-28 17:20 ` [PATCH 01/12] math: Reformat Makefile Adhemerval Zanella
2024-04-01 13:57 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 02/12] powerpc: Add missing arch flags on rounding ifunc variants Adhemerval Zanella
2024-04-01 13:59 ` H.J. Lu
2024-04-01 16:50 ` Peter Bergner [this message]
2023-12-28 17:20 ` [PATCH 03/12] math: Add test to check if ceil raise inexact floating-point exception Adhemerval Zanella
2024-04-01 14:01 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 04/12] math: Add test to check if floor " Adhemerval Zanella
2024-04-01 14:02 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 05/12] math: Add test to check if trunc " Adhemerval Zanella
2024-04-01 14:03 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 06/12] math: Add test to check if round " Adhemerval Zanella
2024-04-01 14:02 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 07/12] x86: Do not raise inexact exception on ceill Adhemerval Zanella
2024-04-01 14:12 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 08/12] x86: Do not raise inexact exception on floorl Adhemerval Zanella
2024-04-01 14:13 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 09/12] x86: Do not raise inexact exception on truncl Adhemerval Zanella
2024-04-01 14:14 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 10/12] x86: Do not raise inexact exception on floor/floorf Adhemerval Zanella
2024-04-01 14:15 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 11/12] i386: Do not raise inexact exception on ceil/ceilf Adhemerval Zanella
2024-04-01 14:16 ` H.J. Lu
2023-12-28 17:20 ` [PATCH 12/12] i386: Do not raise inexact exception on trunc/truncf Adhemerval Zanella
2024-04-01 14:17 ` H.J. Lu
2024-02-16 17:47 ` [PATCH 00/12] Improve rounding to interger function for C23 Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22d79923-aa3a-4d75-be5a-9797e6d6bcd8@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).