* [PATCH] nptl: update default pthread-offsets.h
@ 2020-02-05 17:54 Andreas Schwab
2020-02-05 18:17 ` Adhemerval Zanella
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2020-02-05 17:54 UTC (permalink / raw
To: libc-alpha
Remove unused definitions, and correct __PTHREAD_RWLOCK_FLAGS_OFFSET for
__WORDSIZE == 64.
---
sysdeps/nptl/pthread-offsets.h | 22 ++++++----------------
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/sysdeps/nptl/pthread-offsets.h b/sysdeps/nptl/pthread-offsets.h
index a399608aa1..3d9c51783d 100644
--- a/sysdeps/nptl/pthread-offsets.h
+++ b/sysdeps/nptl/pthread-offsets.h
@@ -1,26 +1,16 @@
#include <bits/wordsize.h>
/* These values are based on internal generic types from
- mutex-internal.h and rwlock-internal.h. */
+ bits/struct_mutex.h and bits/struct_rwlock.h. */
#if __WORDSIZE == 64
-# define __PTHREAD_MUTEX_NUSERS_OFFSET 12
-# define __PTHREAD_MUTEX_KIND_OFFSET 16
-# define __PTHREAD_MUTEX_SPINS_OFFSET 20
-# define __PTHREAD_MUTEX_LIST_OFFSET 24
+# define __PTHREAD_MUTEX_KIND_OFFSET 16
#else
-# define __PTHREAD_MUTEX_NUSERS_OFFSET 16
-# define __PTHREAD_MUTEX_KIND_OFFSET 12
-# define __PTHREAD_MUTEX_SPINS_OFFSET 20
-# define __PTHREAD_MUTEX_LIST_OFFSET 20
+# define __PTHREAD_MUTEX_KIND_OFFSET 12
#endif
-#if __WORDSIZE == 64
-# define __PTHREAD_RWLOCK_FLAGS_OFFSET 48
+#if __BYTE_ORDER == __BIG_ENDIAN
+# define __PTHREAD_RWLOCK_FLAGS_OFFSET 27
#else
-# if __BYTE_ORDER == __BIG_ENDIAN
-# define __PTHREAD_RWLOCK_FLAGS_OFFSET 27
-# else
-# define __PTHREAD_RWLOCK_FLAGS_OFFSET 24
-# endif
+# define __PTHREAD_RWLOCK_FLAGS_OFFSET 24
#endif
--
2.25.0
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nptl: update default pthread-offsets.h
2020-02-05 17:54 [PATCH] nptl: update default pthread-offsets.h Andreas Schwab
@ 2020-02-05 18:17 ` Adhemerval Zanella
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella @ 2020-02-05 18:17 UTC (permalink / raw
To: libc-alpha
On 05/02/2020 14:54, Andreas Schwab wrote:
> Remove unused definitions, and correct __PTHREAD_RWLOCK_FLAGS_OFFSET for
> __WORDSIZE == 64.
LGTM, thanks for catching it.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/nptl/pthread-offsets.h | 22 ++++++----------------
> 1 file changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/sysdeps/nptl/pthread-offsets.h b/sysdeps/nptl/pthread-offsets.h
> index a399608aa1..3d9c51783d 100644
> --- a/sysdeps/nptl/pthread-offsets.h
> +++ b/sysdeps/nptl/pthread-offsets.h
> @@ -1,26 +1,16 @@
> #include <bits/wordsize.h>
>
> /* These values are based on internal generic types from
> - mutex-internal.h and rwlock-internal.h. */
> + bits/struct_mutex.h and bits/struct_rwlock.h. */
>
> #if __WORDSIZE == 64
> -# define __PTHREAD_MUTEX_NUSERS_OFFSET 12
> -# define __PTHREAD_MUTEX_KIND_OFFSET 16
> -# define __PTHREAD_MUTEX_SPINS_OFFSET 20
> -# define __PTHREAD_MUTEX_LIST_OFFSET 24
> +# define __PTHREAD_MUTEX_KIND_OFFSET 16
> #else
> -# define __PTHREAD_MUTEX_NUSERS_OFFSET 16
> -# define __PTHREAD_MUTEX_KIND_OFFSET 12
> -# define __PTHREAD_MUTEX_SPINS_OFFSET 20
> -# define __PTHREAD_MUTEX_LIST_OFFSET 20
> +# define __PTHREAD_MUTEX_KIND_OFFSET 12
> #endif
>
> -#if __WORDSIZE == 64
> -# define __PTHREAD_RWLOCK_FLAGS_OFFSET 48
> +#if __BYTE_ORDER == __BIG_ENDIAN
> +# define __PTHREAD_RWLOCK_FLAGS_OFFSET 27
> #else
> -# if __BYTE_ORDER == __BIG_ENDIAN
> -# define __PTHREAD_RWLOCK_FLAGS_OFFSET 27
> -# else
> -# define __PTHREAD_RWLOCK_FLAGS_OFFSET 24
> -# endif
> +# define __PTHREAD_RWLOCK_FLAGS_OFFSET 24
> #endif
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-05 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-05 17:54 [PATCH] nptl: update default pthread-offsets.h Andreas Schwab
2020-02-05 18:17 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).