unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 0/1] uk_UA: Add alternative month names (bug 10871).
@ 2018-01-25  0:07 Rafal Luzynski
  2018-01-25  0:10 ` [PATCH 1/1] " Rafal Luzynski
  2018-01-25  0:25 ` [PATCH 0/1] " Dmitry V. Levin
  0 siblings, 2 replies; 6+ messages in thread
From: Rafal Luzynski @ 2018-01-25  0:07 UTC (permalink / raw
  To: libc-alpha

So far I have convinced the Ukrainian team to accept this change.
There is some interest from Belarusian and Russian teams and I hope
they will be next.

I'm going to push these patches later today (January 25) if
there is no objection.  BTW, do I understand correctly that it
is OK to push the locale data updates in this phase of freeze?
I think it has been told that it is OK to push them together with
the translation updates (that's one of the reasons why the freezes
exist).

Regards,

Rafal


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] uk_UA: Add alternative month names (bug 10871).
  2018-01-25  0:07 [PATCH 0/1] uk_UA: Add alternative month names (bug 10871) Rafal Luzynski
@ 2018-01-25  0:10 ` Rafal Luzynski
  2018-01-25 13:05   ` [COMMITTED][PATCH " Rafal Luzynski
  2018-01-25  0:25 ` [PATCH 0/1] " Dmitry V. Levin
  1 sibling, 1 reply; 6+ messages in thread
From: Rafal Luzynski @ 2018-01-25  0:10 UTC (permalink / raw
  To: libc-alpha

Primary month names are in a genitive case now, alternative month names
are in a nominative case.

The alternative digits hack is no longer needed and has been removed.

	[BZ #10871]
	* localedata/locales/uk_UA (mon): Renamed to...
	(alt_mon): This.
	(alt_digits): "0" removed and then renamed to...
	(mon): This.
	(date_fmt): Definition changed not to use the alternative
	digits hack.
---
 localedata/locales/uk_UA | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/localedata/locales/uk_UA b/localedata/locales/uk_UA
index 685ee01..207931b 100644
--- a/localedata/locales/uk_UA
+++ b/localedata/locales/uk_UA
@@ -842,8 +842,8 @@ abmon /
         "<U043B><U0438><U0441>"; %lys  /
         "<U0433><U0440><U0443>"  %hru
 
-% A list of month names in proper form for calendar, see alt_digits. (%B)
-mon /
+% A list of month names in proper form for calendar, see mon. (%OB)
+alt_mon /
         "<U0441><U0456><U0447><U0435><U043D><U044C>";   %sichen`  /
         "<U043B><U044E><U0442><U0438><U0439>";    %lyutyj   /
         "<U0431><U0435><U0440><U0435><U0437><U0435><U043D><U044C>"; %berezen` /
@@ -857,16 +857,8 @@ mon /
         "<U043B><U0438><U0441><U0442><U043E><U043F><U0430><U0434>"; %lystopad /
         "<U0433><U0440><U0443><U0434><U0435><U043D><U044C>"   %hruden`
 
-% Initially alt_digits was supposed to hold alternative symbols for _digits_,
-% corresponding to %O modified conversion specification.
-% Although in Ukrainian language alternate _names_ are used instead of digits.
-% We'll use this keyword to present a list of month names in proper form for
-% date, see mon.  (%Om)
-%
-% This hack is dedicated for months it won't work for other %O* modifiers
-% (weeks, days etc).
-%
-alt_digits "0";	     % digits are starting from zero /
+% A list of month names in genitive form, for full date format, with day. (%B)
+mon /
         "<U0441><U0456><U0447><U043D><U044F>";     % sichnya   /
         "<U043B><U044E><U0442><U043E><U0433><U043E>";    % lyutoho   /
         "<U0431><U0435><U0440><U0435><U0437><U043D><U044F>";   % bereznya  /
@@ -881,7 +873,7 @@ alt_digits "0";	     % digits are starting from zero /
         "<U0433><U0440><U0443><U0434><U043D><U044F>"     % hrudnya
 
 % Appropriate date representation for date(1).
-date_fmt       "%A, %-d %Om %Y %X %z"
+date_fmt       "%A, %-d %B %Y %X %z"
 
 % The appropriate date and time format. (%c)
 d_t_fmt  "%a, %d-%b-%Y %X %z"
-- 
2.7.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/1] uk_UA: Add alternative month names (bug 10871).
  2018-01-25  0:07 [PATCH 0/1] uk_UA: Add alternative month names (bug 10871) Rafal Luzynski
  2018-01-25  0:10 ` [PATCH 1/1] " Rafal Luzynski
@ 2018-01-25  0:25 ` Dmitry V. Levin
  1 sibling, 0 replies; 6+ messages in thread
From: Dmitry V. Levin @ 2018-01-25  0:25 UTC (permalink / raw
  To: libc-alpha

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

On Thu, Jan 25, 2018 at 01:07:28AM +0100, Rafal Luzynski wrote:
> So far I have convinced the Ukrainian team to accept this change.
> There is some interest from Belarusian and Russian teams and I hope
> they will be next.

Great.

> I'm going to push these patches later today (January 25) if
> there is no objection.  BTW, do I understand correctly that it
> is OK to push the locale data updates in this phase of freeze?

I think this particular change is still OK that late.

As some locale data is used in tests (e.g. uk_UA.UTF-8 is listed in
localedata/Makefile:test-input), please ensure that the update
doesn't break them.

> I think it has been told that it is OK to push them together with
> the translation updates (that's one of the reasons why the freezes
> exist).

This is indeed the case with translation updates, but locale data
is a different thing.


-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [COMMITTED][PATCH 1/1] uk_UA: Add alternative month names (bug 10871).
  2018-01-25  0:10 ` [PATCH 1/1] " Rafal Luzynski
@ 2018-01-25 13:05   ` Rafal Luzynski
  2018-01-25 16:22     ` Andreas Schwab
  2018-01-25 23:32     ` Rafal Luzynski
  0 siblings, 2 replies; 6+ messages in thread
From: Rafal Luzynski @ 2018-01-25 13:05 UTC (permalink / raw
  To: libc-alpha

25.01.2018 01:10 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
>
> Primary month names are in a genitive case now, alternative month names
> are in a nominative case.
>
> The alternative digits hack is no longer needed and has been removed.
>
> [BZ #10871]
> * localedata/locales/uk_UA (mon): Renamed to...
> (alt_mon): This.
> (alt_digits): "0" removed and then renamed to...
> (mon): This.
> (date_fmt): Definition changed not to use the alternative
> digits hack.
> ---
> localedata/locales/uk_UA | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
> [...]

This has been committed.  Dmitry: yes, it passes make check.

Regards,

Rafal


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [COMMITTED][PATCH 1/1] uk_UA: Add alternative month names (bug 10871).
  2018-01-25 13:05   ` [COMMITTED][PATCH " Rafal Luzynski
@ 2018-01-25 16:22     ` Andreas Schwab
  2018-01-25 23:32     ` Rafal Luzynski
  1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2018-01-25 16:22 UTC (permalink / raw
  To: Rafal Luzynski; +Cc: libc-alpha

On Jan 25 2018, Rafal Luzynski <digitalfreak@lingonborough.com> wrote:

> 25.01.2018 01:10 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
>>
>> Primary month names are in a genitive case now, alternative month names
>> are in a nominative case.
>>
>> The alternative digits hack is no longer needed and has been removed.
>>
>> [BZ #10871]
>> * localedata/locales/uk_UA (mon): Renamed to...
>> (alt_mon): This.
>> (alt_digits): "0" removed and then renamed to...
>> (mon): This.
>> (date_fmt): Definition changed not to use the alternative
>> digits hack.
>> ---
>> localedata/locales/uk_UA | 18 +++++-------------
>> 1 file changed, 5 insertions(+), 13 deletions(-)
>> [...]
>
> This has been committed.  Dmitry: yes, it passes make check.

Please don't forget to update ChangeLog.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [COMMITTED][PATCH 1/1] uk_UA: Add alternative month names (bug 10871).
  2018-01-25 13:05   ` [COMMITTED][PATCH " Rafal Luzynski
  2018-01-25 16:22     ` Andreas Schwab
@ 2018-01-25 23:32     ` Rafal Luzynski
  1 sibling, 0 replies; 6+ messages in thread
From: Rafal Luzynski @ 2018-01-25 23:32 UTC (permalink / raw
  To: libc-alpha; +Cc: Andreas Schwab

25.01.2018 17:22 Andreas Schwab <schwab@suse.de> wrote:
> [...]
> Please don't forget to update ChangeLog.

Aaargh! I had it prepared locally but it fell off from my git push.
Thanks for notifying, now it's done.

Regards,

Rafal


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-01-25 23:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-25  0:07 [PATCH 0/1] uk_UA: Add alternative month names (bug 10871) Rafal Luzynski
2018-01-25  0:10 ` [PATCH 1/1] " Rafal Luzynski
2018-01-25 13:05   ` [COMMITTED][PATCH " Rafal Luzynski
2018-01-25 16:22     ` Andreas Schwab
2018-01-25 23:32     ` Rafal Luzynski
2018-01-25  0:25 ` [PATCH 0/1] " Dmitry V. Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).