From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Cc: "H . J . Lu" <hjl.tools@gmail.com>
Subject: [PATCH v2 06/10] x86: Do not raise inexact exception on floorl
Date: Wed, 3 Apr 2024 09:11:46 -0300 [thread overview]
Message-ID: <20240403121150.1018799-7-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20240403121150.1018799-1-adhemerval.zanella@linaro.org>
It is not allowed anymore on ISO C23.
Checked on x86_64-linux-gnu and i686-linux-gnu.
---
sysdeps/i386/fpu/s_floorl.S | 39 -----------------------------------
sysdeps/x86/fpu/s_floorl.c | 38 ++++++++++++++++++++++++++++++++++
sysdeps/x86_64/fpu/s_floorl.S | 33 -----------------------------
3 files changed, 38 insertions(+), 72 deletions(-)
delete mode 100644 sysdeps/i386/fpu/s_floorl.S
create mode 100644 sysdeps/x86/fpu/s_floorl.c
delete mode 100644 sysdeps/x86_64/fpu/s_floorl.S
diff --git a/sysdeps/i386/fpu/s_floorl.S b/sysdeps/i386/fpu/s_floorl.S
deleted file mode 100644
index 3ec28b477b..0000000000
--- a/sysdeps/i386/fpu/s_floorl.S
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Public domain.
- */
-
-#include <libm-alias-ldouble.h>
-#include <machine/asm.h>
-
-RCSID("$NetBSD: $")
-
-ENTRY(__floorl)
- fldt 4(%esp)
- subl $32,%esp
- cfi_adjust_cfa_offset (32)
-
- fnstenv 4(%esp) /* store fpu environment */
-
- /* We use here %edx although only the low 1 bits are defined.
- But none of the operations should care and they are faster
- than the 16 bit operations. */
- movl $0x400,%edx /* round towards -oo */
- orl 4(%esp),%edx
- andl $0xf7ff,%edx
- movl %edx,(%esp)
- fldcw (%esp) /* load modified control word */
-
- frndint /* round */
-
- /* Preserve "invalid" exceptions from sNaN input. */
- fnstsw
- andl $0x1, %eax
- orl %eax, 8(%esp)
-
- fldenv 4(%esp) /* restore original environment */
-
- addl $32,%esp
- cfi_adjust_cfa_offset (-32)
- ret
-END (__floorl)
-libm_alias_ldouble (__floor, floor)
diff --git a/sysdeps/x86/fpu/s_floorl.c b/sysdeps/x86/fpu/s_floorl.c
new file mode 100644
index 0000000000..3eca033f46
--- /dev/null
+++ b/sysdeps/x86/fpu/s_floorl.c
@@ -0,0 +1,38 @@
+/* Return largest integral value not less than argument. x86 version.
+ Copyright (C) 2024 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#define NO_MATH_REDIRECT
+#include <math.h>
+#include <fenv_private.h>
+#include <libm-alias-ldouble.h>
+
+long double
+__floorl (long double x)
+{
+ fenv_t fenv;
+ long double r;
+
+ libc_feholdexcept_setround_387 (&fenv, FE_DOWNWARD);
+ asm volatile ("frndint" : "=t" (r) : "0" (x));
+ /* Preserve "invalid" exceptions from sNaN input. */
+ fenv.__status_word |= libc_fetestexcept_387 (FE_INVALID);
+ libc_fesetenv_387 (&fenv);
+
+ return r;
+}
+libm_alias_ldouble (__floor, floor)
diff --git a/sysdeps/x86_64/fpu/s_floorl.S b/sysdeps/x86_64/fpu/s_floorl.S
deleted file mode 100644
index b74d1a4d6b..0000000000
--- a/sysdeps/x86_64/fpu/s_floorl.S
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Public domain.
- */
-
-#include <libm-alias-ldouble.h>
-#include <machine/asm.h>
-
-ENTRY(__floorl)
- fldt 8(%rsp)
-
- fnstenv -28(%rsp) /* store fpu environment */
-
- /* We use here %edx although only the low 1 bits are defined.
- But none of the operations should care and they are faster
- than the 16 bit operations. */
- movl $0x400,%edx /* round towards -oo */
- orl -28(%rsp),%edx
- andl $0xf7ff,%edx
- movl %edx,-32(%rsp)
- fldcw -32(%rsp) /* load modified control word */
-
- frndint /* round */
-
- /* Preserve "invalid" exceptions from sNaN input. */
- fnstsw
- andl $0x1, %eax
- orl %eax, -24(%rsp)
-
- fldenv -28(%rsp) /* restore original environment */
-
- ret
-END (__floorl)
-libm_alias_ldouble (__floor, floor)
--
2.34.1
next prev parent reply other threads:[~2024-04-03 12:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 12:11 [PATCH v2 00/10] Improve rounding to interger function for C23 Adhemerval Zanella
2024-04-03 12:11 ` [PATCH v2 01/10] math: Add test to check if ceil raise inexact floating-point exception Adhemerval Zanella
2024-04-03 12:54 ` H.J. Lu
2024-04-03 12:11 ` [PATCH v2 02/10] math: Add test to check if floor " Adhemerval Zanella
2024-04-03 12:55 ` H.J. Lu
2024-04-03 12:11 ` [PATCH v2 03/10] math: Add test to check if trunc " Adhemerval Zanella
2024-04-03 12:55 ` H.J. Lu
2024-04-03 12:11 ` [PATCH v2 04/10] math: Add test to check if round " Adhemerval Zanella
2024-04-03 12:56 ` H.J. Lu
2024-04-03 12:11 ` [PATCH v2 05/10] x86: Do not raise inexact exception on ceill Adhemerval Zanella
2024-04-03 13:04 ` H.J. Lu
2024-04-03 13:15 ` Adhemerval Zanella Netto
2024-04-03 13:28 ` H.J. Lu
2024-04-03 12:11 ` Adhemerval Zanella [this message]
2024-04-03 12:11 ` [PATCH v2 07/10] x86: Do not raise inexact exception on truncl Adhemerval Zanella
2024-04-03 12:11 ` [PATCH v2 08/10] x86: Do not raise inexact exception on floor/floorf Adhemerval Zanella
2024-04-03 12:11 ` [PATCH v2 09/10] i386: Do not raise inexact exception on ceil/ceilf Adhemerval Zanella
2024-04-03 12:11 ` [PATCH v2 10/10] i386: Do not raise inexact exception on trunc/truncf Adhemerval Zanella
2024-04-03 15:03 ` [PATCH v2 00/10] Improve rounding to interger function for C23 Joseph Myers
2024-04-03 17:10 ` Adhemerval Zanella Netto
2024-04-04 5:25 ` Paul Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403121150.1018799-7-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).