From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C472C1F44D for ; Wed, 27 Mar 2024 19:42:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZFTOjJEo; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29EF4385F027 for ; Wed, 27 Mar 2024 19:42:50 +0000 (GMT) Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id 8F4DD3858427 for ; Wed, 27 Mar 2024 19:40:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F4DD3858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F4DD3858427 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1036 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711568448; cv=none; b=MAUo+ZGGhyZi6dGlIe93mP2Ym15IjIhsqnizoUCRLy3QQDf0S5fLNjWSTB6V4Wp3Xclk42nDvQNPAanW1coHw772ELZ/tThc565TPHVngckM1/AIudsX/b8p+7HlJZtGGAH+TT/8rFJkz+opBwLu0d0jjxfJow82SM8w+ly8S2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711568448; c=relaxed/simple; bh=V2QOHmynST+A06BJ1vVs7hRXKEsIYCDGCjaalv4frLA=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Y3j0iod9p/vbeHuLn/QS2/oWvxQY85zGJHeZkIBmuD2Affclpor0vtBhvVTIWJYlvImethCL18kmCao0NSfI8xSXLPtWp2ZR0bAr4c5aEPQ5md39hzmSMGz10M9aDBxgZriB12a2lWWA6r5kdyWBN2cYqDgfjHY6NbeSad6CbmQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-29dee60302fso956988a91.1 for ; Wed, 27 Mar 2024 12:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711568445; x=1712173245; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b/uJsYX5TjTzzmu5D77iSjXX+egw1x7sUXQBSMn9NVQ=; b=ZFTOjJEo4puhIjIb8HbKVzPEGuq9v0PIkET+qdIcVA8d5Aoc11fq+VFzi5p2YPAb3A 856iw5idvrIcrxx1xGZ4B38eO6mpEIPQyux8JbKYlq7eYD2ZkaPOqj1GjyWGDhNLad+e 4HZMpTYm54ZVqlQUeLIM40uq3yl/+JvWJmVaELBYyVLcE2M6JdIS5nQEjnqSpMi9XNzV 0D684DaHZh22rPLPLmUpFhbbZ2t/3ofRLmbGXmJ9D8uPs7W03lRw3CWG5aD5dxnWkqDY a2iBti1Hq1P0z5i2cR4ZAbMYX56P0jf4rR79mVstyC5AXFUcSCpU5QDHSA3+FXO4DMOz Zd7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711568445; x=1712173245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b/uJsYX5TjTzzmu5D77iSjXX+egw1x7sUXQBSMn9NVQ=; b=FOeNUGGAyFx6RwklDmLoTKFWOvnAJp9vh+zbEP5MteQ/gx9lqat3DutUW+ekNRhUzd Debd9Yexbj5EZ/ITc0xNZdHKhXe04q7iznZ1DmnTzBAQfPLB58ghNmXRdTK3MKd0Vsrr ZEQGI5+70HCNw4F+oFJj1UDVrbqB9izRt2LOB5oT73sWp4WwdCxlT652JAaKAE9YrrjF eNfz4AftIdREVTurrABfhC6ET8e7KTd3dSxM62tCOvTW/nVgEUkIc4SLEuk/9bLiT02B zgxJ2TKm2EiKN7Ca2dIUoHru68i+eoxuPk3EJ/kT3CcCDohK8UyBnD+GnTmwUl1sqlry JyRw== X-Gm-Message-State: AOJu0YwkGyvV/y98liSL3DT3RvVk+45vDvxAXiHCBQOt/pWsMJaJ8ISI ZD0beiTe2NIxTFdKltB2ZZFZjCnrtYp9Redf5CzEV3buaz22i3mE6pha+Ip1+JeVac7WeA4Xecf d X-Google-Smtp-Source: AGHT+IH1JAhnAfdGv4OBko0/VQNZk+M5JdnUhA5VBPXEBSeU3TggdGEhO0iA0MAEyrfDS0TTV2mmrw== X-Received: by 2002:a17:90a:990e:b0:2a0:4ef8:182a with SMTP id b14-20020a17090a990e00b002a04ef8182amr278626pjp.21.1711568444717; Wed, 27 Mar 2024 12:40:44 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c3:b18e:67c4:6248:3d8a:f386]) by smtp.gmail.com with ESMTPSA id p11-20020a17090a348b00b002a091be027esm2277357pjb.31.2024.03.27.12.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:40:44 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Joseph Myers , Florian Weimer , "H . J . Lu" Subject: [PATCH v2 07/10] math: Fix isnanf128 static build Date: Wed, 27 Mar 2024 16:40:21 -0300 Message-Id: <20240327194024.1409677-8-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240327194024.1409677-1-adhemerval.zanella@linaro.org> References: <20240327194024.1409677-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Some static implementation of float128 routines might call __isnanf128, which is not provided by the static object. Checked on x86_64-linux-gnu. --- math/Makefile | 1 + sysdeps/ieee754/float128/float128_private.h | 2 +- sysdeps/ieee754/float128/s_isnanf128.c | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/math/Makefile b/math/Makefile index f1d210797d..516fa72a26 100644 --- a/math/Makefile +++ b/math/Makefile @@ -372,6 +372,7 @@ libm-test-funcs-auto-static = \ # libm-test-funcs-auto-static libm-test-funcs-noauto-static = \ fmod \ + isnan \ # libm-test-funcs-noauto-static libm-test-funcs-narrow-static = libm-test-funcs-all-static = $(libm-test-funcs-auto-static) $(libm-test-funcs-noauto-static) diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee754/float128/float128_private.h index 38a8bdd0fe..672bf3cccf 100644 --- a/sysdeps/ieee754/float128/float128_private.h +++ b/sysdeps/ieee754/float128/float128_private.h @@ -352,7 +352,7 @@ #define frexpl frexpf128 #define getpayloadl getpayloadf128 #define isinfl isinff128_do_not_use -#define isnanl isnanf128_do_not_use +#define isnanl isnanf128 #define ldexpl ldexpf128 #define llrintl llrintf128 #define llroundl llroundf128 diff --git a/sysdeps/ieee754/float128/s_isnanf128.c b/sysdeps/ieee754/float128/s_isnanf128.c index 59f71533ce..b73a4e80d7 100644 --- a/sysdeps/ieee754/float128/s_isnanf128.c +++ b/sysdeps/ieee754/float128/s_isnanf128.c @@ -11,7 +11,11 @@ #include "../ldbl-128/s_isnanl.c" #if !IS_IN (libm) #include +#ifdef SHARED hidden_ver (__isnanf128_impl, __isnanf128) +#else +strong_alias (__isnanf128_impl, __isnanf128) +#endif _weak_alias (__isnanf128_impl, isnanl) versioned_symbol (libc, __isnanf128_impl, __isnanf128, GLIBC_2_34); #if (SHLIB_COMPAT (libc, FLOAT128_VERSION_M, GLIBC_2_34)) -- 2.34.1