From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Cc: Joseph Myers <josmyers@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
"H . J . Lu" <hjl.tools@gmail.com>
Subject: [PATCH 14/15] math: Fix y0 template for arguments less/equal than 0
Date: Wed, 27 Mar 2024 13:45:26 -0300 [thread overview]
Message-ID: <20240327164527.3717523-15-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20240327164527.3717523-1-adhemerval.zanella@linaro.org>
The template is used by some ABI for the static build, and it
fails to correct return if the argument is less/equal than 0
Checked on x86_64-linux-gnu.
---
math/Makefile | 1 +
math/w_j0_template.c | 16 ++++++++++++----
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/math/Makefile b/math/Makefile
index 7391f2bd41..5807e949d7 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -372,6 +372,7 @@ libm-test-funcs-auto-static = \
exp10 \
log2 \
log10 \
+ y0 \
# libm-test-funcs-auto-static
libm-test-funcs-noauto-static = \
copysign \
diff --git a/math/w_j0_template.c b/math/w_j0_template.c
index 1822fc8213..afa2056f96 100644
--- a/math/w_j0_template.c
+++ b/math/w_j0_template.c
@@ -39,11 +39,19 @@ M_DECL_FUNC (__y0) (FLOAT x)
if (__glibc_unlikely (islessequal (x, M_LIT (0.0))))
{
if (x < 0)
- /* Domain error: y0(x<0). */
- __set_errno (EDOM);
+ {
+ /* Domain error: y0(x<0). */
+ __feraiseexcept (FE_INVALID);
+ __set_errno (EDOM);
+ return NAN;
+ }
else if (x == 0)
- /* Pole error: y0(0). */
- __set_errno (ERANGE);
+ {
+ /* Pole error: y0(0). */
+ __feraiseexcept (FE_DIVBYZERO);
+ __set_errno (ERANGE);
+ return -INFINITY;
+ }
}
return M_SUF (__ieee754_y0) (x);
}
--
2.34.1
next prev parent reply other threads:[~2024-03-27 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:45 [PATCH 00/15] Fix some libm static issues Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 01/15] math: Add support for auto static math tests Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 02/15] math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488) Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 03/15] i386: Use generic fmod Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 04/15] i386: Use generic fmodf Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 05/15] math: Fix i386 and m68k exp10 on static build Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 06/15] i386: Use generic exp10 Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 07/15] math: Fix isnanf128 static build Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 08/15] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 09/15] math: Provide frexpf128 " Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 10/15] math: Provide modf128 " Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 11/15] math: Fix acos template for arguments greater than 1 Adhemerval Zanella
2024-03-27 17:14 ` Joseph Myers
2024-03-27 17:58 ` Adhemerval Zanella Netto
2024-03-27 19:04 ` Joseph Myers
2024-03-27 19:31 ` Adhemerval Zanella Netto
2024-03-27 16:45 ` [PATCH 12/15] math: Fix log10 template for inputs less than 0 Adhemerval Zanella
2024-03-27 16:45 ` [PATCH 13/15] math: Fix log2 " Adhemerval Zanella
2024-03-27 16:45 ` Adhemerval Zanella [this message]
2024-03-27 16:45 ` [PATCH 15/15] math: Fix y1 template for arguments less/equal " Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327164527.3717523-15-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=josmyers@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).