From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D32CB1F451 for ; Thu, 4 Jan 2024 22:48:26 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=eUtShfUz; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1BD153870853 for ; Thu, 4 Jan 2024 22:48:26 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A10A6386F828 for ; Thu, 4 Jan 2024 22:48:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A10A6386F828 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A10A6386F828 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704408484; cv=none; b=N8Q/9R+Ofs3xCVlec/ekB6Oalu9Xl5mlQd1ocWwdIY8bgsBlSscqCZ2kCEvKofvvjDaLdWclbionPunf40xgRu6LN7ty3j+vjZbmjTFtU9t6fXo7m0bmmXMrvAE0X5bKifY3yfsoRF8aZOE5zDS34dorAMZ0RRyPsXWJgIzxld0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704408484; c=relaxed/simple; bh=LrsFnz6GZEcCVzULdezztx75SZ4gG17yA+2bsiJIOu8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=DCx/yH7gu/i01PaZti0R/DteA9/pBuuiNFJkQG0KrulJtjtD6oz/MpcRXZHZN/FdRH4tfLiR4NGEKFJGkmRvysYqBs5jR07KWa+3XwIG/vGPiiVliM75q4pCaSEmBbPmAPAsreFZ0450SvwUmtWZSdTAVcZs1Pq5t0vz4jQuo4c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLWVO-0000ln-8m; Thu, 04 Jan 2024 17:48:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=zemfwrBlYWwX4vIhQXUIg6m7hWBVQSxS9QwauN4rRWw=; b=eUtShfUzWCEDxbpu8a2V 4CYyot8vaHRaSLZQ2T1nXOsgMBnvRbjKa2Zdr4APnLu/FWFG9xS+Ga8Mp9lLCD0rkQ3TbprT4+rwo 17oneyJLt7a5K9j1sLQMbtgbY0uMESV7C11BjUTHYcO/l8OgFgZWaPNIFr7+R3kTnSSFWXbQjdL7Z vk6ZpZ4pn6NGXSxyMWSpzmI2ctoPe4UB36Q59ICEs1xrdeaNUWkNj0yxWcKnz64aiRRxPUnktvvaY ABrXxs1xIY5cENWy2ZYB3Bi8vhprAclus+CI+DXi2DO1fP4sjZOaW6kEU9iem57CDh2gaAhA/8eqY TTliqErXzJ6neA==; Date: Thu, 4 Jan 2024 23:48:00 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH 08/23] hurd: Drop x86-specific assembly from init-first.c Message-ID: <20240104224800.x3el5p7qkaiq4hqk@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20240103171502.1358371-1-bugaevc@gmail.com> <20240103171502.1358371-9-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240103171502.1358371-9-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Applied, thanks! Sergey Bugaev, le mer. 03 janv. 2024 20:14:41 +0300, a ecrit: > We already have the RETURN_TO macro for this exact use case, and it's already > used in the non-static code path. Use it here too. > > Signed-off-by: Sergey Bugaev > --- > > This was the last piece of x86 specifics in init-first.c! > (Remember, it started as sysdeps/mach/hurd/i386/init-first.c, with lots of > i386-specific assumptions about how arguments are passed and so on.) > > sysdeps/mach/hurd/x86/init-first.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/sysdeps/mach/hurd/x86/init-first.c b/sysdeps/mach/hurd/x86/init-first.c > index 6f71d71b..211b2096 100644 > --- a/sysdeps/mach/hurd/x86/init-first.c > +++ b/sysdeps/mach/hurd/x86/init-first.c > @@ -218,15 +218,7 @@ _hurd_stack_setup (void **argptr) > void doinit (intptr_t *data) > { > init ((void **) data); > -# ifdef __x86_64__ > - asm volatile ("movq %0, %%rsp\n" /* Switch to new outermost stack. */ > - "xorq %%rbp, %%rbp\n" /* Clear outermost frame pointer. */ > - "jmp *%1" : : "r" (data), "r" (caller)); > -# else > - asm volatile ("movl %0, %%esp\n" /* Switch to new outermost stack. */ > - "xorl %%ebp, %%ebp\n" /* Clear outermost frame pointer. */ > - "jmp *%1" : : "r" (data), "r" (caller)); > -# endif > + RETURN_TO (data, caller, 0); > __builtin_unreachable (); > } > > -- > 2.43.0 > > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.