From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D60FE1F451 for ; Wed, 3 Jan 2024 21:36:13 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Z+jaVbBW; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B61E3857BAC for ; Wed, 3 Jan 2024 21:36:13 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id F297E3858414 for ; Wed, 3 Jan 2024 21:35:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F297E3858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F297E3858414 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704317755; cv=none; b=J8IZRpS3gzvaECK3fmDSAHC4SZLFItgXpiCmqhas+Fjsaf3hDuFyIERmw7vn9bs2dwu3kwsHPxgDBoGSOKzTyPpLvVhey/MKV22+uslgELAAIE/wkR+Ob9Vg8jlcOyJVHUzzMhiTQa5KwlFJLTxBO2XcAPB15kmCReAod5Cmq98= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704317755; c=relaxed/simple; bh=gHlvDVLehO/mO64Jr0reo6UoRefY1MvDza+VcFLTYF4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=xZjxAKFYbALb1mVPxp/FKi2AkVNDREtUImlDh7LCEYIK3V2i3jw1OxBmcvmScSSFtqprjpjHBpUNG6SI7XzTkDS5+miJkGnJeKwSGmINMY6HsyxUn8fm6C6wLskx09Q4zQyj6Il2786MSfOecZdgVhNl5bYnMyA6+mVTItDtWfQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL8tz-0007x8-Ut; Wed, 03 Jan 2024 16:35:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=lGYUgSu+ybqZ30TxOL7w3CFrBKAkzx4GRht0sBSzJY0=; b=Z+jaVbBW0tEViDkpFbil 7iGXQ+wWzvN9VsmrK9lUlLlhcjEMz06AheupyHy2TJSGwuZye8gX3t4l9RIa1j2kHkLHHSrzQrW5s rtR/QXdqJ3uvDB5ee+iRB7hnGChmtcBJiCFwzabK1vn36Oy/zJ8Mjk8eL9RF5HgKRs//3HlvMiBD2 n7tUOMi7udN1pGG/ag72qtJweMKREwvCHCzfw254Ae+CpdIRk3Tlb6EGmOQADCtsIJz/t5N7zUDxT J9zLVd2KOpb7qJirbv3YsSEyQIs+Eq7MmpVMttDAS0x+tD6h/TO6273q+O3AdyeJefZRrK1dVrgBM Yt3//zniVnQJTQ==; Date: Wed, 3 Jan 2024 22:35:47 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH 01/23] hurd: Add some missing includes Message-ID: <20240103213547.afytcner5itlv5q7@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20240103171502.1358371-1-bugaevc@gmail.com> <20240103171502.1358371-2-bugaevc@gmail.com> <20240103204314.wpyy2tv33x4sdl37@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sergey Bugaev, le jeu. 04 janv. 2024 00:24:30 +0300, a ecrit: > On Thu, Jan 4, 2024 at 12:08 AM Sergey Bugaev wrote: > > This is testing installed headers, isn't it? — then > > how come sysdeps/hurd/include/hurd.h is what gets found for ? > > I'm rather sure the installed is a different file. So it > > would look like the test setup is broken, and this patch just exposes > > that. > > Should the include be guarded by ifndef _ISOMAC perhaps? And > if we indeed move the inline functions to the internal hurd.h, they'd > also be guarded by ifndef _ISOMAC? Yes. > But really, why doesn't the test filter out the internal include directories? I'll leave that to the people who would know examples of needing internal definitions. Samuel