From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C2C771F451 for ; Wed, 3 Jan 2024 21:01:20 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=a2qXd5Kc; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0EFB63858015 for ; Wed, 3 Jan 2024 21:01:20 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1C72A385828D for ; Wed, 3 Jan 2024 21:00:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C72A385828D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C72A385828D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704315654; cv=none; b=rEt4A3CSVV51pjErroISs+NEsrWAtBz+W7zlqesuowlqoaP+SBCLv4sZb8cGTxZc7FsukMmIZjRFwzQEnTTl6OQybjv6kxubY4o66CtahFXuRlA++kTpKpiGhn9QtLKnc8abEUgaRYirTVgAdwnqGzGsna2NuRq1iDCFN2Aw/8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704315654; c=relaxed/simple; bh=AQfHzGSZ8fYNAfchG8sXITb5JZVb7qv81d0VkQMI8VQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rAwVzYEMZ7XgSQVnk8t/qtl5eCIAs5nRgCVcU7+TXVU+e3aTchQ3bmHCmfky1akvbDI8MEUZQDyMfCtwZKZtGXBc/DIX6r/hDfm7IJkiGJwFoHAj9daKh4O8QG33PGbgCrvFIRCMGWIo/okTqacx0/9A7/iZPWCehGzcKCQSdbg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL8M7-00028i-It; Wed, 03 Jan 2024 16:00:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=RQIsT1n+PZs3pRNZVbUyjSBr0vJ0wn789R4aZn5ZaF8=; b=a2qXd5KcrML3W6TO/K0j Lh36P7wBKqfFoG+TXbZCGQTcHATlHl8kFd1O/Mha54A3Mb0FkvZaXdIXM+OGSNG5/P4cDA2uTmBcG FWpT0LUcgA1wyyaHuz8hRctoULwDA0uWC2bHtD053JQEC8FMU9EZp4S+kolzX2xnZZ/DzUC6BGzoH leQ2qk4S/IR2d1XppY+CIFIjslGIDZKPqmVP6k622M8nMctRJ90+Xrv9MDWylHa5gAw9zWXfFKSzA Bs84gZX6yNJSdZIC0FTr/LXjg7dBHnJFEC3UE+AzHINiZkVECcpSsHGUw/cbzjjYsz8NOWGd08XPW hLrXzKZe9nMpjw==; Date: Wed, 3 Jan 2024 22:00:28 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH 06/23] mach: Drop SNARF_ARGS macro Message-ID: <20240103210028.n4djgjbdxji724rm@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20240103171502.1358371-1-bugaevc@gmail.com> <20240103171502.1358371-7-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240103171502.1358371-7-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Applied, thanks! Sergey Bugaev, le mer. 03 janv. 2024 20:14:39 +0300, a ecrit: > We're obtaining arguments from the stack differently, see init-first.c. > > Signed-off-by: Sergey Bugaev > --- > sysdeps/mach/sysdep.h | 7 ------- > sysdeps/mach/x86/sysdep.h | 14 -------------- > 2 files changed, 21 deletions(-) > > diff --git a/sysdeps/mach/sysdep.h b/sysdeps/mach/sysdep.h > index 8eeac45b..3e0553d8 100644 > --- a/sysdeps/mach/sysdep.h > +++ b/sysdeps/mach/sysdep.h > @@ -56,13 +56,6 @@ > /* This is not used on all machines. */ > #endif > > -/* Set variables ARGC, ARGV, and ENVP for the arguments > - left on the stack by the microkernel. */ > -#ifndef SNARF_ARGS > -#define SNARF_ARGS(argc, argv, envp) > -#error SNARF_ARGS not defined by sysdeps/mach/MACHINE/sysdep.h > -#endif > - > /* LOSE can be defined as the `halt' instruction or something > similar which will cause the process to die in a characteristic > way suggesting a bug. */ > diff --git a/sysdeps/mach/x86/sysdep.h b/sysdeps/mach/x86/sysdep.h > index ed9f7f46..63be5638 100644 > --- a/sysdeps/mach/x86/sysdep.h > +++ b/sysdeps/mach/x86/sysdep.h > @@ -25,20 +25,6 @@ > > #define LOSE asm volatile ("hlt") > > -#define SNARF_ARGS(entry_sp, argc, argv, envp) \ > - do \ > - { \ > - char **p; \ > - argc = (int) *entry_sp; \ > - argv = (char **) (entry_sp + 1); \ > - p = argv; \ > - while (*p++ != NULL) \ > - ; \ > - if (p >= (char **) argv[0]) \ > - --p; \ > - envp = p; \ > - } while (0) > - > #define STACK_GROWTH_DOWN > > /* Get the machine-independent Mach definitions. */ > -- > 2.43.0 > > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.