From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F0B401F451 for ; Wed, 3 Jan 2024 21:01:20 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=CuZTIrk6; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 31FB4385801E for ; Wed, 3 Jan 2024 21:01:20 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 2400838582B9 for ; Wed, 3 Jan 2024 21:00:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2400838582B9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2400838582B9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704315654; cv=none; b=NE/w/jEILisQrE16KblPCMuDcD3K7kVLNDligNIF0DYN51GswUGxXIHzY8+6qam7GepVWLxPSvlMahyBttx2wuMB3wc/LGrhVcDIrqZbDjnTvd/Vh0OI8j4/Pw0U3GhDpkoQqujXpoPmoHJCzfMPYVbGFkL6Hcmgsq1o48yoH3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704315654; c=relaxed/simple; bh=LA4Zt2aiMU1FckHNTe88jIANXgK7Uu9ZEjQhdp6aZdo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=fiBUg2UYKHZnwIT7h/VuYGjiEQxgUFq6AAphyEakkTKfsYdpY+HVN2PO/9siGP7Ds5oyw7/fvYqC9f5w+2Gar25lz/vBf7C+X2yxcyhn2QJDHulvbecwoD8UxLvRlwycRBvARrPbrF0ly2itf2uB6Ui+tWMyjic82yJ8aSujv9Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL8M7-00028k-Il; Wed, 03 Jan 2024 16:00:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=ZWc3pZKL500YsagRm0E8w0G5YzS+J3575Xf97pvH0WU=; b=CuZTIrk6STy+tsXAP8cd hbYmfIH+sYAZ5KrCEGPmFwrHprfgWS8biBckfC3sQiGB4xmK0Jwo/iOzE9GYG19ovTnxyA7THNUdn If4tWIPUOdAAOYiPW3tkJkwxrnfuW7wHZTHgfKMmgMuylYhK1nM54EY1UJM9FJcPWOXBx+V8g85Ap diGOR4D0sFZBDNUQlYNtOTJrTXRj3ThzfmjWfxoM0LbkEs/rPEnUo3l+FhVBA4ipJ4jjj2JVyW9Yv Xd1V1Vy6op3aNTZg1fvlzOE5S7J8SkhbUQD5yjbjnxB309EZs2F23gyk1zkPv8QZ9hjRKg5zztY3S 17yi9FzH0u4fiA==; Date: Wed, 3 Jan 2024 22:00:22 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH 04/23] mach: Drop some unnecessary vm_param.h includes Message-ID: <20240103210022.v3ccve4qwvoftnrq@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20240103171502.1358371-1-bugaevc@gmail.com> <20240103171502.1358371-5-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240103171502.1358371-5-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Applied, thanks! Sergey Bugaev, le mer. 03 janv. 2024 20:14:37 +0300, a ecrit: > Signed-off-by: Sergey Bugaev > --- > > We should try to include vm_param.h less; this statically asserts that > these files are not possibly using the PAGE_SIZE definition. > > dl-sysdep.c used VM_MAX_ADDRESS for the "loser kludge for vm_map kernel > bug"; that bug has been fixed and the kludge removed. setup-thread.c has > been including vm_param.h from the start; I can't see any reason for it. > > mach/setup-thread.c | 1 - > sysdeps/mach/hurd/dl-sysdep.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/mach/setup-thread.c b/mach/setup-thread.c > index 72bf1083..1e7f9953 100644 > --- a/mach/setup-thread.c > +++ b/mach/setup-thread.c > @@ -19,7 +19,6 @@ > #include > #include > #include > -#include > #include > #include "sysdep.h" /* Defines stack direction. */ > > diff --git a/sysdeps/mach/hurd/dl-sysdep.c b/sysdeps/mach/hurd/dl-sysdep.c > index d3933bfe..43129a1e 100644 > --- a/sysdeps/mach/hurd/dl-sysdep.c > +++ b/sysdeps/mach/hurd/dl-sysdep.c > @@ -32,7 +32,6 @@ > #include > #include > #include > -#include > #include "hurdstartup.h" > #include > #include > -- > 2.43.0 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.