From: Jakub Jelinek via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 4/4] libgcc: Use _dl_find_eh_frame in _Unwind_Find_FDE
Date: Fri, 26 Nov 2021 16:49:40 +0100 [thread overview]
Message-ID: <20211126154940.GJ2646553@tucnak> (raw)
In-Reply-To: <87o868j7aq.fsf@oldenburg.str.redhat.com>
On Thu, Nov 25, 2021 at 09:42:53PM +0100, Florian Weimer wrote:
> I've included a simplified version below, based on the _dl_find_object
> patch for glibc.
>
> This is a bit difficult to test, but I ran a full toolchain bootstrap
> with GCC + glibc on all glibc-supported architectures (except Hurd and
> one m68k variant; they do not presnetly build, see Joseph's testers).
>
> I also tested this by copying the respective GCC-built libgcc_s into a
> glibc build tree for run-time testing on i686-linux-gnu and
> x86_64-linux-gnu. There weren't any issues. There are a buch of
> unwinder tests in glibc, giving at least some coverage.
See the comment I've just sent on this patch.
If the DLFO_STRUCT_HAS_EH_DBASE and DLFO_STRUCT_HAS_EH_COUNT
macros are gone, we'd need to use __GLIBC_PREREQ or configure test
or combination of the two.
Otherwise LGTM.
> Subject: libgcc: Use _dl_find_object in _Unwind_Find_FDE
>
> libgcc/ChangeLog:
>
> * unwind-dw2-fde-dip.c (_Unwind_Find_FDE): Call _dl_find_object
> if available.
Jakub
prev parent reply other threads:[~2021-11-26 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 16:28 [PATCH 0/4] Use _dl_find_eh_frame to locate DWARF EH data in the unwinder Florian Weimer via Libc-alpha
2021-11-03 16:28 ` [PATCH 1/4] libgcc: Remove tbase member from struct unw_eh_callback_data Florian Weimer via Libc-alpha
2021-11-18 13:47 ` Jakub Jelinek via Libc-alpha
2021-11-03 16:28 ` [PATCH 2/4] libgcc: Remove dbase member from struct unw_eh_callback_data if NULL Florian Weimer via Libc-alpha
2021-11-18 14:33 ` Jakub Jelinek via Libc-alpha
2021-11-03 16:28 ` [PATCH 3/4] libgcc: Split FDE search code from PT_GNU_EH_FRAME lookup Florian Weimer via Libc-alpha
2021-11-18 15:21 ` Jakub Jelinek via Libc-alpha
2021-11-23 17:56 ` Florian Weimer via Libc-alpha
2021-11-25 17:16 ` Jakub Jelinek via Libc-alpha
2021-11-03 16:28 ` [PATCH 4/4] libgcc: Use _dl_find_eh_frame in _Unwind_Find_FDE Florian Weimer via Libc-alpha
2021-11-18 15:45 ` Jakub Jelinek via Libc-alpha
2021-11-25 20:42 ` Florian Weimer via Libc-alpha
2021-11-26 15:49 ` Jakub Jelinek via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211126154940.GJ2646553@tucnak \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).