From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9C9141F8C6 for ; Fri, 10 Sep 2021 17:40:13 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E7503857C58 for ; Fri, 10 Sep 2021 17:40:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E7503857C58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631295611; bh=EeEc4YjEG69JNCBA2SsVjJUngvKgvyL1/DEyTEal1yM=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uQpFsLxFbYZRRy4AziL75BetOFHTv5RIrqy/6BUbNDAXWo1wlD6XFxluU5w+WMyQU rHYEJnQVSoyRjiD0jKbSkZaHR/PRwhiqNNU/FDNgu/wpzSXzofmPxq3nHLFfGy/SbB sOFeD/1jPUo9C48MZ0SNPGHpbsozy3gGHiUjluRw= Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by sourceware.org (Postfix) with ESMTPS id 8C1013858405 for ; Fri, 10 Sep 2021 17:39:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C1013858405 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A299611CB; Fri, 10 Sep 2021 17:39:51 +0000 (UTC) Received: by pali.im (Postfix) id 2530D2828; Fri, 10 Sep 2021 19:39:49 +0200 (CEST) Date: Fri, 10 Sep 2021 19:39:49 +0200 To: "Alejandro Colomar (man-pages)" , Michael Kerrisk Subject: Re: [PATCH v3] ioctl_tty.2: Fix information about header include file Message-ID: <20210910173949.bkyunodbtau2gg6j@pali> References: <3d927d3c-67a1-bb48-b597-44c87b8f715a@gmail.com> <20210831202809.29819-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210831202809.29819-1-pali@kernel.org> User-Agent: NeoMutt/20180716 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?Pali_Roh=C3=A1r_via_Libc-alpha?= Reply-To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Marek =?utf-8?B?QmVow7pu?= , "G. Branden Robinson" , libc-alpha@sourceware.org, linux-man@vger.kernel.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Tuesday 31 August 2021 22:28:09 Pali Rohár wrote: > Header file termios.h contains incompatible definitions for linux ioctl > calls. Correct definitions are exported by header file linux/termios.h but > this file conflicts with sys/ioctl.h header file (required for ioctl() > call). Therefore include direct asm header file asm/termbits.h which > contains compatible definitions and structures for ioctl calls. > > Signed-off-by: Pali Rohár Hello Alejandro! Could you check also this patch? > --- > Changes in v3: > * Use .I instead of .B #include > * Use Bnnn instead of Bnn > > Changes in v2: > * Reformat SYNOPSIS for 80 chars per line > --- > man2/ioctl_tty.2 | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2 > index 186011ee7c33..7d866867c6bd 100644 > --- a/man2/ioctl_tty.2 > +++ b/man2/ioctl_tty.2 > @@ -11,8 +11,10 @@ ioctl_tty \- ioctls for terminals and serial lines > .SH SYNOPSIS > .nf > .B #include > -.BR "#include " " /* Definition of " CLOCAL ", and" > -.BR " TC*" { FLUSH , ON , OFF "} constants */" > +.BR "#include " " /* Definition of " "struct termios" , > +.BR " struct termios2" ", and" > +.BR " Bnnn" ", " BOTHER ", " CBAUD ", " CLOCAL , > +.BR " TC*" { FLUSH , ON , OFF "} and other constants */" > .PP > .BI "int ioctl(int " fd ", int " cmd ", ...);" > .fi > @@ -31,6 +33,19 @@ makes for nonportable programs. > Use the POSIX interface described in > .BR termios (3) > whenever possible. > +.PP > +Please note that > +.B struct termios > +from > +.I > +is different and incompatible with > +.B struct termios > +from > +.IR . > +These ioctl calls require > +.B struct termios > +from > +.IR . > .SS Get and set terminal attributes > .TP > .B TCGETS > -- > 2.20.1 >