From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4C6411F8C6 for ; Thu, 9 Sep 2021 23:25:43 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D3F3384B0D1 for ; Thu, 9 Sep 2021 23:25:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D3F3384B0D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631229942; bh=M8ruyub7g422ZXbUdgRE1+/OkVD5JCM9Vt3dkbHO6+U=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CfDHUFkBnZXXv9dpv2hypJLklOZXuUptJZoTCrr2GIHqKqZieFnlDZPeiQaxE8Obt Zi9dbrAFAXvAXk/Yi4lW1MoR7KUikmKHRfDNVXinjDHpMvqp+ATzrjGiyG5/ORfJxf SRWwStt+NqcqIlLPACndwYifVQEWD06r6OYxsXKw= Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 8CBD33858C2C for ; Thu, 9 Sep 2021 23:25:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CBD33858C2C Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 6C67D50A; Fri, 10 Sep 2021 01:25:19 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4tIHTnZcp0DW; Fri, 10 Sep 2021 01:25:18 +0200 (CEST) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 76AB61EC; Fri, 10 Sep 2021 01:25:18 +0200 (CEST) Received: from samy by begin with local (Exim 4.95-RC2) (envelope-from ) id 1mOTPx-0000FA-Dv; Fri, 10 Sep 2021 01:25:17 +0200 Date: Fri, 10 Sep 2021 01:25:17 +0200 To: Florian Weimer Subject: Re: [PATCH htl v3 5/5] testrun.sh: Add support for --tool=rpctrace Message-ID: <20210909232517.sgmcx4l5gfspuuqz@begin> Mail-Followup-To: Florian Weimer , Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20210907133325.255690-1-bugaevc@gmail.com> <20210907133325.255690-6-bugaevc@gmail.com> <8735qfr1ug.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735qfr1ug.fsf@oldenburg.str.redhat.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- X-Rspamd-Server: hera X-Rspamd-Queue-Id: 6C67D50A X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_CC(0.00)[gmail.com]; BAYES_HAM(-3.00)[100.00%] X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Samuel Thibault via Libc-alpha Reply-To: Samuel Thibault Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, Sergey Bugaev Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Applied this patch, thanks! Samuel Florian Weimer, le mer. 08 sept. 2021 08:57:43 +0200, a ecrit: > * Sergey Bugaev: > > > rpctrace(1) is a Hurd RPC tracer tool, which is used similar to how > > strace(1) is used on GNU/Linux. > > > > Signed-off-by: Sergey Bugaev > > --- > > Makefile | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index f98d5a9e67..a49870d3d1 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -141,8 +141,9 @@ usage () { > > cat << EOF > > Usage: $$0 [OPTIONS] [ARGUMENTS...] > > > > - --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or > > - container. The container will run within support/test-container. > > + --tool=TOOL Run with the specified TOOL. It can be strace, rpctrace, > > + valgrind or container. The container will run within > > + support/test-container. > > EOF > > > > exit 1 > > @@ -177,6 +178,10 @@ case "$$toolname" in > > exec strace $(patsubst %, -E%, $(run-program-env)) \ > > $(test-via-rtld-prefix) $${1+"$$@"} > > ;; > > + rpctrace) > > + exec rpctrace $(patsubst %, -E%, $(run-program-env)) \ > > + $(test-via-rtld-prefix) $${1+"$$@"} > > + ;; > > valgrind) > > exec env $(run-program-env) valgrind $(test-via-rtld-prefix) $${1+"$$@"} > > ;; > > Looks okay. This can go in separately. > > Thanks, > Florian