unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>,
	Nicolas Saenz Julienne <nsaenzju@redhat.com>
Subject: [PATCH v2 0/3] Revert the use of sched_getaffinity on get_nproc
Date: Tue,  7 Sep 2021 09:22:56 -0300	[thread overview]
Message-ID: <20210907122259.79800-1-adhemerval.zanella@linaro.org> (raw)

The use of sched_getaffinity on get_nproc and
sysconf (_SC_NPROCESSORS_ONLN) done in 903bc7dcc2acafc40 (BZ #27645)
breaks the top command in common hypervisor configurations and also
other monitoring tools.

This patchset revert to previous strategy to obtain the system-wide
information first from sysfs, and then on procfs as a fallback.

The sched_getaffinity is still used on malloc code since it makes more
sense to get the per-process value to tune the maximum arena value.

---
Changes in v2:
 - Added tst-sched_getaffinity.c
 - Use enum for cpu_bits_size
 - Comments cleanup

Adhemerval Zanella (3):
  misc: Add __get_nprocs_sched
  linux: Simplify get_nprocs
  linux: Revert the use of sched_getaffinity on get_nproc (BZ #28310)

 include/sys/sysinfo.h                 |   7 +-
 malloc/arena.c                        |   2 +-
 misc/getsysstats.c                    |   6 +
 posix/Makefile                        |   3 +-
 posix/tst-sched_getaffinity.c         |  47 +++++++
 sysdeps/mach/getsysstats.c            |   6 +
 sysdeps/unix/sysv/linux/getsysstats.c | 195 ++++++++++++++++++++------
 7 files changed, 217 insertions(+), 49 deletions(-)
 create mode 100644 posix/tst-sched_getaffinity.c

-- 
2.30.2


             reply	other threads:[~2021-09-07 12:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 12:22 Adhemerval Zanella via Libc-alpha [this message]
2021-09-07 12:22 ` [PATCH v2 1/3] misc: Add __get_nprocs_sched Adhemerval Zanella via Libc-alpha
2021-09-13 11:05   ` Florian Weimer via Libc-alpha
2021-09-07 12:22 ` [PATCH v2 2/3] linux: Simplify get_nprocs Adhemerval Zanella via Libc-alpha
2021-09-13 11:04   ` Florian Weimer via Libc-alpha
2021-09-07 12:22 ` [PATCH v2 3/3] linux: Revert the use of sched_getaffinity on get_nproc (BZ #28310) Adhemerval Zanella via Libc-alpha
2021-09-13 11:05   ` Florian Weimer via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907122259.79800-1-adhemerval.zanella@linaro.org \
    --to=libc-alpha@sourceware.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=nsaenzju@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).