From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id ACC401F8C6 for ; Mon, 23 Aug 2021 20:04:50 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D89A43858404 for ; Mon, 23 Aug 2021 20:04:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D89A43858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629749089; bh=KaisP4OpnlU/GD0UFTs3CwVlMURkyrrtQddz8SZCt5s=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ic6JkX8gc9M6OOy3Yf1d9rM2VaPQb0OmyKZFQb9ajpLckkvxOni2PxEZbjmVxEj9V JGSEW309R89jyTqvIdKzKgmyMzQQqX2eF4UxsWo7VCrVfpWHmx35IqHQukOnSdy1FY SYyUtt/8Ou/C7dni8/fSQLUKxsDdwbRURCgRNtBY= Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id 70DA03858025 for ; Mon, 23 Aug 2021 19:52:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 70DA03858025 Received: by mail-qt1-x833.google.com with SMTP id e3so8634744qth.9 for ; Mon, 23 Aug 2021 12:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KaisP4OpnlU/GD0UFTs3CwVlMURkyrrtQddz8SZCt5s=; b=n+YVt/7rj03GImYHFUbQI1V7I/5xP79G2QAaZIjibjFgguMGBsLh5nIjaiix8hkWFU W/zz47MduvSFJsxlcK2ShgTnZ5XX6jRiTc54l/RYumPtYyHCuUz9vIrIiMJzDxw+DhOY CQx0NGSXZlvPotvFKR7EcB8cQs3XjyDqhPLC2JfPzbqkYrQ1koTBrjk04VKs5+85yRKP z7BQO3ZPBN7ZgJdUzRTCWvQQ2lgoq7ZfTYqSGQIPHvVMUhNCJ69dpgfR22YO4C0YFye2 aHBaeYCu454JVnORt4mUvv0IqywzpfKmgMJVntHso91nj7aDDj3a6AdOGXscZ/CGvgE4 RA0w== X-Gm-Message-State: AOAM532vU8MstMzwVR67U41rNypChhvkyWbJLUzB/AQRNCACnrC9x4Rx iOkLNi5rpV964BqxVbrQH3JC4MPSOb/7wA== X-Google-Smtp-Source: ABdhPJyrhUdgztbYj9enZ1hyt6eFbPkOx1mndIN9kb7eeswvdMKWXPQQ8bI3+LHTsEmtQShpbcGJ7w== X-Received: by 2002:a05:622a:1387:: with SMTP id o7mr31681433qtk.19.1629748336930; Mon, 23 Aug 2021 12:52:16 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:cd83:c38b:b50d:5d9a:43d4]) by smtp.gmail.com with ESMTPSA id s10sm9210935qko.134.2021.08.23.12.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 12:52:16 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v2 14/19] nptl: Use tidlock when accessing TID on pthread_setschedparam Date: Mon, 23 Aug 2021 16:50:42 -0300 Message-Id: <20210823195047.543237-15-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210823195047.543237-1-adhemerval.zanella@linaro.org> References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Checked on x86_64-linux-gnu. --- nptl/pthread_setschedparam.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/nptl/pthread_setschedparam.c b/nptl/pthread_setschedparam.c index 70fa8378b8..75c796d9b8 100644 --- a/nptl/pthread_setschedparam.c +++ b/nptl/pthread_setschedparam.c @@ -30,12 +30,18 @@ __pthread_setschedparam (pthread_t threadid, int policy, struct pthread *pd = (struct pthread *) threadid; /* Make sure the descriptor is valid. */ - if (INVALID_TD_P (pd)) - /* Not a valid thread handle. */ - return ESRCH; + sigset_t oldmask; + __libc_signal_block_all (&oldmask); + lll_lock (pd->tidlock, LLL_PRIVATE); int result = 0; + if (pd->tid == 0) + { + result = ESRCH; + goto out; + } + /* See CREATE THREAD NOTES in nptl/pthread_create.c. */ lll_lock (pd->lock, LLL_PRIVATE); @@ -67,6 +73,10 @@ __pthread_setschedparam (pthread_t threadid, int policy, lll_unlock (pd->lock, LLL_PRIVATE); +out: + lll_unlock (pd->tidlock, LLL_PRIVATE); + __libc_signal_restore_set (&oldmask); + return result; } strong_alias (__pthread_setschedparam, pthread_setschedparam) -- 2.30.2