From: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
To: "Fāng-ruì Sòng" <maskray@google.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Remove sysdeps/*/tls-macros.h
Date: Wed, 18 Aug 2021 16:59:48 +0100 [thread overview]
Message-ID: <20210818155947.GI25257@arm.com> (raw)
In-Reply-To: <CAFP8O3L4pnwy0VKwzsc-1m2N4Mtn82nTkHkKB3Oe2L9sxB5i6Q@mail.gmail.com>
The 08/16/2021 12:34, Fāng-ruì Sòng via Libc-alpha wrote:
> On Mon, Aug 16, 2021 at 12:27 PM Fangrui Song <maskray@google.com> wrote:
> >
> > They provide TLS_GD/TLS_LD/TLS_IE/TLS_IE macros for TLS testing. Now that we
> > have migrated to __thread and tls_model attributes, these macros are unused
> > and thetls-macros.h files can retire.
> > ---
> > sysdeps/aarch64/tls-macros.h | 51 ---------
> > sysdeps/alpha/tls-macros.h | 25 -----
> > sysdeps/arc/tls-macros.h | 47 --------
> > sysdeps/arm/tls-macros.h | 72 -------------
> > sysdeps/csky/abiv2/tls-macros.h | 55 ----------
> > sysdeps/generic/tls-macros.h | 12 ---
> > sysdeps/hppa/tls-macros.h | 114 --------------------
> > sysdeps/i386/tls-macros.h | 47 --------
> > sysdeps/ia64/tls-macros.h | 66 ------------
> > sysdeps/m68k/tls-macros.h | 68 ------------
> > sysdeps/microblaze/tls-macros.h | 46 --------
> > sysdeps/mips/tls-macros.h | 130 ----------------------
> > sysdeps/nios2/tls-macros.h | 46 --------
> > sysdeps/powerpc/powerpc32/tls-macros.h | 49 ---------
> > sysdeps/powerpc/powerpc64/tls-macros.h | 42 --------
> > sysdeps/powerpc/tls-macros.h | 3 -
> > sysdeps/riscv/tls-macros.h | 47 --------
> > sysdeps/s390/s390-32/tls-macros.h | 106 ------------------
> > sysdeps/s390/s390-64/tls-macros.h | 90 ----------------
> > sysdeps/sh/tls-macros.h | 143 -------------------------
> > sysdeps/sparc/sparc32/tls-macros.h | 66 ------------
> > sysdeps/sparc/sparc64/tls-macros.h | 65 -----------
> > sysdeps/x86_64/tls-macros.h | 39 -------
> > 23 files changed, 1429 deletions(-)
> > delete mode 100644 sysdeps/aarch64/tls-macros.h
> > delete mode 100644 sysdeps/alpha/tls-macros.h
> > delete mode 100644 sysdeps/arc/tls-macros.h
> > delete mode 100644 sysdeps/arm/tls-macros.h
> > delete mode 100644 sysdeps/csky/abiv2/tls-macros.h
> > delete mode 100644 sysdeps/generic/tls-macros.h
> > delete mode 100644 sysdeps/hppa/tls-macros.h
> > delete mode 100644 sysdeps/i386/tls-macros.h
> > delete mode 100644 sysdeps/ia64/tls-macros.h
> > delete mode 100644 sysdeps/m68k/tls-macros.h
> > delete mode 100644 sysdeps/microblaze/tls-macros.h
> > delete mode 100644 sysdeps/mips/tls-macros.h
> > delete mode 100644 sysdeps/nios2/tls-macros.h
> > delete mode 100644 sysdeps/powerpc/powerpc32/tls-macros.h
> > delete mode 100644 sysdeps/powerpc/powerpc64/tls-macros.h
> > delete mode 100644 sysdeps/powerpc/tls-macros.h
> > delete mode 100644 sysdeps/riscv/tls-macros.h
> > delete mode 100644 sysdeps/s390/s390-32/tls-macros.h
> > delete mode 100644 sysdeps/s390/s390-64/tls-macros.h
> > delete mode 100644 sysdeps/sh/tls-macros.h
> > delete mode 100644 sysdeps/sparc/sparc32/tls-macros.h
> > delete mode 100644 sysdeps/sparc/sparc64/tls-macros.h
> > delete mode 100644 sysdeps/x86_64/tls-macros.h
>
> My local commit also deletes tls-macro.h lines from
> benchtests/strcoll-inputs/filelist#en_US.UTF-8.
>
> Sorry, the sent diff does not include them.
>
> rg -w tls-macros.h -g '!out' -g '!ChangeLog*'
> rg -w TLS_LD -g '!out' -g '!ChangeLog*' # and TLS_GD TLS_IE TLS_LE
>
> have no result.
I think this is OK with those changes. thanks.
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
prev parent reply other threads:[~2021-08-18 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 19:27 [PATCH] Remove sysdeps/*/tls-macros.h Fangrui Song via Libc-alpha
2021-08-16 19:34 ` Fāng-ruì Sòng via Libc-alpha
2021-08-18 15:59 ` Szabolcs Nagy via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818155947.GI25257@arm.com \
--to=libc-alpha@sourceware.org \
--cc=maskray@google.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).