From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7ECD81F8C6 for ; Thu, 12 Aug 2021 09:17:29 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70DA1383540F for ; Thu, 12 Aug 2021 09:17:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70DA1383540F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628759848; bh=nh/BYh3EJy4a2W7C/toLGLd3M2lYLxBwjuuzjXaYcYI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xyJQpsZhK2Av3o6QJ92xrJ0ukpE2qm0FlCF9RBynjxD3frzsYAhGrmcOYdJbZH/cl P7cD9tuQImXp/XE8rShQPAJ847sDPN6G6CqUIsvjs4PRNvZvncaRMlBbDcvZn+h/WQ d1tbGtmPKdpkL6XuNdLRcukhdGu/LBRdWPzp32rw= Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70047.outbound.protection.outlook.com [40.107.7.47]) by sourceware.org (Postfix) with ESMTPS id 007C2385783E for ; Thu, 12 Aug 2021 09:16:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 007C2385783E Received: from AM0PR07CA0022.eurprd07.prod.outlook.com (2603:10a6:208:ac::35) by AM8PR08MB6369.eurprd08.prod.outlook.com (2603:10a6:20b:354::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Thu, 12 Aug 2021 09:16:55 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:ac:cafe::82) by AM0PR07CA0022.outlook.office365.com (2603:10a6:208:ac::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.8 via Frontend Transport; Thu, 12 Aug 2021 09:16:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16 via Frontend Transport; Thu, 12 Aug 2021 09:16:55 +0000 Received: ("Tessian outbound 8b41f5fb4e9e:v103"); Thu, 12 Aug 2021 09:16:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2edb904889d4a5b5 X-CR-MTA-TID: 64aa7808 Received: from a80ba62d8502.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4DE68227-2D71-49DC-A136-F0C763351D28.1; Thu, 12 Aug 2021 09:16:47 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a80ba62d8502.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Aug 2021 09:16:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VdLYvVcnXNl/KX/rHa/GZ2NMA/cjsCvXiSbVkf4Coc7jqFmUZ4VCACVKlHA0ABEKXtgnCMh8UVaFlbrOot4YW8fgj+tzXnVgrfjy3kefGIQT4hm/Q9y3u03lkauARKm+BudFYiIQvg4Z8TZmrY/A3nDC2jgwODVHs+De9HwewZmvn8R6x6Q3lVlSAKXyT5WKQAye+8dvTJfrvAxl9MoU1i54jmBBFdb22pzPQypihHzIQuZGhEsFcMWZ/aoALxKsRxc6ckWAZ/q2SKrmbPGXWe73uA4iR5HU7zs2ZE0O93QI+pn12P/7uOT6aphvfQE1DGk9RerszDGieGZNYNwkOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nh/BYh3EJy4a2W7C/toLGLd3M2lYLxBwjuuzjXaYcYI=; b=XjCnNHwqjGUtJQeSDbbYC9Or3vcMoDp34N4//pnhuekvlF6MGSsVI0UPNe1lwJcVB1VOQp5Wds8jpiClA1gLGGZ0L/2XKuhAV/Buza5ETHDkIvKXFyi2G8Tij2fn5dsmcyqVDxE+Fby5tGR2erFG2EC7ZLOUD74x6udU3RBgNF/1Xvwe6u/fft04dRZv2M9qoZiTbqSMhCmhBQseB8U43JQoSKqlBnAdXXGMmqEqxipWhjYW9pj0tTwFmEpwPgM4bSmmjp5i1m+VpUDtaLEGQdxZxjoVJrJs60AIMo7icU1bjdvrrpdp+EmAk1X+61CqAT6evxy6xL+gkWYixO/Q5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PA4PR08MB6080.eurprd08.prod.outlook.com (2603:10a6:102:ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Thu, 12 Aug 2021 09:16:43 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::cd22:a583:c97c:72a6]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::cd22:a583:c97c:72a6%7]) with mapi id 15.20.4415.017; Thu, 12 Aug 2021 09:16:43 +0000 Date: Thu, 12 Aug 2021 10:16:40 +0100 To: Fangrui Song Subject: Re: [PATCH] elf: Drop elf/tls-macros.h in favor of __thread and tls_model attributes [BZ #28152] [BZ #28205] Message-ID: <20210812091638.GM20410@arm.com> References: <20210811213159.1647462-1-maskray@google.com> <20210811221150.mspqnhxlspumgjvg@google.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210811221150.mspqnhxlspumgjvg@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: LO4P123CA0011.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::16) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.49) by LO4P123CA0011.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Thu, 12 Aug 2021 09:16:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18b577df-5403-42bc-a4a0-08d95d71ee02 X-MS-TrafficTypeDiagnostic: PA4PR08MB6080:|AM8PR08MB6369: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AH8x7MPm0qIbL05W2XrGGWKrEOtfc0cyAT9lo4VfN92SLECWIM57i+IVxieAeyYS0lh/mNNq1VQ32sGV0DR37Ebcu+mrAHe+TU/o8+5S3emyjpxGGQLkONbUUU/EvTK5Z+Mn4cjOM8RjIUE/ss/v+NpEgcFTdhkHCRzyk6l+feU/KaHYhOqJUdU852nJR7chhDf7JYdY3BLArMD8fmTb9hmolXivxb5+hj3XocYIn2EmkLcQl4+pqqXb8AuNXThHbjHH1eVL/q7Xp2HMX93j08ABCFPuSxcDUBfiSjCgREJsHTD+WJQqVLEKmeitckrxdTuTPAEIyo1M9riWefQCPmpVJ1k/mFBfk+YjXo7kQwVDS1phneXl3cq7aLqfbXHH6RoL01WVB5vhwzSOEEJr9MEiylU+YBjzZUTSuX5rt5F5xYUfnw2pQ0b9sqRZKNaLnlU6kgXWHd89MpDz56+QzYvVHl7MzeLHpjKRkB1UCtgMHMHEJyW64ujOZEjaOrhJBO83ig9n/uqDHQtznrQ1Q/2ALfpRW927NdD+XaBiSZbTLq4CXh38HvYwIQtzT8L8mPowx+1nlWF1Bu7IltfAVjajKUDAE9IOEZK2tpdiqB4sNaH9egSiPfkZqRWltBDp1FBoxc0mFPw12oykZGfZs2uV9H0T9tXkMMQE3BG7s9btcH84cvpeO7+v1Hfp74MsXPP0YNxgHX54ihLokM6sRg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39850400004)(44832011)(4326008)(86362001)(8676002)(478600001)(66476007)(1076003)(36756003)(66946007)(2616005)(956004)(66556008)(8936002)(2906002)(38100700002)(38350700002)(26005)(55016002)(6916009)(83380400001)(186003)(7696005)(52116002)(33656002)(8886007)(316002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjJBMVlZS0JXVUtLT0UzYWxNT1Vwc2M4bXlBNzZObUFNTzVSNkZ4UHJVRm5t?= =?utf-8?B?ZzZZMFJ0azB0dmdob292S3cyVVcyK1dKU1VoRDFvNUEwRjVpeVh1NU93ejRY?= =?utf-8?B?L2dtNnlLOTFjbVdyL244dkFpVUVMNTdwbTVMNy9va0JoeU44Y0R0dTA4dDR0?= =?utf-8?B?Uys3Y25tdmtQckRVMFdmRGpVamhaS1FQb2NpYTdEMnJGWmNZVlBFZWs0K0kv?= =?utf-8?B?TXlEbkpUcTlwZGM2RlB2UHFDOGUxZ201RmJJbUlUWG5LdG11SzRHT1BKcEwx?= =?utf-8?B?TFhzZUs3aGFIMTRZQklTUUE2SlFWUXhJS2srckUxVlpIbDZHSXRQbXhNUHNv?= =?utf-8?B?d1pSZ3pQUzFCVDBsK3Z0NnBMRzVmV2p0amdHOVZmTUw4RlFXcEVKNHAvNHpk?= =?utf-8?B?a3EyeXNHcDBjWE5VOGl2bzhyajVFUm0vUWptUE02NWNTOHh2a2loYk9tU21J?= =?utf-8?B?UE16Z1JDa0FZTWhXMXhKcUxnUkJUUGVpMTR4UUdueWFYVG1qUUEvaVJ1eE9u?= =?utf-8?B?bnpIQnJSRGF0dkRzVm5oTFVnSE12Q0RheWc4UkpYanUxZDZZVlUwVVB5UWs1?= =?utf-8?B?YUxVZGkvbjBqb0xjQ3dFNDNUSWtrNXR0KzN1ekNRR3hEQjFHVEVkaWNtWHB1?= =?utf-8?B?Zk1JR1dqcUZMQnhoZFJTSkx5QjhSL3VKSDU2QkNMd2xMQzFBTEt1YVZ0VllS?= =?utf-8?B?MitvN3BzK0tWUDJld3FJM1R3QStjWWY0RUdJSXE5b1hoeFJYQ1kyelEyVGIw?= =?utf-8?B?d1RIa0laU1lJTG5pR01aYm1PQ0I2dHY3aDhXVGlUdnhhMDdycHlGMzBPTUZi?= =?utf-8?B?MkNSVUVhdXNFZ3IzT0VOWWViR0dVaU16YzZ0YXo1Y1VMbXZDSXJiRXZPQVlz?= =?utf-8?B?bURGZThXbkhnNWFjVUtQZytodkJVeURCS010MXNtNStINEVobjlPbUJHQ3JG?= =?utf-8?B?Q3lRWXVnSXVXbWJQZytEamFvUThkd3BuemVJZEI0elZEc3dmTWM5Y0lyeWxG?= =?utf-8?B?M2dJV0xaQkxZMC9FQ2dhWDc1cU5oN1JERnQzRVliTWY5YUFCQm05ZXNWSUdO?= =?utf-8?B?QlpTVGk1VkY2Y09lS1VNRjBHOWFhZVRuMUZ2YnRYV3VRNWFua2NoSlQvTXVK?= =?utf-8?B?eFdWVUJwU0NkendNb0xna3pDV0VRR256UFQvZmRNQVlwSTMzWElhRG9LNHk4?= =?utf-8?B?clk3aUhocVp5cXF2NDZzcHpOc0orSnVuYVZ2K2hpb0pqRWF2VS93VHVZekYv?= =?utf-8?B?L2M2ZDZ6YXh1YkNsVWRNTStjSFBORVE4Sk9tc01hZ05xWklTeEg4bW9TVVB2?= =?utf-8?B?a2JHZzF0S0tTRmJoRCtSSC9iN1BFUFRFNjBzRVBnbG9yb29LS0hUUlBpZlpJ?= =?utf-8?B?ZkswSXdqQkIwK0RxbTBqMHpqdVpzcjJaa2NFOEdCR1pRai8zaWVwM0lVSkNz?= =?utf-8?B?M0VWSVoydW9YUTNMRzRLRVhEOHV1Ty9EUlZXaEZjYVJ0ZUZ1UncvRmE4c3lq?= =?utf-8?B?TTMyNTRQUEZjV1dNR0hzNGhOUGM2RTQwWnBtVHYvdm0yZ05Gb0RteElTcjFV?= =?utf-8?B?amowOE9yU2ZqWmw5T3d0T2ozeHQ4QlN1K3lGOEJZSVkzcU02VzJ4QW5EeG9l?= =?utf-8?B?bEVZWTBHeHFVdUNRS21JY0dSelRyUDZieG5icjRIRm1WVTk1Wk9nMTlxeEZk?= =?utf-8?B?V1diY0U5R3hQQUVBVlRiSDBCY0FtT25FaXhvY2FidWJCc3ducXdCb0d3Unh0?= =?utf-8?Q?Tfr320kXgaTzd/qnf+DBhj4CyLNT7oc7VJd/9j6?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6080 Original-Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7f354129-ccb6-4c61-116b-08d95d71e6ac X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gevCS5vMDNUfCPvQR1DN50IygXdIwR0zn/K3ycltIrEURo/20QbSF8XG4xqm7BOsYlaFKQ97RkghvrqKNFuAmlXga5HPCNoTcQ9qiN7xkJMxjfvLCV5aUCyl54FGS+8vm1kxRi/wcEEuB79RVxwJ65CbtIY3DOxt0yU2Dxx5YWy/211MeJYCbGNCgIo1MQWBA6ZMJkW7/0kbCdO0TmLyey658ZOE+jq45vPzoWNbqQ3YdZG4MKUjsSMB35EzgVoUPklcA45599vHGTrqrXN3A+4KZcVrzYB/jdwBgGmrnyS5s9A0X5ZV623dnUgoYy+GlDrCqwe6feoH/Wo/ECLoNyOsSJ5uBwTuhNm+gYru/YT4E2P/8vFXF09vVKo8uhamNX0zCeP7OGZFX2yofp6YuWN08vhffqhLVtBNZboVeM0Nob8w6vaYq+wX6l0NBZKWdnsebtR6SquGBX5dlmkb8vjEC8oPIQFhp8SHIVWwFQnh7Lj88X6gUhvkDEsjjD55/o6VnZeUdD/Oc6JPSWnLbsmEfE9XRVzJri/e1dba7gtwiS1zPZxfUaC/2E6EheA0Cn7bsjnrZ8jWgJg+yX+fmqtXQ+AverkuU65nbUvXou6az6rNndfGgT1/jWFWOlc8xugaXK13rfBwoGCoHg2+LiNUFuMKphTlgJX/rirY9dKminzKZXGneVxcqzdeKwENl5nA51aqjpVqYX1FTivoaQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(346002)(39850400004)(396003)(376002)(46966006)(36840700001)(36860700001)(316002)(36756003)(33656002)(8936002)(47076005)(1076003)(86362001)(8676002)(478600001)(8886007)(70206006)(4326008)(5660300002)(7696005)(356005)(956004)(55016002)(2616005)(44832011)(82740400003)(2906002)(81166007)(82310400003)(83380400001)(70586007)(186003)(336012)(26005)(6862004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2021 09:16:55.4074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18b577df-5403-42bc-a4a0-08d95d71ee02 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6369 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Szabolcs Nagy via Libc-alpha Reply-To: Szabolcs Nagy Cc: libc-alpha@sourceware.org, Joseph Myers Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" The 08/11/2021 15:11, Fangrui Song via Libc-alpha wrote: > On 2021-08-11, Joseph Myers wrote: > > On Wed, 11 Aug 2021, Fangrui Song via Libc-alpha wrote: > > > > > As a future clean-up, TLS_LD/TLS_IE/TLS_IE macros can be removed from > > > sysdeps/*/tls-macros.h. aarch64 TLS_GD definition should be retained to > > > test traditional TLS GD while the toolchain default is TLSDESC. > > > > It might be better to test different TLS dialects through the compiler > > generating appropriate code rather than keeping such macros around. E.g., > > have a way for architectures to declare a set of supported -mtls-dialect= > > arguments (or detect them at configure time, at present there's a test for > > -mtls-dialect=gnu2 support), and, when more than one dialect is supported, > > run various tests explicitly for each dialect supported by the compiler, > > in addition to testing whatever the default dialect is. yeah i prefer not to keep TLS_GD for aarch64 but use -mtls-dialect= for tests if we care enough. > __thread int foo, bar; > extern __thread int foo_gd asm ("foo") __attribute__ ((tls_model("global-dynamic"))); > extern __thread int foo_ld asm ("foo") __attribute__ ((tls_model("local-dynamic"))); > extern __thread int foo_ie asm ("foo") __attribute__ ((tls_model("initial-exec"))); > extern __thread int bar_gd asm ("bar") __attribute__ ((tls_model("global-dynamic"))); > extern __thread int bar_ld asm ("bar") __attribute__ ((tls_model("local-dynamic"))); > extern __thread int bar_ie asm ("bar") __attribute__ ((tls_model("initial-exec"))); > > Add > > extern __thread int foo_le asm ("foo") __attribute__ ((tls_model("local-exec"))); > > even if the default foo for non-PIC is local-exec? i think adding an explicit declaration like that is clearer.