From: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4 4/5] AArch64: Improve A64FX memset by removing unroll32
Date: Tue, 10 Aug 2021 10:43:11 +0100 [thread overview]
Message-ID: <20210810094310.GF20410@arm.com> (raw)
In-Reply-To: <VE1PR08MB5599EF32635A6AB87F3106BC83F69@VE1PR08MB5599.eurprd08.prod.outlook.com>
The 08/09/2021 13:13, Wilco Dijkstra via Libc-alpha wrote:
> v4: no changes
>
> Remove unroll32 code since it doesn't improve performance.
OK to commit, but keep
Reviewed-by: Naohiro Tamura <naohirot@fujitsu.com>
>
> ---
>
> diff --git a/sysdeps/aarch64/multiarch/memset_a64fx.S b/sysdeps/aarch64/multiarch/memset_a64fx.S
> index 55f28b644defdffb140c88da0635ef099235546c..89dba912588c243e67a9527a56b4d3a44659d542 100644
> --- a/sysdeps/aarch64/multiarch/memset_a64fx.S
> +++ b/sysdeps/aarch64/multiarch/memset_a64fx.S
> @@ -102,22 +102,6 @@ L(vl_agnostic): // VL Agnostic
> ccmp vector_length, tmp1, 0, cs
> b.eq L(L1_prefetch)
>
> -L(unroll32):
> - lsl tmp1, vector_length, 3 // vector_length * 8
> - lsl tmp2, vector_length, 5 // vector_length * 32
> - .p2align 3
> -1: cmp rest, tmp2
> - b.cc L(unroll8)
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - sub rest, rest, tmp2
> - b 1b
>
> L(unroll8):
> lsl tmp1, vector_length, 3
> @@ -155,7 +139,7 @@ L(L1_prefetch): // if rest >= L1_SIZE
> sub rest, rest, CACHE_LINE_SIZE * 2
> cmp rest, L1_SIZE
> b.ge 1b
> - cbnz rest, L(unroll32)
> + cbnz rest, L(unroll8)
> ret
>
> // count >= L2_SIZE
>
--
prev parent reply other threads:[~2021-08-10 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 13:13 [PATCH v4 4/5] AArch64: Improve A64FX memset by removing unroll32 Wilco Dijkstra via Libc-alpha
2021-08-10 9:43 ` Szabolcs Nagy via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810094310.GF20410@arm.com \
--to=libc-alpha@sourceware.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).