From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4E61A1F8C6 for ; Mon, 9 Aug 2021 00:47:03 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E6CD384BC3C for ; Mon, 9 Aug 2021 00:47:01 +0000 (GMT) Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id A65B5385782B for ; Mon, 9 Aug 2021 00:46:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A65B5385782B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id EF41F72C8F8; Mon, 9 Aug 2021 03:46:48 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id E05367CF728; Mon, 9 Aug 2021 03:46:48 +0300 (MSK) Date: Mon, 9 Aug 2021 03:46:48 +0300 From: "Dmitry V. Levin" To: Nikita Ermakov Subject: Re: [PATCH] elf: Use the 64-bit wide 'seen' variable Message-ID: <20210809004648.GB2038@altlinux.org> References: <20210807142223.58295-1-sh1r4s3@mail.si-head.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210807142223.58295-1-sh1r4s3@mail.si-head.nl> X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Sat, Aug 07, 2021 at 05:22:23PM +0300, Nikita Ermakov via Libc-alpha wrote: > The 32-bit 'seen' variable doesn't allow to check any auxiliary entry > type with a value greater than 31 as it leads to wrapping and crumbling > of the 'seen' variable. > > For example, if AT_UID (which is 11) would precede AT_L1D_CACHEGEOMETRY > (which is 43), then uid would be overridden by an AT_L1D_CACHEGEOMETRY > value. > > Using 64-bit wide 'seen' variable allows to handle such situations. I agree with the analysis, but I'm not sure uint64_t would be the most appropriate type in this case. I'd suggest to consider using uintmax_t instead. -- ldv