From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 044891F8C6 for ; Tue, 3 Aug 2021 15:15:48 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2AFE33889C3C for ; Tue, 3 Aug 2021 15:15:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AFE33889C3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628003747; bh=qhQlxf6m6kbtT/LqpH47hiYnm05YHKnIP0/3XkrZYA4=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iHjMkNCVB16Qus/nAILJXFKTgNuFAk7TtqkoUNhmBsoMVkY78j5f0kHDqa6wK2mmA 3kF04vZLEV76CqNlxgMhhb4DbG83sQDz9ika8sj+0yxWxyBEa9UA7HQhcweBJVHmm2 Xe554h8guDSPy/yj5fEbkFuRJE0cN6DfxunCBzKo= Received: from anamika.lostca.se (anamika.lostca.se [IPv6:2a01:4f9:3b:505c::2]) by sourceware.org (Postfix) with ESMTPS id 28BCA386100C; Tue, 3 Aug 2021 15:15:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28BCA386100C Received: from localhost (mail.lostca.se [65.21.75.227]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: spectre) by anamika.lostca.se (Postfix) with ESMTPSA id 16D981B3FE; Tue, 3 Aug 2021 15:15:26 +0000 (UTC) Date: Tue, 3 Aug 2021 15:15:25 +0000 To: Siddhesh Poyarekar Subject: Re: [PATCH 3/5] iconv_charmap: Close output file when done Message-ID: <20210803151525.GC6986@lostca.se> References: <20210727174129.3612656-1-siddhesh@sourceware.org> <20210727174129.3612656-4-siddhesh@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727174129.3612656-4-siddhesh@sourceware.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Arjun Shankar via Libc-alpha Reply-To: Arjun Shankar Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Siddhesh, > --- > iconv/iconv_charmap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/iconv/iconv_charmap.c b/iconv/iconv_charmap.c > index e2d53fee3c..a8b6b56124 100644 > --- a/iconv/iconv_charmap.c > +++ b/iconv/iconv_charmap.c > @@ -234,6 +234,8 @@ charmap_conversion (const char *from_code, struct charmap_t *from_charmap, > while (++remaining < argc); > > /* All done. */ > + if (output != stdout) > + fclose (output); > free_table (cvtbl); > return status; > } Earlier on, output is either the result of an fopen, or assigned stdout. So, this change looks right. Reviewed-by: Arjun Shankar Cheers!