unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 0/5] Static analysis fixes
Date: Tue, 27 Jul 2021 23:11:24 +0530	[thread overview]
Message-ID: <20210727174129.3612656-1-siddhesh@sourceware.org> (raw)

These are some issues identified through static analysis.  The
gaiconf_init implementation is quite ugly and needs a refactor, but the
patch 5/5 is a minimal fix to ensure that a double-free is avoided.

Siddhesh Poyarekar (5):
  ldconfig: avoid leak on empty paths in config file
  gconv_parseconfdir: Fix memory leak
  iconv_charmap: Close output file when done
  copy_and_spawn_sgid: Avoid double calls to close()
  gaiconf_init: Avoid double-free in label and precedence lists

 elf/ldconfig.c                       | 6 +++++-
 iconv/gconv_parseconfdir.h           | 9 ++++-----
 iconv/iconv_charmap.c                | 2 ++
 support/support_capture_subprocess.c | 1 +
 sysdeps/posix/getaddrinfo.c          | 2 ++
 5 files changed, 14 insertions(+), 6 deletions(-)

-- 
2.31.1


             reply	other threads:[~2021-07-27 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 17:41 Siddhesh Poyarekar via Libc-alpha [this message]
2021-07-27 17:41 ` [PATCH 1/5] ldconfig: avoid leak on empty paths in config file Siddhesh Poyarekar via Libc-alpha
2021-08-03 15:08   ` Arjun Shankar via Libc-alpha
2021-07-27 17:41 ` [PATCH 2/5] gconv_parseconfdir: Fix memory leak Siddhesh Poyarekar via Libc-alpha
2021-08-03 15:09   ` Arjun Shankar via Libc-alpha
2021-07-27 17:41 ` [PATCH 3/5] iconv_charmap: Close output file when done Siddhesh Poyarekar via Libc-alpha
2021-08-03 15:15   ` Arjun Shankar via Libc-alpha
2021-07-27 17:41 ` [PATCH 4/5] copy_and_spawn_sgid: Avoid double calls to close() Siddhesh Poyarekar via Libc-alpha
2021-08-03 15:25   ` Arjun Shankar via Libc-alpha
2021-07-27 17:41 ` [PATCH 5/5] gaiconf_init: Avoid double-free in label and precedence lists Siddhesh Poyarekar via Libc-alpha
2021-08-03 15:34   ` Arjun Shankar via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210727174129.3612656-1-siddhesh@sourceware.org \
    --to=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).